| Message ID | 20210416183106.1516563-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | target/arm mte fixes | expand |
Patchew URL: https://patchew.org/QEMU/20210416183106.1516563-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210416183106.1516563-1-richard.henderson@linaro.org
Subject: [PATCH v5 for-6.1 0/9] target/arm mte fixes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1618538904-93433-1-git-send-email-robert.hu@linux.intel.com -> patchew/1618538904-93433-1-git-send-email-robert.hu@linux.intel.com
- [tag update] patchew/20210415163304.4120052-1-philmd@redhat.com -> patchew/20210415163304.4120052-1-philmd@redhat.com
- [tag update] patchew/20210415215141.1865467-1-crosa@redhat.com -> patchew/20210415215141.1865467-1-crosa@redhat.com
- [tag update] patchew/20210416135543.20382-1-peter.maydell@linaro.org -> patchew/20210416135543.20382-1-peter.maydell@linaro.org
* [new tag] patchew/20210416183106.1516563-1-richard.henderson@linaro.org -> patchew/20210416183106.1516563-1-richard.henderson@linaro.org
Switched to a new branch 'test'
d69e1f6 target/arm: Remove log2_esize parameter to gen_mte_checkN
8143076 target/arm: Simplify sve mte checking
5bb12a8 target/arm: Rename mte_probe1 to mte_probe
094ca80 target/arm: Merge mte_check1, mte_checkN
2cddd7b target/arm: Replace MTEDESC ESIZE+TSIZE with SIZEM1
dcb93c0 test/tcg/aarch64: Add mte-5
cc6775d target/arm: Fix unaligned checks for mte_check1, mte_probe1
ffe6817 target/arm: Split out mte_probe_int
98268e3 target/arm: Fix mte_checkN
=== OUTPUT BEGIN ===
1/9 Checking commit 98268e3a7258 (target/arm: Fix mte_checkN)
2/9 Checking commit ffe6817056f9 (target/arm: Split out mte_probe_int)
3/9 Checking commit cc6775db8723 (target/arm: Fix unaligned checks for mte_check1, mte_probe1)
4/9 Checking commit dcb93c0b91aa (test/tcg/aarch64: Add mte-5)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30:
new file mode 100644
total: 0 errors, 1 warnings, 52 lines checked
Patch 4/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/9 Checking commit 2cddd7b85b5b (target/arm: Replace MTEDESC ESIZE+TSIZE with SIZEM1)
6/9 Checking commit 094ca8096fc4 (target/arm: Merge mte_check1, mte_checkN)
7/9 Checking commit 5bb12a81a235 (target/arm: Rename mte_probe1 to mte_probe)
8/9 Checking commit 814307626eca (target/arm: Simplify sve mte checking)
ERROR: spaces required around that '*' (ctx:WxV)
#96: FILE: target/arm/sve_helper.c:4438:
+ sve_ldst1_tlb_fn *tlb_fn)
^
ERROR: spaces required around that '*' (ctx:WxV)
#190: FILE: target/arm/sve_helper.c:5063:
+ sve_ldst1_tlb_fn *tlb_fn)
^
total: 2 errors, 0 warnings, 202 lines checked
Patch 8/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/9 Checking commit d69e1f685edb (target/arm: Remove log2_esize parameter to gen_mte_checkN)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210416183106.1516563-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Fri, 16 Apr 2021 at 19:31, Richard Henderson <richard.henderson@linaro.org> wrote: > > Changes for v5: > * Rebase. Three patches upstream and a minor conflict fixed. > > Changes for v4: > * Fix tag count computation error in mte_checkN, which when used > by mte_check1 in patch 5, caused all sorts of KASAN failures. > * Fix PAGE_ANON / PAGE_TARGET_1 overlap. > Since this is fully reviewed other than the minor comment tweak I suggested in patch 1, I'm going to apply it to target-arm.next (for 6.1) and make that comment change there rather than asking for a respin. thanks -- PMM
Changes for v5: * Rebase. Three patches upstream and a minor conflict fixed. Changes for v4: * Fix tag count computation error in mte_checkN, which when used by mte_check1 in patch 5, caused all sorts of KASAN failures. * Fix PAGE_ANON / PAGE_TARGET_1 overlap. r~ Richard Henderson (9): target/arm: Fix mte_checkN target/arm: Split out mte_probe_int target/arm: Fix unaligned checks for mte_check1, mte_probe1 test/tcg/aarch64: Add mte-5 target/arm: Replace MTEDESC ESIZE+TSIZE with SIZEM1 target/arm: Merge mte_check1, mte_checkN target/arm: Rename mte_probe1 to mte_probe target/arm: Simplify sve mte checking target/arm: Remove log2_esize parameter to gen_mte_checkN target/arm/helper-a64.h | 3 +- target/arm/internals.h | 11 +- target/arm/translate-a64.h | 2 +- target/arm/mte_helper.c | 183 ++++++++++++------------------ target/arm/sve_helper.c | 100 ++++++---------- target/arm/translate-a64.c | 22 ++-- target/arm/translate-sve.c | 9 +- tests/tcg/aarch64/mte-5.c | 44 +++++++ tests/tcg/aarch64/Makefile.target | 2 +- 9 files changed, 172 insertions(+), 204 deletions(-) create mode 100644 tests/tcg/aarch64/mte-5.c -- 2.25.1