diff mbox series

[v2] dt-bindings: serial: samsung: include generic dtschema to match bluetooth child

Message ID 20210405172119.7484-1-krzysztof.kozlowski@canonical.com
State Superseded
Headers show
Series [v2] dt-bindings: serial: samsung: include generic dtschema to match bluetooth child | expand

Commit Message

Krzysztof Kozlowski April 5, 2021, 5:21 p.m. UTC
From: Krzysztof Kozlowski <krzk@kernel.org>

Include the generic serial.yaml dtschema so the child node like
"bluetooh" will be properly matched:

  arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml:
    serial@13800000: 'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. Drop the new example, as Rob suggested.
---
 Documentation/devicetree/bindings/serial/samsung_uart.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Rob Herring April 9, 2021, 4:09 p.m. UTC | #1
On Mon, Apr 05, 2021 at 07:21:19PM +0200, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>

> 

> Include the generic serial.yaml dtschema so the child node like

> "bluetooh" will be properly matched:


typo

> 

>   arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml:

>     serial@13800000: 'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+'

> 

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

> 

> ---

> 

> Changes since v1:

> 1. Drop the new example, as Rob suggested.

> ---

>  Documentation/devicetree/bindings/serial/samsung_uart.yaml | 4 +++-

>  1 file changed, 3 insertions(+), 1 deletion(-)


Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>
Krzysztof Kozlowski April 9, 2021, 5:19 p.m. UTC | #2
On 09/04/2021 18:09, Rob Herring wrote:
> On Mon, Apr 05, 2021 at 07:21:19PM +0200, Krzysztof Kozlowski wrote:

>> From: Krzysztof Kozlowski <krzk@kernel.org>

>>

>> Include the generic serial.yaml dtschema so the child node like

>> "bluetooh" will be properly matched:

> 

> typo

> 

>>

>>   arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml:

>>     serial@13800000: 'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+'

>>

>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

>>

>> ---

>>

>> Changes since v1:

>> 1. Drop the new example, as Rob suggested.

>> ---

>>  Documentation/devicetree/bindings/serial/samsung_uart.yaml | 4 +++-

>>  1 file changed, 3 insertions(+), 1 deletion(-)

> 

> Otherwise,

> 

> Reviewed-by: Rob Herring <robh@kernel.org>


Thanks, I'll send with fixed typo.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
index 4f98a3896b3a..97ec8a093bf3 100644
--- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
+++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
@@ -79,9 +79,11 @@  required:
   - interrupts
   - reg
 
-additionalProperties: false
+unevaluatedProperties: false
 
 allOf:
+  - $ref: /schemas/serial.yaml#
+
   - if:
       properties:
         compatible: