| Message ID | 1617262301-47010-1-git-send-email-songzhiqi1@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | crypto: cbc - fix coding style | expand |
On Thu, Apr 01, 2021 at 03:31:41PM +0800, Zhiqi Song wrote: > Fixed following checkpatch error: > - do not use assignment in if condition > > Signed-off-by: Zhiqi Song <songzhiqi1@huawei.com> > --- > crypto/cbc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This patch does not appear to improve the code. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/crypto/cbc.c b/crypto/cbc.c index 6c03e96..152d48d 100644 --- a/crypto/cbc.c +++ b/crypto/cbc.c @@ -140,7 +140,8 @@ static int crypto_cbc_decrypt_inplace(struct skcipher_walk *walk, for (;;) { fn(tfm, src, src); - if ((nbytes -= bsize) < bsize) + nbytes -= bsize; + if (nbytes < bsize) break; crypto_xor(src, src - bsize, bsize); src -= bsize;
Fixed following checkpatch error: - do not use assignment in if condition Signed-off-by: Zhiqi Song <songzhiqi1@huawei.com> --- crypto/cbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)