| Message ID | 20201021135332.4928-1-fabrizio.castro.jz@renesas.com |
|---|---|
| Headers | show |
| Series | Add r8a77965 DRIF support | expand |
Hi Laurent, > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Sent: 21 October 2020 22:43 > Subject: Re: [PATCH v5 0/5] Add r8a77965 DRIF support > > Hi Fabrizio, > > On Wed, Oct 21, 2020 at 02:53:27PM +0100, Fabrizio Castro wrote: > > Dear All, > > > > this series is to add DRIF support for the r8a77965 > > (a.k.a. R-Car M3-N). Version 5 fixes a warning reported > > by 'make dt_binding_check', as reported by Rob. > > Patch 1/5 to 4/5 taken in my tree, I'll send a pull request to > linux-media when the merge window closes. I expect Geert to handle 5/5. Great, thank you. Fab > > > Fabrizio Castro (5): > > MAINTAINERS: Update MAINTAINERS for Renesas DRIF driver > > media: dt-bindings: media: renesas,drif: Convert to json-schema > > media: dt-bindings: media: renesas,drif: Add r8a77990 support > > media: dt-bindings: media: renesas,drif: Add r8a77965 support > > arm64: dts: r8a77965: Add DRIF support > > > > .../bindings/media/renesas,drif.txt | 177 ----------- > > .../bindings/media/renesas,drif.yaml | 279 ++++++++++++++++++ > > MAINTAINERS | 4 +- > > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 120 ++++++++ > > 4 files changed, 401 insertions(+), 179 deletions(-) > > delete mode 100644 > Documentation/devicetree/bindings/media/renesas,drif.txt > > create mode 100644 > Documentation/devicetree/bindings/media/renesas,drif.yaml > > -- > Regards, > > Laurent Pinchart
Hi Fabrizio, Rob, On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro <fabrizio.castro.jz@renesas.com> wrote: > Convert the Renesas DRIF bindings to DT schema and update > MAINTAINERS accordingly. > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Rob Herring <robh@kernel.org> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml > + clock-names: > + maxItems: 1 > + items: > + - const: fck With latest dt-schema, "make dt_binding_check" complains: Documentation/devicetree/bindings/media/renesas,drif.yaml: properties:clock-names:maxItems: False schema does not allow 1 Documentation/devicetree/bindings/media/renesas,drif.yaml: ignoring, error in schema: properties: clock-names: maxItems Using clock-names: const: fck Fixes that. However, I'm wondering why I do not get a complaint about the similar clock/clock-names in Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml. Because they're part of an else branch? Thanks! Gr{oetje,eeting}s, Geert
Hi Geert, Thank you for your feedback. > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: 14 January 2021 13:03 > Subject: Re: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: > Convert to json-schema > > Hi Fabrizio, Rob, > > On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro > <fabrizio.castro.jz@renesas.com> wrote: > > Convert the Renesas DRIF bindings to DT schema and update > > MAINTAINERS accordingly. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml > > > + clock-names: > > + maxItems: 1 > > + items: > > + - const: fck > > With latest dt-schema, "make dt_binding_check" complains: > > Documentation/devicetree/bindings/media/renesas,drif.yaml: > properties:clock-names:maxItems: False schema does not allow 1 > Documentation/devicetree/bindings/media/renesas,drif.yaml: > ignoring, error in schema: properties: clock-names: maxItems > > Using > > clock-names: > const: fck > > Fixes that. Do you need me to send a new version or are you going to amend this on your end? > > However, I'm wondering why I do not get a complaint about the similar > clock/clock-names in > Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml. > Because they're part of an else branch? Interesting, renesas,lvds.yaml doesn't seem to trigger the problem from within the "then" branch either if I hack it, it only seems to trigger the problem when outside the if statement. We probably need to remove "maxItems: 1" from renesas,lvds.yaml as well though, what do you think? Thanks, Fab > > Thanks! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds
Hi Geert, > From: Fabrizio Castro > Sent: 20 January 2021 18:19 > Subject: RE: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: > Convert to json-schema > > Hi Geert, > > Thank you for your feedback. > > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > Sent: 14 January 2021 13:03 > > Subject: Re: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: > > Convert to json-schema > > > > Hi Fabrizio, Rob, > > > > On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro > > <fabrizio.castro.jz@renesas.com> wrote: > > > Convert the Renesas DRIF bindings to DT schema and update > > > MAINTAINERS accordingly. > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml > > > > > + clock-names: > > > + maxItems: 1 > > > + items: > > > + - const: fck > > > > With latest dt-schema, "make dt_binding_check" complains: > > > > Documentation/devicetree/bindings/media/renesas,drif.yaml: > > properties:clock-names:maxItems: False schema does not allow 1 > > Documentation/devicetree/bindings/media/renesas,drif.yaml: > > ignoring, error in schema: properties: clock-names: maxItems > > > > Using > > > > clock-names: > > const: fck > > > > Fixes that. > > Do you need me to send a new version or are you going to amend > this on your end? Sorry, I have just realised Laurent handled this one. Thanks, Fab > > > > > However, I'm wondering why I do not get a complaint about the similar > > clock/clock-names in > > Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml. > > Because they're part of an else branch? > > Interesting, renesas,lvds.yaml doesn't seem to trigger the problem > from within the "then" branch either if I hack it, it only seems to > trigger the problem when outside the if statement. > > We probably need to remove "maxItems: 1" from renesas,lvds.yaml as > well though, what do you think? > > Thanks, > Fab > > > > > Thanks! > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > > m68k.org > > > > In personal conversations with technical people, I call myself a hacker. > > But > > when I'm talking to journalists I just say "programmer" or something > like > > that. > > -- Linus Torvalds
Hi Laurent, On 21/10/2020 23:43, Laurent Pinchart wrote: > Hi Fabrizio, > > On Wed, Oct 21, 2020 at 02:53:27PM +0100, Fabrizio Castro wrote: >> Dear All, >> >> this series is to add DRIF support for the r8a77965 >> (a.k.a. R-Car M3-N). Version 5 fixes a warning reported >> by 'make dt_binding_check', as reported by Rob. > > Patch 1/5 to 4/5 taken in my tree, I'll send a pull request to > linux-media when the merge window closes. I expect Geert to handle 5/5. Patch 5 has been merged, but patches 1-4 aren't. I don't think there was a PR for it. For some reason these patches are delegated to me in patchwork. I've now delegated them to you for further processing. Regards, Hans > >> Fabrizio Castro (5): >> MAINTAINERS: Update MAINTAINERS for Renesas DRIF driver >> media: dt-bindings: media: renesas,drif: Convert to json-schema >> media: dt-bindings: media: renesas,drif: Add r8a77990 support >> media: dt-bindings: media: renesas,drif: Add r8a77965 support >> arm64: dts: r8a77965: Add DRIF support >> >> .../bindings/media/renesas,drif.txt | 177 ----------- >> .../bindings/media/renesas,drif.yaml | 279 ++++++++++++++++++ >> MAINTAINERS | 4 +- >> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 120 ++++++++ >> 4 files changed, 401 insertions(+), 179 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/media/renesas,drif.txt >> create mode 100644 Documentation/devicetree/bindings/media/renesas,drif.yaml >
Hi Hans, On Sat, Mar 27, 2021 at 11:05:01AM +0100, Hans Verkuil wrote: > On 21/10/2020 23:43, Laurent Pinchart wrote: > > On Wed, Oct 21, 2020 at 02:53:27PM +0100, Fabrizio Castro wrote: > >> Dear All, > >> > >> this series is to add DRIF support for the r8a77965 > >> (a.k.a. R-Car M3-N). Version 5 fixes a warning reported > >> by 'make dt_binding_check', as reported by Rob. > > > > Patch 1/5 to 4/5 taken in my tree, I'll send a pull request to > > linux-media when the merge window closes. I expect Geert to handle 5/5. > > Patch 5 has been merged, but patches 1-4 aren't. I don't think there > was a PR for it. For some reason these patches are delegated to me in > patchwork. I've now delegated them to you for further processing. I've just sent a pull request, for these and other miscellaneous changes. > >> Fabrizio Castro (5): > >> MAINTAINERS: Update MAINTAINERS for Renesas DRIF driver > >> media: dt-bindings: media: renesas,drif: Convert to json-schema > >> media: dt-bindings: media: renesas,drif: Add r8a77990 support > >> media: dt-bindings: media: renesas,drif: Add r8a77965 support > >> arm64: dts: r8a77965: Add DRIF support > >> > >> .../bindings/media/renesas,drif.txt | 177 ----------- > >> .../bindings/media/renesas,drif.yaml | 279 ++++++++++++++++++ > >> MAINTAINERS | 4 +- > >> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 120 ++++++++ > >> 4 files changed, 401 insertions(+), 179 deletions(-) > >> delete mode 100644 Documentation/devicetree/bindings/media/renesas,drif.txt > >> create mode 100644 Documentation/devicetree/bindings/media/renesas,drif.yaml -- Regards, Laurent Pinchart
On Thu, Jan 14, 2021 at 7:02 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Fabrizio, Rob, > > On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro > <fabrizio.castro.jz@renesas.com> wrote: > > Convert the Renesas DRIF bindings to DT schema and update > > MAINTAINERS accordingly. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml > > > + clock-names: > > + maxItems: 1 > > + items: > > + - const: fck > > With latest dt-schema, "make dt_binding_check" complains: > > Documentation/devicetree/bindings/media/renesas,drif.yaml: > properties:clock-names:maxItems: False schema does not allow 1 > Documentation/devicetree/bindings/media/renesas,drif.yaml: > ignoring, error in schema: properties: clock-names: maxItems Seems this just got applied, and now this error is in linux-next. > > Using > > clock-names: > const: fck > > Fixes that. > > However, I'm wondering why I do not get a complaint about the similar > clock/clock-names in > Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml. > Because they're part of an else branch? Probably. if/then/else schemas have fewer checks as they can be incomplete (only additional constraints on the top-level schema). Rob
Hi Rob, thanks for your feedback. > From: Rob Herring <robh+dt@kernel.org> > Sent: 07 April 2021 19:27 > Subject: Re: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: > Convert to json-schema > > On Thu, Jan 14, 2021 at 7:02 AM Geert Uytterhoeven <geert@linux-m68k.org> > wrote: > > > > Hi Fabrizio, Rob, > > > > On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro > > <fabrizio.castro.jz@renesas.com> wrote: > > > Convert the Renesas DRIF bindings to DT schema and update > > > MAINTAINERS accordingly. > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml > > > > > + clock-names: > > > + maxItems: 1 > > > + items: > > > + - const: fck > > > > With latest dt-schema, "make dt_binding_check" complains: > > > > Documentation/devicetree/bindings/media/renesas,drif.yaml: > > properties:clock-names:maxItems: False schema does not allow 1 > > Documentation/devicetree/bindings/media/renesas,drif.yaml: > > ignoring, error in schema: properties: clock-names: maxItems > > Seems this just got applied, and now this error is in linux-next. I'll send a patch to fix the problem shortly. Thanks, Fab > > > > > Using > > > > clock-names: > > const: fck > > > > Fixes that. > > > > However, I'm wondering why I do not get a complaint about the similar > > clock/clock-names in > > Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml. > > Because they're part of an else branch? > > Probably. if/then/else schemas have fewer checks as they can be > incomplete (only additional constraints on the top-level schema). > > Rob