| Message ID | 20210406162802.9041-1-stephen@networkplumber.org |
|---|---|
| State | New |
| Headers | show |
| Series | [iproute2] erspan: fix JSON output | expand |
On Tue, Apr 6, 2021 at 9:28 AM Stephen Hemminger <stephen@networkplumber.org> wrote: > > The format for erspan output is not valid JSON. > The direction should be value and erspan_dir should be the key. > > Fixes: 289763626721 ("erspan: add erspan version II support") > Cc: u9012063@gmail.com > Reported-by: Christian Pössinger <christian@poessinger.com> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- LGTM, Thanks. Acked-by: William Tu <u9012063@gmail.com>
On Fri, Apr 9, 2021 at 3:50 AM Christian Poessinger <christian@poessinger.com> wrote: > > The format for erspan/erspan6 output is not valid JSON, as on version 2 a > valueless key was presented. The direction should be value and erspan_dir > should be the key. > > Fixes: 289763626721 ("erspan: add erspan version II support") > Cc: u9012063@gmail.com > Cc: Stephen Hemminger <stephen@networkplumber.org> > Reported-by: Christian Poessinger <christian@poessinger.com> > Signed-off-by: Christian Poessinger <christian@poessinger.com> > --- LGTM, thanks Acked-by: William Tu <u9012063@gmail.com>
diff --git a/ip/link_gre6.c b/ip/link_gre6.c index 9d270f4b4455..f33598af8989 100644 --- a/ip/link_gre6.c +++ b/ip/link_gre6.c @@ -594,10 +594,10 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) if (erspan_dir == 0) print_string(PRINT_ANY, "erspan_dir", - "erspan_dir ingress ", NULL); + "erspan_dir %s ", "ingress"); else print_string(PRINT_ANY, "erspan_dir", - "erspan_dir egress ", NULL); + "erspan_dir %s ", "egress"); } if (tb[IFLA_GRE_ERSPAN_HWID]) {
The format for erspan output is not valid JSON. The direction should be value and erspan_dir should be the key. Fixes: 289763626721 ("erspan: add erspan version II support") Cc: u9012063@gmail.com Reported-by: Christian Pössinger <christian@poessinger.com> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- ip/link_gre6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)