mbox series

[v1,0/3] Remove qe_io{read,write}* IO accessors

Message ID cover.1615053848.git.christophe.leroy@csgroup.eu
Headers show
Series Remove qe_io{read,write}* IO accessors | expand

Message

Christophe Leroy March 6, 2021, 6:09 p.m. UTC
Commit 6ac9b61786cc ("soc: fsl: qe: introduce qe_io{read,write}*
wrappers") added specific I/O accessors for qe because at that
time ioread/iowrite functions were sub-optimal on powerpc/32
compared to the architecture specific in_/out_ IO accessors.

But as ioread/iowrite accessors are now equivalent since
commit 894fa235eb4c ("powerpc: inline iomap accessors"),
use them in order to allow removal of the qe specific ones.

Christophe Leroy (3):
  soc: fsl: qe: replace qe_io{read,write}* wrappers by generic
    io{read,write}*
  tty: serial: ucc_uart: replace qe_io{read,write}* wrappers by generic
    io{read,write}*
  Revert "soc: fsl: qe: introduce qe_io{read,write}* wrappers"

 drivers/soc/fsl/qe/gpio.c     |  20 +++---
 drivers/soc/fsl/qe/qe.c       |  24 +++----
 drivers/soc/fsl/qe/qe_ic.c    |   4 +-
 drivers/soc/fsl/qe/qe_io.c    |  36 +++++-----
 drivers/soc/fsl/qe/ucc_fast.c |  68 +++++++++----------
 drivers/soc/fsl/qe/ucc_slow.c |  42 ++++++------
 drivers/tty/serial/ucc_uart.c | 124 +++++++++++++++++-----------------
 include/soc/fsl/qe/qe.h       |  34 +++-------
 8 files changed, 168 insertions(+), 184 deletions(-)

Comments

Greg Kroah-Hartman March 6, 2021, 7:23 p.m. UTC | #1
On Sat, Mar 06, 2021 at 06:09:30PM +0000, Christophe Leroy wrote:
> Commit 6ac9b61786cc ("soc: fsl: qe: introduce qe_io{read,write}*
> wrappers") added specific I/O accessors for qe because at that
> time ioread/iowrite functions were sub-optimal on powerpc/32
> compared to the architecture specific in_/out_ IO accessors.
> 
> But as ioread/iowrite accessors are now equivalent since
> commit 894fa235eb4c ("powerpc: inline iomap accessors"),
> use them in order to allow removal of the qe specific ones.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
>  drivers/tty/serial/ucc_uart.c | 124 +++++++++++++++++-----------------
>  1 file changed, 62 insertions(+), 62 deletions(-)

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Li April 6, 2021, 9:52 p.m. UTC | #2
On Sat, Mar 6, 2021 at 12:11 PM Christophe Leroy
<christophe.leroy@csgroup.eu> wrote:
>

> Commit 6ac9b61786cc ("soc: fsl: qe: introduce qe_io{read,write}*

> wrappers") added specific I/O accessors for qe because at that

> time ioread/iowrite functions were sub-optimal on powerpc/32

> compared to the architecture specific in_/out_ IO accessors.

>

> But as ioread/iowrite accessors are now equivalent since

> commit 894fa235eb4c ("powerpc: inline iomap accessors"),

> use them in order to allow removal of the qe specific ones.

>

> Christophe Leroy (3):

>   soc: fsl: qe: replace qe_io{read,write}* wrappers by generic

>     io{read,write}*

>   tty: serial: ucc_uart: replace qe_io{read,write}* wrappers by generic

>     io{read,write}*

>   Revert "soc: fsl: qe: introduce qe_io{read,write}* wrappers"


Series applied.  Thanks.

>

>  drivers/soc/fsl/qe/gpio.c     |  20 +++---

>  drivers/soc/fsl/qe/qe.c       |  24 +++----

>  drivers/soc/fsl/qe/qe_ic.c    |   4 +-

>  drivers/soc/fsl/qe/qe_io.c    |  36 +++++-----

>  drivers/soc/fsl/qe/ucc_fast.c |  68 +++++++++----------

>  drivers/soc/fsl/qe/ucc_slow.c |  42 ++++++------

>  drivers/tty/serial/ucc_uart.c | 124 +++++++++++++++++-----------------

>  include/soc/fsl/qe/qe.h       |  34 +++-------

>  8 files changed, 168 insertions(+), 184 deletions(-)

>

> --

> 2.25.0

>