diff mbox series

[RFC,v3] doc/mgmt-api - Return connection direction in Device Connected Event

Message ID 20210326094845.RFC.v3.1.I530e1c3e621abd34c342d657df119e12e576d8a7@changeid
State Superseded
Headers show
Series [RFC,v3] doc/mgmt-api - Return connection direction in Device Connected Event | expand

Commit Message

Yu Liu March 26, 2021, 4:49 p.m. UTC
When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
space we will set the flags to tell if the established connection is
outbound or not. This is useful for the user space to log better metrics
and error messages.

Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Alain Michaud <alainm@chromium.org>
Signed-off-by: Yu Liu <yudiliu@google.com>
---

Changes in v3:
- Reserve it in Device Found event

Changes in v2:
- Use next free bit

Changes in v1:
- Initial change

 doc/mgmt-api.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

bluez.test.bot@gmail.com March 26, 2021, 5:08 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=456343

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild: Setup ELL - PASS

##############################
Test: CheckBuild: Setup - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS

##############################
Test: CheckBuild w/external ell - PASS



---
Regards,
Linux Bluetooth
Marcel Holtmann April 2, 2021, 9:18 a.m. UTC | #2
Hi Yu,

> When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user

> space we will set the flags to tell if the established connection is

> outbound or not. This is useful for the user space to log better metrics

> and error messages.

> 

> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>

> Reviewed-by: Alain Michaud <alainm@chromium.org>

> Signed-off-by: Yu Liu <yudiliu@google.com>

> ---

> 

> Changes in v3:

> - Reserve it in Device Found event

> 

> Changes in v2:

> - Use next free bit

> 

> Changes in v1:

> - Initial change

> 

> doc/mgmt-api.txt | 2 ++

> 1 file changed, 2 insertions(+)


patch looks good and I am happy for Luiz to apply it and you send the kernel changes for it. However for userspace we don’t use Signed-off-by.

Regards

Marcel
diff mbox series

Patch

diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
index cab1fffc5..5355fedb0 100644
--- a/doc/mgmt-api.txt
+++ b/doc/mgmt-api.txt
@@ -4088,6 +4088,7 @@  Device Connected Event
 		0	Reserved (not in use)
 		1	Legacy Pairing
 		2	Reserved (not in use)
+		3	Initiated Connection
 
 
 Device Disconnected Event
@@ -4261,6 +4262,7 @@  Device Found Event
 		0	Confirm name
 		1	Legacy Pairing
 		2	Not Connectable
+		3	Reserved (not in use)
 
 	For the RSSI field a value of 127 indicates that the RSSI is
 	not available. That can happen with Bluetooth 1.1 and earlier