| Message ID | 20210330141029.20412-4-quan@os.amperecomputing.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Aspeed SSIF BMC driver | expand |
On Tue, Mar 30, 2021 at 09:10:29PM +0700, Quan Nguyen wrote: > Add device tree binding document for the Aspeed SSIF BMC driver. > > Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com> > --- > .../bindings/ipmi/aspeed-ssif-bmc.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt Same comment as you ignored on v1.
On 02/04/2021 00:09, Rob Herring wrote: > On Tue, Mar 30, 2021 at 09:10:29PM +0700, Quan Nguyen wrote: >> Add device tree binding document for the Aspeed SSIF BMC driver. >> >> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com> >> --- >> .../bindings/ipmi/aspeed-ssif-bmc.txt | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt > > Same comment as you ignored on v1. > Dear Rob, I really did not mean to do that. What happen is that there was a compilation error complaint by kernel robot test on my v1. So I tried to send my v2 to fix that issue asap. Unfortunately, your reply on my v1 arrived just right after I hit "git send-email" to send out my v2. For this comment, I'll switch to use yaml file in next version. - Quan
diff --git a/Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt new file mode 100644 index 000000000000..1616f0188db9 --- /dev/null +++ b/Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt @@ -0,0 +1,18 @@ +# Aspeed SSIF (SMBus system interface) IPMI BMC interface + +The Aspeed AST2500 are commonly used as BMCs (Baseboard Management Controllers) +and the SSIF slave interface can be used to perform in-band IPMI communication +with their host. + +Required properties: + +- compatible : should be + "aspeed,ast2500-ssif-bmc" +- reg: I2C address the registers + +Example: + + ssif-bmc@10 { + compatible = "aspeed,ast2500-ssif-bmc"; + reg = <0x10>; + };
Add device tree binding document for the Aspeed SSIF BMC driver. Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com> --- .../bindings/ipmi/aspeed-ssif-bmc.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt