diff mbox series

[net-next,v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()

Message ID 1616839638-7111-1-git-send-email-huangguobin4@huawei.com
State New
Headers show
Series [net-next,v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe() | expand

Commit Message

Huang Guobin March 27, 2021, 10:07 a.m. UTC 
From: Guobin Huang <huangguobin4@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
 drivers/net/dsa/hirschmann/hellcreek.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 29, 2021, 1:10 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 27 Mar 2021 18:07:18 +0800 you wrote:
> From: Guobin Huang <huangguobin4@huawei.com>

> 

> There is a error message within devm_ioremap_resource

> already, so remove the dev_err call to avoid redundant

> error message.

> 

> Reported-by: Hulk Robot <hulkci@huawei.com>

> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>

> 

> [...]


Here is the summary with links:
  - [net-next,v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()
    https://git.kernel.org/netdev/net-next/c/656151aaa623

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
index 918be7eb626f..4d78219da253 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.c
+++ b/drivers/net/dsa/hirschmann/hellcreek.c
@@ -1842,10 +1842,8 @@  static int hellcreek_probe(struct platform_device *pdev)
 	}
 
 	hellcreek->base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(hellcreek->base)) {
-		dev_err(dev, "No memory available!\n");
+	if (IS_ERR(hellcreek->base))
 		return PTR_ERR(hellcreek->base);
-	}
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ptp");
 	if (!res) {
@@ -1854,10 +1852,8 @@  static int hellcreek_probe(struct platform_device *pdev)
 	}
 
 	hellcreek->ptp_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(hellcreek->ptp_base)) {
-		dev_err(dev, "No memory available!\n");
+	if (IS_ERR(hellcreek->ptp_base))
 		return PTR_ERR(hellcreek->ptp_base);
-	}
 
 	ret = hellcreek_detect(hellcreek);
 	if (ret) {