Message ID | 20210317134904.80737-1-sebastian.reichel@collabora.com |
---|---|
Headers | show |
Series | Convert power-supply DT bindings to YAML | expand |
* Sebastian Reichel <sebastian.reichel@collabora.com> [210317 13:50]: > Convert the binding to DT schema format. I also added the missing bits > used by the only in-tree user and implemented in the driver. Reviewed-by: Tony Lindgren <tony@atomide.com>
On Wed, Mar 17, 2021 at 7:49 AM Sebastian Reichel <sebastian.reichel@collabora.com> wrote: > > Hi, > > I keep getting patches for existing drivers, that modify DT behaviour > without updating the binding file. Let's move everything to DT schema > files, so that this can easily be cached automatically by dtbs_check. > > After this series only three bindings are left unconverted: > > 1. max8925_battery.txt > This describes a node below the PMIC, which does not have its own > compatible value. It needs to be described in the PMIC binding > file, which has not yet been converted. > > 2. stericsson,ab8500-battery.txt > This also describes a node below the PMIC, which does not have > its own compatible value. The same applies. > > 3. charger-manager.txt > This is far more complex to convert than the other files, due > to the 'cm-regulator-name' / "<>-supply" thing. I skipped it > for now. > > I tested the series using dt-validate 2021.3.dev6+g38efe3f and nothing > is reported when running dtbs_check like this: > > make -s -j100 dtbs_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/power/supply/*.yaml" > > Also nothing is reported when checking the power-supply binding files > like this: > > for file in Documentation/devicetree/bindings/power/supply/*yaml ; do > make -s -j42 dt_binding_check DT_SCHEMA_FILES=$file ; > done > > This is also available as 'psy-yaml-binding' branch from my repository: > > https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git > > Changes since PATCHv1: > [1] https://lore.kernel.org/linux-devicetree/20210312154357.1561730-1-sebastian.reichel@collabora.com/ > * Drop #gpio-cells/gpio-controller dependency (inherited from standard binding) > * Drop $ref for properties with standard suffix > * ti,bq24735: Add $ref property for poll-interval > * ti,lp8727: Combine usb and ac property information using patternProperties > > Thanks for reviewing it, > > -- Sebastian > > Sebastian Reichel (38): > ARM: dts: motorola-cpcap-mapphone: Prepare for dtbs_check parsing > dt-bindings: power: supply: cpcap-battery: Convert to DT schema format > dt-bindings: power: supply: cpcap-charger: Convert to DT schema format > dt-bindings: power: supply: bq25890: Convert to DT schema format > dt-bindings: power: supply: bq24257: Convert to DT schema format > dt-bindings: power: supply: bq24190: Convert to DT schema format > dt-bindings: power: supply: bq2415x: Convert to DT schema format > dt-bindings: power: supply: bq24735: Convert to DT schema format > dt-bindings: power: supply: isp1704: Convert to DT schema format > dt-bindings: power: supply: sbs-charger: Convert to DT schema format > dt-bindings: power: supply: sbs-manager: Convert to DT schema format > dt-bindings: power: supply: ds2760: Convert to DT schema format > dt-bindings: power: supply: sc27xx-fg: Convert to DT schema format > dt-bindings: power: supply: sc2731-charger: Convert to DT schema > format > dt-bindings: power: supply: tps65090: Convert to DT schema format > dt-bindings: power: supply: tps65217: Convert to DT schema format > dt-bindings: power: supply: twl4030: Convert to DT schema format > dt-bindings: power: supply: n900-battery: Convert to DT schema format > dt-bindings: power: supply: lego-ev3-battery: Convert to DT schema > format > dt-bindings: power: supply: max17040: Convert to DT schema format > dt-bindings: power: supply: max14656: Convert to DT schema format > dt-bindings: power: supply: max17042: Convert to DT schema format > dt-bindings: power: supply: max8903: Convert to DT schema format > dt-bindings: power: supply: ucs1002: Convert to DT schema format > dt-bindings: power: supply: pm8941-charger: Convert to DT schema > format > dt-bindings: power: supply: pm8941-coincell: Convert to DT schema > format > dt-bindings: power: supply: act8945a: Convert to DT schema format > dt-bindings: power: supply: axp20x: Convert to DT schema format > dt-bindings: power: supply: da9150: Convert to DT schema format > dt-bindings: power: supply: lp8727: Convert to DT schema format > dt-bindings: power: supply: lt3651: Convert to DT schema format > dt-bindings: power: supply: ltc294x: Convert to DT schema format > dt-bindings: power: supply: rt9455: Convert to DT schema format > dt-bindings: power: supply: olpc-battery: Convert to DT schema format > dt-bindings: power: supply: ab8500: Convert to DT schema format > dt-bindings: power: supply: sbs-battery: Fix dtbs_check > dt-bindings: power: supply: Fix remaining battery.txt links > dt-bindings: power: supply: Drop power_supply.txt Thanks! For the series: Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, Mar 22, 2021 at 3:43 PM Sebastian Reichel <sebastian.reichel@collabora.com> wrote: > > Hi, > > On Mon, Mar 22, 2021 at 10:25:49AM -0600, Rob Herring wrote: > > On Wed, Mar 17, 2021 at 7:49 AM Sebastian Reichel wrote: > > > Sebastian Reichel (38): > > > ARM: dts: motorola-cpcap-mapphone: Prepare for dtbs_check parsing > > > dt-bindings: power: supply: cpcap-battery: Convert to DT schema format > > > dt-bindings: power: supply: cpcap-charger: Convert to DT schema format > > > [...] > > > > Thanks! For the series: > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > How should we proceed with the DTS patch? > > a) Tony takes DT through his tree, I take all YAML files through my tree. > The verification might be broken for some time when being merged > in wrong order. Looks like there are already quite a few warnings > for in-tree DTS files, so it might be ok to have some more > temporarily? It's obviously the most simple solution. This is fine. We're not anywhere close to warning free. > > b) Tony takes DTS and the cpcap related patches through his tree; > I take the other ones. > > c) I take the full series through my tree. > > d) I can merge the DT through an immutable branch and provide a PR. > > I'm fine with either way. > > -- Sebastian
Hi Tony, On Wed, Mar 17, 2021 at 04:29:19PM +0200, Tony Lindgren wrote: > * Sebastian Reichel <sebastian.reichel@collabora.com> [210317 13:50]: > > '<&gpio1 parameters &gpio2 parameters>' and '<&gpio1 parameters>, > > <&gpio2 parameters>' result in the same DTB, but second format has > > better source code readability. Also 'dtbs_check' currently uses > > this format to determine the amount of items specified, so using > > this syntax is needed to successfully verify the devicetree source > > against a DT schema format. > > Looks good to me: > > Acked-by: Tony Lindgren <tony@atomide.com> Please take this patch via your tree. I will take the other ones through the power-supply tree. Thanks, -- Sebastian
* Sebastian Reichel <sebastian.reichel@collabora.com> [210323 12:52]: > Hi Tony, > > On Wed, Mar 17, 2021 at 04:29:19PM +0200, Tony Lindgren wrote: > > * Sebastian Reichel <sebastian.reichel@collabora.com> [210317 13:50]: > > > '<&gpio1 parameters &gpio2 parameters>' and '<&gpio1 parameters>, > > > <&gpio2 parameters>' result in the same DTB, but second format has > > > better source code readability. Also 'dtbs_check' currently uses > > > this format to determine the amount of items specified, so using > > > this syntax is needed to successfully verify the devicetree source > > > against a DT schema format. > > > > Looks good to me: > > > > Acked-by: Tony Lindgren <tony@atomide.com> > > Please take this patch via your tree. I will take the other ones > through the power-supply tree. OK will do. Thanks, Tony
On 3/17/21 8:48 AM, Sebastian Reichel wrote: > Convert the binding to DT schema format. > > Cc: David Lechner <david@lechnology.com> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- Reviewed-by: David Lechner <david@lechnology.com>