mbox series

[v2,0/2] AM64: Add support for GPIO

Message ID 20210304112924.12470-1-a-govindraju@ti.com
Headers show
Series AM64: Add support for GPIO | expand

Message

Aswath Govindraju March 4, 2021, 11:29 a.m. UTC
The following series of patches adds support for gpio on AM642 evm/sk.

Changes since v1:
- Added DT for gpio subsystem present in MCU domain
- reserved the mcu gpio for firmware usage

This series of patches depend on,
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439039
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439153


Aswath Govindraju (2):
  arm64: dts: ti: k3-am64: Add GPIO DT nodes
  arm64: dts: ti: k3-am642: reserve gpio in mcu domain for firmware
    usage

 arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 45 ++++++++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi  | 27 ++++++++++++++
 arch/arm64/boot/dts/ti/k3-am642-evm.dts  |  5 +++
 arch/arm64/boot/dts/ti/k3-am642-sk.dts   |  5 +++
 4 files changed, 82 insertions(+)

Comments

Nishanth Menon March 9, 2021, 2:43 p.m. UTC | #1
On 16:59-20210304, Aswath Govindraju wrote:
> The following series of patches adds support for gpio on AM642 evm/sk.

> 

> Changes since v1:

> - Added DT for gpio subsystem present in MCU domain

> - reserved the mcu gpio for firmware usage

> 

> This series of patches depend on,

> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439039

> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439153

> 

> 

> Aswath Govindraju (2):

>   arm64: dts: ti: k3-am64: Add GPIO DT nodes

>   arm64: dts: ti: k3-am642: reserve gpio in mcu domain for firmware

>     usage

> 

>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 45 ++++++++++++++++++++++++

>  arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi  | 27 ++++++++++++++

>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  |  5 +++

>  arch/arm64/boot/dts/ti/k3-am642-sk.dts   |  5 +++

>  4 files changed, 82 insertions(+)

> 

> -- 

> 2.17.1

> 



Based on your offline comment:
-----

On going through the bootlogs before posting for I found the following
errors,

[    1.091117] davinci_gpio 601000.gpio: IRQ index 2 not found
[    1.101522] davinci_gpio 601000.gpio: error -ENXIO: IRQ not populated

Some issues in allocating interrupts in case of main_gpio1. I
accumulated the gpio with interrupt numbers. I'll try to debug the
reason behind it and update you with its status. (bootlogs of ti-sdk,
also have this error).

-----

I am going to drop this off my queue, please update if the fixup is some
system configuration error or repost with fix.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Aswath Govindraju March 9, 2021, 3:50 p.m. UTC | #2
Hi Nishanth,

On 09/03/21 8:13 pm, Nishanth Menon wrote:
> On 16:59-20210304, Aswath Govindraju wrote:

>> The following series of patches adds support for gpio on AM642 evm/sk.

>>

>> Changes since v1:

>> - Added DT for gpio subsystem present in MCU domain

>> - reserved the mcu gpio for firmware usage

>>

>> This series of patches depend on,

>> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439039

>> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439153

>>

>>

>> Aswath Govindraju (2):

>>   arm64: dts: ti: k3-am64: Add GPIO DT nodes

>>   arm64: dts: ti: k3-am642: reserve gpio in mcu domain for firmware

>>     usage

>>

>>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 45 ++++++++++++++++++++++++

>>  arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi  | 27 ++++++++++++++

>>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  |  5 +++

>>  arch/arm64/boot/dts/ti/k3-am642-sk.dts   |  5 +++

>>  4 files changed, 82 insertions(+)

>>

>> -- 

>> 2.17.1

>>

> 

> 

> Based on your offline comment:

> -----

> 

> On going through the bootlogs before posting for I found the following

> errors,

> 

> [    1.091117] davinci_gpio 601000.gpio: IRQ index 2 not found

> [    1.101522] davinci_gpio 601000.gpio: error -ENXIO: IRQ not populated

> 

> Some issues in allocating interrupts in case of main_gpio1. I

> accumulated the gpio with interrupt numbers. I'll try to debug the

> reason behind it and update you with its status. (bootlogs of ti-sdk,

> also have this error).

> 

> -----

> 

> I am going to drop this off my queue, please update if the fixup is some

> system configuration error or repost with fix.

> 


This is expected to be a fixup in the system configuration and not a bug
in the patch series. So, can you please have these patches in your queue
? I'll soon post the test results indicating the functioning of GPIOs.

Thanks,
Aswath
Nishanth Menon March 9, 2021, 3:58 p.m. UTC | #3
On 21:20-20210309, Aswath Govindraju wrote:
> Hi Nishanth,

> 

> On 09/03/21 8:13 pm, Nishanth Menon wrote:

> > On 16:59-20210304, Aswath Govindraju wrote:

> >> The following series of patches adds support for gpio on AM642 evm/sk.

> >>

> >> Changes since v1:

> >> - Added DT for gpio subsystem present in MCU domain

> >> - reserved the mcu gpio for firmware usage

> >>

> >> This series of patches depend on,

> >> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439039

> >> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439153

> >>

> >>

> >> Aswath Govindraju (2):

> >>   arm64: dts: ti: k3-am64: Add GPIO DT nodes

> >>   arm64: dts: ti: k3-am642: reserve gpio in mcu domain for firmware

> >>     usage

> >>

> >>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 45 ++++++++++++++++++++++++

> >>  arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi  | 27 ++++++++++++++

> >>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  |  5 +++

> >>  arch/arm64/boot/dts/ti/k3-am642-sk.dts   |  5 +++

> >>  4 files changed, 82 insertions(+)

> >>

> >> -- 

> >> 2.17.1

> >>

> > 

> > 

> > Based on your offline comment:

> > -----

> > 

> > On going through the bootlogs before posting for I found the following

> > errors,

> > 

> > [    1.091117] davinci_gpio 601000.gpio: IRQ index 2 not found

> > [    1.101522] davinci_gpio 601000.gpio: error -ENXIO: IRQ not populated

> > 

> > Some issues in allocating interrupts in case of main_gpio1. I

> > accumulated the gpio with interrupt numbers. I'll try to debug the

> > reason behind it and update you with its status. (bootlogs of ti-sdk,

> > also have this error).

> > 

> > -----

> > 

> > I am going to drop this off my queue, please update if the fixup is some

> > system configuration error or repost with fix.

> > 

> 

> This is expected to be a fixup in the system configuration and not a bug

> in the patch series. So, can you please have these patches in your queue

> ? I'll soon post the test results indicating the functioning of GPIOs.



Thanks for clarifying. I will wait till the test results are posted.
Thanks in advance for digging into this and detailed testing.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Aswath Govindraju March 19, 2021, 5:22 a.m. UTC | #4
Hi Nishanth,

On 09/03/21 9:28 pm, Nishanth Menon wrote:
> On 21:20-20210309, Aswath Govindraju wrote:

>> Hi Nishanth,

>>

>> On 09/03/21 8:13 pm, Nishanth Menon wrote:

>>> On 16:59-20210304, Aswath Govindraju wrote:

>>>> The following series of patches adds support for gpio on AM642 evm/sk.

>>>>

>>>> Changes since v1:

>>>> - Added DT for gpio subsystem present in MCU domain

>>>> - reserved the mcu gpio for firmware usage

>>>>

>>>> This series of patches depend on,

>>>> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439039

>>>> https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=439153

>>>>

>>>>

>>>> Aswath Govindraju (2):

>>>>   arm64: dts: ti: k3-am64: Add GPIO DT nodes

>>>>   arm64: dts: ti: k3-am642: reserve gpio in mcu domain for firmware

>>>>     usage

>>>>

>>>>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 45 ++++++++++++++++++++++++

>>>>  arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi  | 27 ++++++++++++++

>>>>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  |  5 +++

>>>>  arch/arm64/boot/dts/ti/k3-am642-sk.dts   |  5 +++

>>>>  4 files changed, 82 insertions(+)

>>>>

>>>> -- 

>>>> 2.17.1

>>>>

>>>

>>>

>>> Based on your offline comment:

>>> -----

>>>

>>> On going through the bootlogs before posting for I found the following

>>> errors,

>>>

>>> [    1.091117] davinci_gpio 601000.gpio: IRQ index 2 not found

>>> [    1.101522] davinci_gpio 601000.gpio: error -ENXIO: IRQ not populated

>>>

>>> Some issues in allocating interrupts in case of main_gpio1. I

>>> accumulated the gpio with interrupt numbers. I'll try to debug the

>>> reason behind it and update you with its status. (bootlogs of ti-sdk,

>>> also have this error).

>>>

>>> -----

>>>

>>> I am going to drop this off my queue, please update if the fixup is some

>>> system configuration error or repost with fix.

>>>

>>

>> This is expected to be a fixup in the system configuration and not a bug

>> in the patch series. So, can you please have these patches in your queue

>> ? I'll soon post the test results indicating the functioning of GPIOs.

> 

> 

> Thanks for clarifying. I will wait till the test results are posted.

> Thanks in advance for digging into this and detailed testing.

> 


I've posted a respin(v3) of this series after rebasing on top of
ti-k3-dts-next branch and adding the GPIO test logs.

Thanks,
Aswath