| Message ID | 20210312002605.3273255-1-bjorn.andersson@linaro.org |
|---|---|
| State | Accepted |
| Commit | 9af2a2a9c64ee68a5dc8271d54235609191f1cd1 |
| Headers | show |
| Series | remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing | expand |
On Thu, Mar 11, 2021 at 04:26:05PM -0800, Bjorn Andersson wrote: > Failing to read the "firmware-name" DT property without informing the > developer is annoying, add some helpful debug prints. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/remoteproc/qcom_q6v5_mss.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c > index 66106ba25ba3..15abfbba78d2 100644 > --- a/drivers/remoteproc/qcom_q6v5_mss.c > +++ b/drivers/remoteproc/qcom_q6v5_mss.c > @@ -1661,8 +1661,10 @@ static int q6v5_probe(struct platform_device *pdev) > mba_image = desc->hexagon_mba_image; > ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name", > 0, &mba_image); > - if (ret < 0 && ret != -EINVAL) > + if (ret < 0 && ret != -EINVAL) { > + dev_err(&pdev->dev, "unable to read mba firmware-name\n"); > return ret; > + } > > rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_ops, > mba_image, sizeof(*qproc)); > @@ -1680,8 +1682,10 @@ static int q6v5_probe(struct platform_device *pdev) > qproc->hexagon_mdt_image = "modem.mdt"; > ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name", > 1, &qproc->hexagon_mdt_image); > - if (ret < 0 && ret != -EINVAL) > + if (ret < 0 && ret != -EINVAL) { > + dev_err(&pdev->dev, "unable to read mpss firmware-name\n"); > goto free_rproc; > + } Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > platform_set_drvdata(pdev, qproc); > > -- > 2.29.2 >
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Thu, 11 Mar 2021 16:26:05 -0800 you wrote: > Failing to read the "firmware-name" DT property without informing the > developer is annoying, add some helpful debug prints. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/remoteproc/qcom_q6v5_mss.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Here is the summary with links: - remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing https://git.kernel.org/qcom/c/9af2a2a9c64e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c index 66106ba25ba3..15abfbba78d2 100644 --- a/drivers/remoteproc/qcom_q6v5_mss.c +++ b/drivers/remoteproc/qcom_q6v5_mss.c @@ -1661,8 +1661,10 @@ static int q6v5_probe(struct platform_device *pdev) mba_image = desc->hexagon_mba_image; ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name", 0, &mba_image); - if (ret < 0 && ret != -EINVAL) + if (ret < 0 && ret != -EINVAL) { + dev_err(&pdev->dev, "unable to read mba firmware-name\n"); return ret; + } rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_ops, mba_image, sizeof(*qproc)); @@ -1680,8 +1682,10 @@ static int q6v5_probe(struct platform_device *pdev) qproc->hexagon_mdt_image = "modem.mdt"; ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name", 1, &qproc->hexagon_mdt_image); - if (ret < 0 && ret != -EINVAL) + if (ret < 0 && ret != -EINVAL) { + dev_err(&pdev->dev, "unable to read mpss firmware-name\n"); goto free_rproc; + } platform_set_drvdata(pdev, qproc);
Failing to read the "firmware-name" DT property without informing the developer is annoying, add some helpful debug prints. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- drivers/remoteproc/qcom_q6v5_mss.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.29.2