| Message ID | 20210311172255.25213-1-digetx@gmail.com |
|---|---|
| Headers | show |
| Series | Add memory bandwidth management to NVIDIA Tegra DRM driver | expand |
On Thu, Mar 11, 2021 at 08:22:55PM +0300, Dmitry Osipenko wrote: > It's useful to know the total number of underflow events and currently > the debug stats are getting reset each time CRTC is being disabled. Let's > account the overall number of events that doesn't get a reset. [...] Looks good. It seems independent from the other patch. Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
15.03.2021 01:11, Michał Mirosław пишет: > On Thu, Mar 11, 2021 at 08:22:55PM +0300, Dmitry Osipenko wrote: >> It's useful to know the total number of underflow events and currently >> the debug stats are getting reset each time CRTC is being disabled. Let's >> account the overall number of events that doesn't get a reset. > [...] > > Looks good. It seems independent from the other patch. > > Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > This patch was created in order to help with debugging of the bandwidth management, but technically it's independent. Thank you for the review.
This series adds memory bandwidth management to the NVIDIA Tegra DRM driver, which is done using interconnect framework. It fixes display corruption that happens due to insufficient memory bandwidth. Changelog: v15: - Corrected tegra_plane_icc_names[] NULL-check that was partially lost by accident in v14 after unsuccessful rebase. v14: - Made improvements that were suggested by Michał Mirosław to v13: - Changed 'unsigned int' to 'bool'. - Renamed functions which calculate bandwidth state. - Reworked comment in the code that explains why downscaled plane require higher bandwidth. - Added round-up to bandwidth calculation. - Added sanity checks of the plane index and fixed out-of-bounds access which happened on T124 due to the cursor plane index. v13: - No code changes. Patches missed v5.12, re-sending them for v5.13. Dmitry Osipenko (2): drm/tegra: dc: Support memory bandwidth management drm/tegra: dc: Extend debug stats with total number of events drivers/gpu/drm/tegra/Kconfig | 1 + drivers/gpu/drm/tegra/dc.c | 362 ++++++++++++++++++++++++++++++++++ drivers/gpu/drm/tegra/dc.h | 19 ++ drivers/gpu/drm/tegra/drm.c | 14 ++ drivers/gpu/drm/tegra/hub.c | 3 + drivers/gpu/drm/tegra/plane.c | 127 ++++++++++++ drivers/gpu/drm/tegra/plane.h | 15 ++ 7 files changed, 541 insertions(+)