[net-next,v2,0/4] net: dsa: hellcreek: Add support for dumping tables

Hi,

add support for dumping the VLAN and FDB table via devlink. As the driver uses
internal VLANs and static FDB entries, this is a useful debugging feature.

Changes since v1:

 * Drop memory reporting as there are better APIs to expose this
 * Move comment to VLAN patch

Previous versions:

 * https://lkml.kernel.org/netdev/20210311175344.3084-1-kurt@kmk-computers.de/

Thanks,
Kurt

Kurt Kanzenbach (4):
  net: dsa: hellcreek: Add devlink VLAN region
  net: dsa: hellcreek: Use boolean value
  net: dsa: hellcreek: Move common code to helper
  net: dsa: hellcreek: Add devlink FDB region

 drivers/net/dsa/hirschmann/hellcreek.c | 223 ++++++++++++++++++++-----
 drivers/net/dsa/hirschmann/hellcreek.h |   7 +
 2 files changed, 187 insertions(+), 43 deletions(-)

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Sat, 13 Mar 2021 10:39:35 +0100 you wrote:
> Hi,
> 
> add support for dumping the VLAN and FDB table via devlink. As the driver uses
> internal VLANs and static FDB entries, this is a useful debugging feature.
> 
> Changes since v1:
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/4] net: dsa: hellcreek: Add devlink VLAN region
    https://git.kernel.org/netdev/net-next/c/ba2d1c28886c
  - [net-next,v2,2/4] net: dsa: hellcreek: Use boolean value
    https://git.kernel.org/netdev/net-next/c/e81813fb5635
  - [net-next,v2,3/4] net: dsa: hellcreek: Move common code to helper
    https://git.kernel.org/netdev/net-next/c/eb5f3d314180
  - [net-next,v2,4/4] net: dsa: hellcreek: Add devlink FDB region
    https://git.kernel.org/netdev/net-next/c/292cd449fee3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

On 3/13/2021 1:39 AM, Kurt Kanzenbach wrote:
> Allow to dump the VLAN table via devlink. This especially useful, because the

> driver internally leverages VLANs for the port separation. These are not visible

> via the bridge utility.

> 

> Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>


Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

-- 
Florian

On 3/13/2021 1:39 AM, Kurt Kanzenbach wrote:
> Allow to dump the FDB table via devlink. This is a useful debugging feature.

> 

> Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>

> Reviewed-by: Andrew Lunn <andrew@lunn.ch>


Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

-- 
Florian

On Sat Mar 13 2021, Vladimir Oltean wrote:
> On Sat, Mar 13, 2021 at 10:39:39AM +0100, Kurt Kanzenbach wrote:

>> Allow to dump the FDB table via devlink. This is a useful debugging feature.

>> 

>> Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>

>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

>> ---

>

> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

>

> By the way, what user space program do you use to dump these? Did you

> derive something from Andrew's mv88e6xxx_dump too? Maybe we should work

> on something common?


Actually there is no user space tooling, yet. My original approach to
debugging was different using debugfs and tracing. I played a bit with
mv88e6xxx_dump today. Having a common tool would be quite nice.

Thanks,
Kurt

On Sun Mar 14 2021, Kurt Kanzenbach wrote:
> On Sat Mar 13 2021, Vladimir Oltean wrote:

>> On Sat, Mar 13, 2021 at 10:39:39AM +0100, Kurt Kanzenbach wrote:

>>> Allow to dump the FDB table via devlink. This is a useful debugging feature.

>>> 

>>> Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>

>>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

>>> ---

>>

>> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

>>

>> By the way, what user space program do you use to dump these? Did you

>> derive something from Andrew's mv88e6xxx_dump too? Maybe we should work

>> on something common?

>

> Actually there is no user space tooling, yet. My original approach to

> debugging was different using debugfs and tracing. I played a bit with

> mv88e6xxx_dump today. Having a common tool would be quite nice.


Thanks for the pointer to mv88e6xxx_dump. Just needed to implement
.devlink_info_get() callback, so that the tool can distinguish between
the Marvell and Hellcreek devices (and implement some hellcreek
specifics).

Thanks,
Kurt