| Message ID | 279c20fa-6e5e-4f88-9cd1-f76297a28a19@web.de |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry | expand |
On 2/20/2021 6:49 AM, Jan Kiszka wrote: > From: Jan Kiszka <jan.kiszka@siemens.com> > > Add the DT entry for a watchdog based on RTI1. > > On SR1.0 silicon, it requires additional firmware on the MCU R5F cores > to handle the expiry, e.g. https://github.com/siemens/k3-rti-wdt. As > this firmware will also lock the power domain to protect it against > premature shutdown, mark it shared. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Acked-by: Praneeth Bajjuri <praneeth@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > index 7454c8cec0cc..903796bf7d64 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > @@ -308,4 +308,13 @@ mcu_r5fss0_core1: r5f@41400000 { > ti,loczrama = <1>; > }; > }; > + > + mcu_rti1: rti@40610000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x0 0x40610000 0x0 0x100>; > + clocks = <&k3_clks 135 0>; > + power-domains = <&k3_pds 135 TI_SCI_PD_SHARED>; > + assigned-clocks = <&k3_clks 135 0>; > + assigned-clock-parents = <&k3_clks 135 4>; > + }; > }; > -- > 2.26.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On 19:36-20210310, Bajjuri, Praneeth wrote: > > > On 2/20/2021 6:49 AM, Jan Kiszka wrote: > > From: Jan Kiszka <jan.kiszka@siemens.com> > > > > Add the DT entry for a watchdog based on RTI1. > > > > On SR1.0 silicon, it requires additional firmware on the MCU R5F cores > > to handle the expiry, e.g. https://github.com/siemens/k3-rti-wdt. As > > this firmware will also lock the power domain to protect it against > > premature shutdown, mark it shared. > > > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > > Acked-by: Praneeth Bajjuri <praneeth@ti.com> > > > --- > > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > > index 7454c8cec0cc..903796bf7d64 100644 > > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > > @@ -308,4 +308,13 @@ mcu_r5fss0_core1: r5f@41400000 { > > ti,loczrama = <1>; > > }; > > }; > > + > > + mcu_rti1: rti@40610000 { Jan, I was about to pick up the patches and was running through my sanity checks and the following caught my eye with dtbs_check (dtschema is at 2021.2.1) test against next-20210311 /workdir/arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: rti@40610000: $nodename:0: 'rti@40610000' does not match '^watchdog(@.*|-[0-9a-f])?$' Please use watchdog@40610000 instead of rti@40610000 Since this is a minor change, I have done this change locally. let me know if you have an issue and I can drop it off my branch for a new version. [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
On 11.03.21 13:56, Nishanth Menon wrote: > On 19:36-20210310, Bajjuri, Praneeth wrote: >> >> >> On 2/20/2021 6:49 AM, Jan Kiszka wrote: >>> From: Jan Kiszka <jan.kiszka@siemens.com> >>> >>> Add the DT entry for a watchdog based on RTI1. >>> >>> On SR1.0 silicon, it requires additional firmware on the MCU R5F cores >>> to handle the expiry, e.g. https://github.com/siemens/k3-rti-wdt. As >>> this firmware will also lock the power domain to protect it against >>> premature shutdown, mark it shared. >>> >>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> >> >> Acked-by: Praneeth Bajjuri <praneeth@ti.com> >> >>> --- >>> arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> index 7454c8cec0cc..903796bf7d64 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> @@ -308,4 +308,13 @@ mcu_r5fss0_core1: r5f@41400000 { >>> ti,loczrama = <1>; >>> }; >>> }; >>> + >>> + mcu_rti1: rti@40610000 { > > Jan, I was about to pick up the patches and was running through > my sanity checks and the following caught my eye with dtbs_check > (dtschema is at 2021.2.1) test against next-20210311 > > /workdir/arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: rti@40610000: $nodename:0: 'rti@40610000' does not match '^watchdog(@.*|-[0-9a-f])?$' > > Please use watchdog@40610000 instead of rti@40610000 > > Since this is a minor change, I have done this change locally. let me > know if you have an issue and I can drop it off my branch for a new > version. > That's fine, thanks for fixing up - still learning such details. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux
On Sat, 20 Feb 2021 13:49:51 +0100, Jan Kiszka wrote: > Add the DT entry for a watchdog based on RTI1. > > On SR1.0 silicon, it requires additional firmware on the MCU R5F cores > to handle the expiry, e.g. https://github.com/siemens/k3-rti-wdt. As > this firmware will also lock the power domain to protect it against > premature shutdown, mark it shared. Hi Jan Kiszka, I have applied the following to branch ti-k3-dts-next on [1]. Thank you! [1/1] arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry commit: 6674a90bb141496f56ce840c22f2f2ddccc5d397 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi index 7454c8cec0cc..903796bf7d64 100644 --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi @@ -308,4 +308,13 @@ mcu_r5fss0_core1: r5f@41400000 { ti,loczrama = <1>; }; }; + + mcu_rti1: rti@40610000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x0 0x40610000 0x0 0x100>; + clocks = <&k3_clks 135 0>; + power-domains = <&k3_pds 135 TI_SCI_PD_SHARED>; + assigned-clocks = <&k3_clks 135 0>; + assigned-clock-parents = <&k3_clks 135 4>; + }; };