| Message ID | 20210307204737.12063-1-horia.geanta@nxp.com |
|---|---|
| Headers | show |
| Series | arm64: dts: ls: mark crypto engine dma coherent | expand |
On Mon, Mar 8, 2021 at 2:26 AM Horia Geantă <horia.geanta@nxp.com> wrote: > > This patch set adds "dma-coherent" property to the crypto node > for NXP Layerscape platforms where the IP (CAAM) is configured > HW-coherent. > > Horia Geantă (3): > arm64: dts: ls1046a: mark crypto engine dma coherent > arm64: dts: ls1043a: mark crypto engine dma coherent > arm64: dts: ls1012a: mark crypto engine dma coherent For the series Acked-by: Li Yang <leoyang.li@nxp.com> > > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 + > 3 files changed, 3 insertions(+) > > > base-commit: da1a6b8bec881b67f0e234ed19e8b7e2fb1e7812 > -- > 2.17.1 >
On 8/3/21 6:47 am, Horia Geantă wrote: > Crypto engine (CAAM) on LS1046A platform is configured HW-coherent, > mark accordingly the DT node. > > As reported by Greg and Sascha, and explained by Robin, lack of > "dma-coherent" property for an IP that is configured HW-coherent > can lead to problems, e.g. on v5.11: > >> kernel BUG at drivers/crypto/caam/jr.c:247! >> Internal error: Oops - BUG: 0 [#1] PREEMPT SMP >> Modules linked in: >> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.11.0-20210225-3-00039-g434215968816-dirty #12 >> Hardware name: TQ TQMLS1046A SoM on Arkona AT1130 (C300) board (DT) >> pstate: 60000005 (nZCv daif -PAN -UAO -TCO BTYPE=--) >> pc : caam_jr_dequeue+0x98/0x57c >> lr : caam_jr_dequeue+0x98/0x57c >> sp : ffff800010003d50 >> x29: ffff800010003d50 x28: ffff8000118d4000 >> x27: ffff8000118d4328 x26: 00000000000001f0 >> x25: ffff0008022be480 x24: ffff0008022c6410 >> x23: 00000000000001f1 x22: ffff8000118d4329 >> x21: 0000000000004d80 x20: 00000000000001f1 >> x19: 0000000000000001 x18: 0000000000000020 >> x17: 0000000000000000 x16: 0000000000000015 >> x15: ffff800011690230 x14: 2e2e2e2e2e2e2e2e >> x13: 2e2e2e2e2e2e2020 x12: 3030303030303030 >> x11: ffff800011700a38 x10: 00000000fffff000 >> x9 : ffff8000100ada30 x8 : ffff8000116a8a38 >> x7 : 0000000000000001 x6 : 0000000000000000 >> x5 : 0000000000000000 x4 : 0000000000000000 >> x3 : 00000000ffffffff x2 : 0000000000000000 >> x1 : 0000000000000000 x0 : 0000000000001800 >> Call trace: >> caam_jr_dequeue+0x98/0x57c >> tasklet_action_common.constprop.0+0x164/0x18c >> tasklet_action+0x44/0x54 >> __do_softirq+0x160/0x454 >> __irq_exit_rcu+0x164/0x16c >> irq_exit+0x1c/0x30 >> __handle_domain_irq+0xc0/0x13c >> gic_handle_irq+0x5c/0xf0 >> el1_irq+0xb4/0x180 >> arch_cpu_idle+0x18/0x30 >> default_idle_call+0x3c/0x1c0 >> do_idle+0x23c/0x274 >> cpu_startup_entry+0x34/0x70 >> rest_init+0xdc/0xec >> arch_call_rest_init+0x1c/0x28 >> start_kernel+0x4ac/0x4e4 >> Code: 91392021 912c2000 d377d8c6 97f24d96 (d4210000) > > Cc: <stable@vger.kernel.org> # v4.10+ > Fixes: 8126d88162a5 ("arm64: dts: add QorIQ LS1046A SoC support") > Link: https://lore.kernel.org/linux-crypto/fe6faa24-d8f7-d18f-adfa-44fa0caa1598@arm.com > Reported-by: Greg Ungerer <gerg@kernel.org> > Reported-by: Sascha Hauer <s.hauer@pengutronix.de> > Tested-by: Sascha Hauer <s.hauer@pengutronix.de> > Signed-off-by: Horia Geantă <horia.geanta@nxp.com> Acked-by: Greg Ungerer <gerg@kernel.org> > --- > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > index f581a6d1f881..37fec474673a 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > @@ -354,6 +354,7 @@ > ranges = <0x0 0x00 0x1700000 0x100000>; > reg = <0x00 0x1700000 0x0 0x100000>; > interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>; > + dma-coherent; > > sec_jr0: jr@10000 { > compatible = "fsl,sec-v5.4-job-ring", >
On Sun, Mar 07, 2021 at 10:47:34PM +0200, Horia Geantă wrote: > This patch set adds "dma-coherent" property to the crypto node > for NXP Layerscape platforms where the IP (CAAM) is configured > HW-coherent. > > Horia Geantă (3): > arm64: dts: ls1046a: mark crypto engine dma coherent > arm64: dts: ls1043a: mark crypto engine dma coherent > arm64: dts: ls1012a: mark crypto engine dma coherent Applied all, thanks.