Message ID | 20210308194535.66394-1-andriy.shevchenko@linux.intel.com |
---|---|
Headers | show |
Series | gpiolib: switch to fwnode in the core | expand |
On Mon, Mar 08, 2021 at 08:47:47PM +0100, Rafael J. Wysocki wrote: > On Mon, Mar 8, 2021 at 8:45 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > It's quite spread code to initialize IRQ domain options. > > Let's fold it into a simple oneliner. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Please see the comments I've just sent: > > https://lore.kernel.org/linux-acpi/CAJZ5v0gpNzyBDKfBXoBYskUXs15GrZAe-E2vzhSEu2Nrj7wa7g@mail.gmail.com/T/#u Yeah, I answered there, thanks!
On Mon, Mar 8, 2021 at 8:45 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > When IRQ domain is created for an ACPI case, the name of it becomes unknown-%d > since for now it utilizes of_node member only and doesn't consider fwnode case. > Convert IRQ domain creation code to utilize fwnode instead. > > Before/After the change on Intel Galileo Gen 2 with two GPIO (IRQ) controllers: > > unknown-1 ==> \_SB.PCI0.GIP0.GPO > unknown-2 ==> \_SB.NIO3 > > Due to the nature of this change we may also deduplicate the WARN():s > because in either case (DT or ACPI) the fwnode will be set correctly > and %pfw is an equivalent to what the current code prints as a prefix. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij