| Message ID | 20210304034141.7062-5-brad@pensando.io |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Support Pensando Elba SoC | expand |
On Thu, Mar 4, 2021 at 4:41 AM Brad Larson <brad@pensando.io> wrote: > > Pensando Elba SoC platforms have a SPI connected CPLD > for platform management. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > drivers/spi/spidev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c > index 8cb4d923aeaa..8b285852ce82 100644 > --- a/drivers/spi/spidev.c > +++ b/drivers/spi/spidev.c > @@ -683,6 +683,7 @@ static const struct of_device_id spidev_dt_ids[] = { > { .compatible = "dh,dhcom-board" }, > { .compatible = "menlo,m53cpld" }, > { .compatible = "cisco,spi-petra" }, > + { .compatible = "pensando,cpld" }, > {}, > }; This does not seem appropriate, I think a platform management driver should have a proper kernel abstraction instead of a user passthrough. As mentioned elsewhere, it also needs to be way more specific. If this is a programmable block, the compatible string might in fact need to contain both a board identifier and a revision number for the programmable logic, to ensure that the driver knows how to talk to it. Arnd
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 8cb4d923aeaa..8b285852ce82 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -683,6 +683,7 @@ static const struct of_device_id spidev_dt_ids[] = { { .compatible = "dh,dhcom-board" }, { .compatible = "menlo,m53cpld" }, { .compatible = "cisco,spi-petra" }, + { .compatible = "pensando,cpld" }, {}, }; MODULE_DEVICE_TABLE(of, spidev_dt_ids);
Pensando Elba SoC platforms have a SPI connected CPLD for platform management. Signed-off-by: Brad Larson <brad@pensando.io> --- drivers/spi/spidev.c | 1 + 1 file changed, 1 insertion(+)