diff mbox series

[6/7] arm64: dts: renesas: r8a77965: Add DAB support

Message ID 20210225225147.29920-7-fabrizio.castro.jz@renesas.com
State New
Headers show
Series Add FFT Support for R-Car Gen3 devices | expand

Commit Message

Fabrizio Castro Feb. 25, 2021, 10:51 p.m. UTC
R-Car M3-N (a.k.a. r8a77965) comes with the DAB hardware accelerator.
This patch adds SoC specific support.

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Geert Uytterhoeven Feb. 26, 2021, 9:37 a.m. UTC | #1
Hi Fabrizio,

On Thu, Feb 25, 2021 at 11:53 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> R-Car M3-N (a.k.a. r8a77965) comes with the DAB hardware accelerator.

> This patch adds SoC specific support.

>

> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>


LGTM (ignoring clock-names bikeshedding)

> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> @@ -1013,6 +1013,18 @@ ipmmu_vp0: iommu@fe990000 {

>                         #iommu-cells = <1>;

>                 };

>

> +               dab: dab@e6730000 {

> +                       compatible = "renesas,dab-r8a77965",

> +                                    "renesas,rcar-gen3-dab";

> +                       reg = <0x00 0xe6730000 0x00 0x120>;

> +                       interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;

> +                       clocks = <&cpg CPG_MOD 1016>;

> +                       clock-names = "dab";

> +                       power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;

> +                       resets = <&cpg 1016>;

> +                       status = "disabled";

> +               };

> +

>                 avb: ethernet@e6800000 {

>                         compatible = "renesas,etheravb-r8a77965",

>                                      "renesas,etheravb-rcar-gen3";


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Laurent Pinchart Feb. 26, 2021, 12:47 p.m. UTC | #2
Hi Fabrizio,

Thank you for the patch.

On Thu, Feb 25, 2021 at 10:51:46PM +0000, Fabrizio Castro wrote:
> R-Car M3-N (a.k.a. r8a77965) comes with the DAB hardware accelerator.

> This patch adds SoC specific support.

> 

> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

> ---

>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 12 ++++++++++++

>  1 file changed, 12 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> index 657b20d3533b..b6176fd5b703 100644

> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> @@ -1013,6 +1013,18 @@ ipmmu_vp0: iommu@fe990000 {

>  			#iommu-cells = <1>;

>  		};

>  

> +		dab: dab@e6730000 {

> +			compatible = "renesas,dab-r8a77965",

> +				     "renesas,rcar-gen3-dab";

> +			reg = <0x00 0xe6730000 0x00 0x120>;

> +			interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;

> +			clocks = <&cpg CPG_MOD 1016>;

> +			clock-names = "dab";

> +			power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;

> +			resets = <&cpg 1016>;


Same comments as for r8a77990.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


> +			status = "disabled";

> +		};

> +

>  		avb: ethernet@e6800000 {

>  			compatible = "renesas,etheravb-r8a77965",

>  				     "renesas,etheravb-rcar-gen3";


-- 
Regards,

Laurent Pinchart
Fabrizio Castro March 1, 2021, 2:54 p.m. UTC | #3
Hi Geert,

Thanks for you feedback!

> From: Geert Uytterhoeven <geert@linux-m68k.org>

> Sent: 26 February 2021 09:37

> Subject: Re: [PATCH 6/7] arm64: dts: renesas: r8a77965: Add DAB support

> 

> Hi Fabrizio,

> 

> On Thu, Feb 25, 2021 at 11:53 PM Fabrizio Castro

> <fabrizio.castro.jz@renesas.com> wrote:

> > R-Car M3-N (a.k.a. r8a77965) comes with the DAB hardware accelerator.

> > This patch adds SoC specific support.

> >

> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

> 

> LGTM (ignoring clock-names bikeshedding)


Will change the clock name as per your suggestion.

Thanks,
Fab

> 

> > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> > @@ -1013,6 +1013,18 @@ ipmmu_vp0: iommu@fe990000 {

> >                         #iommu-cells = <1>;

> >                 };

> >

> > +               dab: dab@e6730000 {

> > +                       compatible = "renesas,dab-r8a77965",

> > +                                    "renesas,rcar-gen3-dab";

> > +                       reg = <0x00 0xe6730000 0x00 0x120>;

> > +                       interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;

> > +                       clocks = <&cpg CPG_MOD 1016>;

> > +                       clock-names = "dab";

> > +                       power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;

> > +                       resets = <&cpg 1016>;

> > +                       status = "disabled";

> > +               };

> > +

> >                 avb: ethernet@e6800000 {

> >                         compatible = "renesas,etheravb-r8a77965",

> >                                      "renesas,etheravb-rcar-gen3";

> 

> Gr{oetje,eeting}s,

> 

>                         Geert

> 

> --

> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-

> m68k.org

> 

> In personal conversations with technical people, I call myself a hacker.

> But

> when I'm talking to journalists I just say "programmer" or something like

> that.

>                                 -- Linus Torvalds
Fabrizio Castro March 1, 2021, 2:55 p.m. UTC | #4
Hi Laurent,

Thanks for your feedback!

> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Sent: 26 February 2021 12:48

> Subject: Re: [PATCH 6/7] arm64: dts: renesas: r8a77965: Add DAB support

> 

> Hi Fabrizio,

> 

> Thank you for the patch.

> 

> On Thu, Feb 25, 2021 at 10:51:46PM +0000, Fabrizio Castro wrote:

> > R-Car M3-N (a.k.a. r8a77965) comes with the DAB hardware accelerator.

> > This patch adds SoC specific support.

> >

> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

> > ---

> >  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 12 ++++++++++++

> >  1 file changed, 12 insertions(+)

> >

> > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> > index 657b20d3533b..b6176fd5b703 100644

> > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> > @@ -1013,6 +1013,18 @@ ipmmu_vp0: iommu@fe990000 {

> >  			#iommu-cells = <1>;

> >  		};

> >

> > +		dab: dab@e6730000 {

> > +			compatible = "renesas,dab-r8a77965",

> > +				     "renesas,rcar-gen3-dab";

> > +			reg = <0x00 0xe6730000 0x00 0x120>;

> > +			interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;

> > +			clocks = <&cpg CPG_MOD 1016>;

> > +			clock-names = "dab";

> > +			power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;

> > +			resets = <&cpg 1016>;

> 

> Same comments as for r8a77990.


I will revise accordingly for v2.

Thanks,
Fab

> 

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> 

> > +			status = "disabled";

> > +		};

> > +

> >  		avb: ethernet@e6800000 {

> >  			compatible = "renesas,etheravb-r8a77965",

> >  				     "renesas,etheravb-rcar-gen3";

> 

> --

> Regards,

> 

> Laurent Pinchart
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 657b20d3533b..b6176fd5b703 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1013,6 +1013,18 @@  ipmmu_vp0: iommu@fe990000 {
 			#iommu-cells = <1>;
 		};
 
+		dab: dab@e6730000 {
+			compatible = "renesas,dab-r8a77965",
+				     "renesas,rcar-gen3-dab";
+			reg = <0x00 0xe6730000 0x00 0x120>;
+			interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 1016>;
+			clock-names = "dab";
+			power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+			resets = <&cpg 1016>;
+			status = "disabled";
+		};
+
 		avb: ethernet@e6800000 {
 			compatible = "renesas,etheravb-r8a77965",
 				     "renesas,etheravb-rcar-gen3";