| Message ID | 20210219181032.1.I23e12818c4a841ba9c37c60b3ba8cfeeb048285f@changeid |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: sc7180: Add lazor rev4 | expand |
Hi, On Fri, Feb 19, 2021 at 6:11 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > Lazor rev3 and older are stuffed with a 47k NTC thermistor for the > charger temperature which currently isn't supported by the PM6150 ADC > driver. A supported thermistor is used in rev4 and later revisions. > Add rev4 .dts files to be able to account for this. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > arch/arm64/boot/dts/qcom/Makefile | 3 ++ > .../dts/qcom/sc7180-trogdor-lazor-r3-kb.dts | 4 +-- > .../dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 4 +-- > .../boot/dts/qcom/sc7180-trogdor-lazor-r3.dts | 4 +-- > .../dts/qcom/sc7180-trogdor-lazor-r4-kb.dts | 20 +++++++++++++ > .../dts/qcom/sc7180-trogdor-lazor-r4-lte.dts | 28 +++++++++++++++++++ > .../boot/dts/qcom/sc7180-trogdor-lazor-r4.dts | 16 +++++++++++ > 7 files changed, 73 insertions(+), 6 deletions(-) From what I can see in the latest discussions -r4 _won't_ get stuffed with the 100K resistor. Thus we can just treat -r4 as the same as all the other revisoins now, right? -Doug
On Mon, Feb 22, 2021 at 03:20:53PM -0800, Doug Anderson wrote: > Hi, > > On Fri, Feb 19, 2021 at 6:11 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > Lazor rev3 and older are stuffed with a 47k NTC thermistor for the > > charger temperature which currently isn't supported by the PM6150 ADC > > driver. A supported thermistor is used in rev4 and later revisions. > > Add rev4 .dts files to be able to account for this. > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > --- > > > > arch/arm64/boot/dts/qcom/Makefile | 3 ++ > > .../dts/qcom/sc7180-trogdor-lazor-r3-kb.dts | 4 +-- > > .../dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 4 +-- > > .../boot/dts/qcom/sc7180-trogdor-lazor-r3.dts | 4 +-- > > .../dts/qcom/sc7180-trogdor-lazor-r4-kb.dts | 20 +++++++++++++ > > .../dts/qcom/sc7180-trogdor-lazor-r4-lte.dts | 28 +++++++++++++++++++ > > .../boot/dts/qcom/sc7180-trogdor-lazor-r4.dts | 16 +++++++++++ > > 7 files changed, 73 insertions(+), 6 deletions(-) > > From what I can see in the latest discussions -r4 _won't_ get stuffed > with the 100K resistor. Thus we can just treat -r4 as the same as all > the other revisoins now, right? Yes, looks like there is not need for an explicit -r4 after all.
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 549a7a2151d4..8a8ebca07b25 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -38,6 +38,9 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r3.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r3-kb.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r3-lte.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r4.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r4-kb.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r4-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-ganges-kirin.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dts index 6985beb97e53..a578326ffbad 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dts @@ -8,8 +8,8 @@ #include "sc7180-trogdor-lazor-r3.dts" / { - model = "Google Lazor (rev3+) with KB Backlight"; - compatible = "google,lazor-sku2", "qcom,sc7180"; + model = "Google Lazor (rev3) with KB Backlight"; + compatible = "google,lazor-rev3-sku2", "qcom,sc7180"; }; &keyboard_backlight { diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts index 0881f8dd02c9..40169b4a48a3 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts @@ -9,8 +9,8 @@ #include "sc7180-trogdor-lte-sku.dtsi" / { - model = "Google Lazor (rev3+) with LTE"; - compatible = "google,lazor-sku0", "qcom,sc7180"; + model = "Google Lazor (rev3) with LTE"; + compatible = "google,lazor-rev3-sku0", "qcom,sc7180"; }; &ap_sar_sensor { diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dts index 1b9d2f46359e..240c3e067fac 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dts @@ -10,6 +10,6 @@ #include "sc7180-trogdor-lazor.dtsi" / { - model = "Google Lazor (rev3+)"; - compatible = "google,lazor", "qcom,sc7180"; + model = "Google Lazor (rev3)"; + compatible = "google,lazor-rev3", "qcom,sc7180"; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4-kb.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4-kb.dts new file mode 100644 index 000000000000..e8c6d3745fed --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4-kb.dts @@ -0,0 +1,20 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Lazor board device tree source + * + * Copyright 2021 Google LLC. + */ + +/dts-v1/; + +#include "sc7180-trogdor-lazor.dtsi" +#include "sc7180-lite.dtsi" + +/ { + model = "Google Lazor (rev4+) with KB Backlight"; + compatible = "google,lazor-sku2", "qcom,sc7180"; +}; + +&keyboard_backlight { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4-lte.dts new file mode 100644 index 000000000000..b260bcf85d4c --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4-lte.dts @@ -0,0 +1,28 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Lazor board device tree source + * + * Copyright 2021 Google LLC. + */ + +/dts-v1/; + +#include "sc7180-trogdor-lazor.dtsi" +#include "sc7180-trogdor-lte-sku.dtsi" + +/ { + model = "Google Lazor (rev4+) with LTE"; + compatible = "google,lazor-sku0", "qcom,sc7180"; +}; + +&ap_sar_sensor { + status = "okay"; +}; + +&ap_sar_sensor_i2c { + status = "okay"; +}; + +&keyboard_backlight { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4.dts new file mode 100644 index 000000000000..e6f4e030763e --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4.dts @@ -0,0 +1,16 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Lazor board device tree source + * + * Copyright 2021 Google LLC. + */ + +/dts-v1/; + +#include "sc7180-trogdor-lazor.dtsi" +#include "sc7180-lite.dtsi" + +/ { + model = "Google Lazor (rev4+)"; + compatible = "google,lazor", "qcom,sc7180"; +};
Lazor rev3 and older are stuffed with a 47k NTC thermistor for the charger temperature which currently isn't supported by the PM6150 ADC driver. A supported thermistor is used in rev4 and later revisions. Add rev4 .dts files to be able to account for this. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- arch/arm64/boot/dts/qcom/Makefile | 3 ++ .../dts/qcom/sc7180-trogdor-lazor-r3-kb.dts | 4 +-- .../dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 4 +-- .../boot/dts/qcom/sc7180-trogdor-lazor-r3.dts | 4 +-- .../dts/qcom/sc7180-trogdor-lazor-r4-kb.dts | 20 +++++++++++++ .../dts/qcom/sc7180-trogdor-lazor-r4-lte.dts | 28 +++++++++++++++++++ .../boot/dts/qcom/sc7180-trogdor-lazor-r4.dts | 16 +++++++++++ 7 files changed, 73 insertions(+), 6 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4-kb.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4-lte.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r4.dts