diff mbox series

[RESEND,mac80211-next] cfg80211: remove unused callback

Message ID 20210208113356.4105-1-mcroce@linux.microsoft.com
State New
Headers show
Series [RESEND,mac80211-next] cfg80211: remove unused callback | expand

Commit Message

Matteo Croce Feb. 8, 2021, 11:33 a.m. UTC 
From: Matteo Croce <mcroce@microsoft.com>

The ieee80211 class registers a callback which actually does nothing.
Given that the callback is optional, and all its accesses are protected
by a NULL check, remove it entirely.

Signed-off-by: Matteo Croce <mcroce@microsoft.com>
---
Resend using proper mac80211-next tag

 net/wireless/sysfs.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Matteo Croce Feb. 19, 2021, 4:54 p.m. UTC | #1 
On Mon, Feb 8, 2021 at 12:34 PM Matteo Croce <mcroce@linux.microsoft.com> wrote:
>

> From: Matteo Croce <mcroce@microsoft.com>

>

> The ieee80211 class registers a callback which actually does nothing.

> Given that the callback is optional, and all its accesses are protected

> by a NULL check, remove it entirely.

>

> Signed-off-by: Matteo Croce <mcroce@microsoft.com>

> ---


Hi,

Quick follow up, did anybody look at this?

Cheers,
-- 
per aspera ad upstream
Matteo Croce Feb. 19, 2021, 5:05 p.m. UTC | #2 
On Fri, Feb 19, 2021 at 5:54 PM Matteo Croce <mcroce@linux.microsoft.com> wrote:
>

> On Mon, Feb 8, 2021 at 12:34 PM Matteo Croce <mcroce@linux.microsoft.com> wrote:

> >

> > From: Matteo Croce <mcroce@microsoft.com>

> >

> > The ieee80211 class registers a callback which actually does nothing.

> > Given that the callback is optional, and all its accesses are protected

> > by a NULL check, remove it entirely.

> >

> > Signed-off-by: Matteo Croce <mcroce@microsoft.com>

> > ---

>

> Hi,

>

> Quick follow up, did anybody look at this?

>

> Cheers,

> --

> per aspera ad upstream


Oops, I see it was merged in 258afa78661178d16288537ffe8ef863c7e5918a,
never mind!

Thanks,
-- 
per aspera ad upstream
diff mbox series

Patch

diff --git a/net/wireless/sysfs.c b/net/wireless/sysfs.c
index 3ac1f48195d2..41cb4d565149 100644
--- a/net/wireless/sysfs.c
+++ b/net/wireless/sysfs.c
@@ -81,12 +81,6 @@  static void wiphy_dev_release(struct device *dev)
 	cfg80211_dev_free(rdev);
 }
 
-static int wiphy_uevent(struct device *dev, struct kobj_uevent_env *env)
-{
-	/* TODO, we probably need stuff here */
-	return 0;
-}
-
 #ifdef CONFIG_PM_SLEEP
 static void cfg80211_leave_all(struct cfg80211_registered_device *rdev)
 {
@@ -157,7 +151,6 @@  struct class ieee80211_class = {
 	.owner = THIS_MODULE,
 	.dev_release = wiphy_dev_release,
 	.dev_groups = ieee80211_groups,
-	.dev_uevent = wiphy_uevent,
 	.pm = WIPHY_PM_OPS,
 	.ns_type = &net_ns_type_operations,
 	.namespace = wiphy_namespace,