| Message ID | 1612777137-51067-1-git-send-email-yumeng18@huawei.com |
|---|---|
| Headers | show |
| Series | add ECDH and CURVE25519 algorithms support for Kunpeng 930 | expand |
On Mon, Feb 08, 2021 at 05:38:51PM +0800, Meng Yu wrote: > As curve id of ECDH will be moved from its key into algorithm name, > we cannot use 'curve_id' in 'struct ecdh', so we should modify ECDH > driver in atmel, and make ECDH algorithm name be the same as crypto > (like 'ecdh-nist-pxxx'); > > Signed-off-by: Meng Yu <yumeng18@huawei.com> > Reviewed-by: Zaibo Xu <xuzaibo@huawei.com> > --- > drivers/crypto/atmel-ecc.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Patches 3-5 need to be squashed into one in order to avoid future bisection failures. The alternative is to let the new/old names coexist but it's probably not worth it for this case as the number of drivers impacted is small. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
在 2021/2/10 12:56, Herbert Xu 写道: > On Mon, Feb 08, 2021 at 05:38:51PM +0800, Meng Yu wrote: >> As curve id of ECDH will be moved from its key into algorithm name, >> we cannot use 'curve_id' in 'struct ecdh', so we should modify ECDH >> driver in atmel, and make ECDH algorithm name be the same as crypto >> (like 'ecdh-nist-pxxx'); >> >> Signed-off-by: Meng Yu <yumeng18@huawei.com> >> Reviewed-by: Zaibo Xu <xuzaibo@huawei.com> >> --- >> drivers/crypto/atmel-ecc.c | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) > > Patches 3-5 need to be squashed into one in order to avoid future > bisection failures. > > The alternative is to let the new/old names coexist but it's probably > not worth it for this case as the number of drivers impacted is small. > > Thanks, > OK, thanks.
1. Move curve ID from the key into the algorithm name (like 'ecdh-nist-pxxx' so we get its tfm like 'crypto_alloc_kpp("ecdh-nist-p256", 0, 0)'), in 'crypto/ecc.c' (has been verified by testmgr) and 'crypto/atmel-ecc.c' (only compiled, not do test), and modify 'testmgr.c' and 'net/bluetooth/smp.c' (only compiled, not do test) to adapt the modification; 2. Add new elliptic(nist-p224, nist-p384, nist-p521) curve parameters definitions, and reorder ECDH 'Curves IDs'; 3. Add new file 'include/crypto/ecc_curve.h', and move 'struct ecc_point' and 'struct ecc_curve' definitions to it, also add new APIs 'ecc_get_curveXXX' into it, with these APIs, users in kernel tree can get ECDH and curve25519 parameters; 4. Add ECDH and CURVE25519 algorithms support for Kunpeng 930. v7->v8: - patch #3 and #5: move the curve ID from the key into the algorithm name instead v6->v7: - patch #4: add function interface to expose elliptic curve parameters - patch #4: eliminate warning by 'kernel test robot' - patch #5: add function interface to expose curve25519 parameters v5->v6: - patch #1: add a new patch (the first patch), which is the "depend on" patch before v4->v5: - patch #4: delete P-128 and P-320 curve, as the few using case in the kernel v3 -> v4: - patch #3: add new, and move ecc_curve params to "include/crypto" v2 -> v3: - patch #5: fix sparse warnings - patch #5: add 'CRYPTO_LIB_CURVE25519_GENERIC' in 'Kconfig' v1 -> v2: - patch #5: delete `curve25519_null_point' Meng Yu (9): crypto: hisilicon/hpre - add version adapt to new algorithms crypto: hisilicon/hpre - add algorithm type crypto: atmel-ecc - move curve_id of ECDH from the key to algorithm name net/bluetooth: modify ECDH name in 'crypto_alloc_kpp' crypto: move curve_id of ECDH to algorithm name crypto: add new ecc curve and expose them crypto: hisilicon/hpre - add 'ECDH' algorithm crypto: add curve25519 params and expose them crypto: hisilicon/hpre - add 'CURVE25519' algorithm crypto/ecc.c | 17 +- crypto/ecc.h | 37 +- crypto/ecc_curve_defs.h | 124 +++ crypto/ecdh.c | 72 +- crypto/ecdh_helper.c | 4 +- crypto/testmgr.c | 11 +- crypto/testmgr.h | 32 +- drivers/crypto/atmel-ecc.c | 14 +- drivers/crypto/hisilicon/Kconfig | 1 + drivers/crypto/hisilicon/hpre/hpre.h | 17 +- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 1097 +++++++++++++++++++++++++-- drivers/crypto/hisilicon/hpre/hpre_main.c | 12 +- drivers/crypto/hisilicon/qm.c | 4 +- drivers/crypto/hisilicon/qm.h | 4 +- drivers/crypto/hisilicon/sec2/sec.h | 4 +- drivers/crypto/hisilicon/sec2/sec_crypto.c | 4 +- drivers/crypto/hisilicon/sec2/sec_crypto.h | 4 +- drivers/crypto/hisilicon/zip/zip.h | 4 +- drivers/crypto/hisilicon/zip/zip_crypto.c | 4 +- include/crypto/ecc_curve.h | 60 ++ include/crypto/ecdh.h | 7 +- net/bluetooth/ecdh_helper.c | 2 - net/bluetooth/selftest.c | 2 +- net/bluetooth/smp.c | 6 +- 24 files changed, 1370 insertions(+), 173 deletions(-) create mode 100644 include/crypto/ecc_curve.h