| Message ID | b7025d14fc8eb0eac95437ac62e74f64a7cf2b4c.1613042245.git.matti.vaittinen@fi.rohmeurope.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFC,1/7] dt_bindings: Add protection limit properties | expand |
On Thu, 11 Feb 2021 14:35:41 +0200, Matti Vaittinen wrote: > BD9576MUF provides over-current protection and detection. Current is > measured as voltage loss over external FET. Allow specifying FET's on > resistance so current monitoring limits can be converted to voltages. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > .../devicetree/bindings/regulator/rohm,bd9576-regulator.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml:31:34: [error] empty value in block mapping (empty-values) dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml: patternProperties:regulator-.+:properties:description: "External FET's ON-resistance. Required if VoutS1 OCP/OCW is to be set." is not of type 'object', 'boolean' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml: patternProperties:regulator-.+:properties:rohm,ocw-fet-ron-milliohms: None is not of type 'object', 'boolean' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml: patternProperties:regulator-.+:properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'description' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml: patternProperties:regulator-.+:properties:rohm,ocw-fet-ron-milliohms: None is not of type 'object' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml: ignoring, error in schema: patternProperties: regulator-.+: properties: rohm,ocw-fet-ron-milliohms warning: no schema found in file: ./Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml See https://patchwork.ozlabs.org/patch/1439442 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Thu, Feb 11, 2021 at 02:35:41PM +0200, Matti Vaittinen wrote: > BD9576MUF provides over-current protection and detection. Current is > measured as voltage loss over external FET. Allow specifying FET's on > resistance so current monitoring limits can be converted to voltages. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > .../devicetree/bindings/regulator/rohm,bd9576-regulator.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml b/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml > index b6515a0cee62..ad3f57e9cd9b 100644 > --- a/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml > @@ -27,6 +27,11 @@ patternProperties: > Properties for single regulator. > $ref: "regulator.yaml#" > > + properties: > + rohm,ocw-fet-ron-milliohms: We have '-ohms' and '-micro-ohms' already. Neither range works for you? > + description: External FET's ON-resistance. Required if VoutS1 OCP/OCW is > + to be set. > + > required: > - regulator-name > > -- > 2.25.4 > > > -- > Matti Vaittinen, Linux device drivers > ROHM Semiconductors, Finland SWDC > Kiviharjunlenkki 1E > 90220 OULU > FINLAND > > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ > Thanks to Simon Glass for the translation =]
Morning Rob, On Wed, 2021-02-17 at 15:34 -0600, Rob Herring wrote: > On Thu, Feb 11, 2021 at 02:35:41PM +0200, Matti Vaittinen wrote: > > BD9576MUF provides over-current protection and detection. Current > > is > > measured as voltage loss over external FET. Allow specifying FET's > > on > > resistance so current monitoring limits can be converted to > > voltages. > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > > --- > > .../devicetree/bindings/regulator/rohm,bd9576-regulator.yaml | 5 > > +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/regulator/rohm,bd9576- > > regulator.yaml > > b/Documentation/devicetree/bindings/regulator/rohm,bd9576- > > regulator.yaml > > index b6515a0cee62..ad3f57e9cd9b 100644 > > --- a/Documentation/devicetree/bindings/regulator/rohm,bd9576- > > regulator.yaml > > +++ b/Documentation/devicetree/bindings/regulator/rohm,bd9576- > > regulator.yaml > > @@ -27,6 +27,11 @@ patternProperties: > > Properties for single regulator. > > $ref: "regulator.yaml#" > > > > + properties: > > + rohm,ocw-fet-ron-milliohms: > > We have '-ohms' and '-micro-ohms' already. Neither range works for > you? Thanks for taking a look at this :) I expect values to be magnitude of few hundred milliohms - which means micro-ohms should be usable. I'll try to still check this as I am far from being HW-expert. I probably can convert this to micro-ohms for v2. Best Regards Matti Vaittinen -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. "non cogito me" dixit Rene Descarte, deinde evanescavit (Thanks for the translation Simon)
diff --git a/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml b/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml index b6515a0cee62..ad3f57e9cd9b 100644 --- a/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml @@ -27,6 +27,11 @@ patternProperties: Properties for single regulator. $ref: "regulator.yaml#" + properties: + rohm,ocw-fet-ron-milliohms: + description: External FET's ON-resistance. Required if VoutS1 OCP/OCW is + to be set. + required: - regulator-name
BD9576MUF provides over-current protection and detection. Current is measured as voltage loss over external FET. Allow specifying FET's on resistance so current monitoring limits can be converted to voltages. Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> --- .../devicetree/bindings/regulator/rohm,bd9576-regulator.yaml | 5 +++++ 1 file changed, 5 insertions(+)