| Message ID | 20210203135441.136-2-martinax.krasteva@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v7,1/2] dt-bindings: media: Add bindings for imx334 | expand |
On Wed, 03 Feb 2021 13:54:40 +0000, Martina Krasteva wrote: > From: Martina Krasteva <martinax.krasteva@intel.com> > > - Add dt-bindings documentation for Sony imx334 sensor driver. > - Add MAINTAINERS entry for Sony imx334 binding documentation. > > Signed-off-by: Martina Krasteva <martinax.krasteva@intel.com> > Reviewed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com> > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > Acked-by: Paul J. Murphy <paul.j.murphy@intel.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/media/i2c/sony,imx334.yaml | 90 ++++++++++++++++++++++ > MAINTAINERS | 8 ++ > 2 files changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/media/i2c/sony,imx334.example.dts:28.17-18 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:344: Documentation/devicetree/bindings/media/i2c/sony,imx334.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1370: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1435383 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Thu, Feb 4, 2021 at 10:17 AM Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > Hi Rob, > > On Thu, Feb 04, 2021 at 09:20:57AM -0600, Rob Herring wrote: > > On Wed, 03 Feb 2021 13:54:40 +0000, Martina Krasteva wrote: > > > From: Martina Krasteva <martinax.krasteva@intel.com> > > > > > > - Add dt-bindings documentation for Sony imx334 sensor driver. > > > - Add MAINTAINERS entry for Sony imx334 binding documentation. > > > > > > Signed-off-by: Martina Krasteva <martinax.krasteva@intel.com> > > > Reviewed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com> > > > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > > > Acked-by: Paul J. Murphy <paul.j.murphy@intel.com> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > --- > > > .../devicetree/bindings/media/i2c/sony,imx334.yaml | 90 ++++++++++++++++++++++ > > > MAINTAINERS | 8 ++ > > > 2 files changed, 98 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Error: Documentation/devicetree/bindings/media/i2c/sony,imx334.example.dts:28.17-18 syntax error > > FATAL ERROR: Unable to parse input tree That's usually a missing header for #defines. > > make[1]: *** [scripts/Makefile.lib:344: Documentation/devicetree/bindings/media/i2c/sony,imx334.example.dt.yaml] Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > make: *** [Makefile:1370: dt_binding_check] Error 2 > > > > See https://patchwork.ozlabs.org/patch/1435383 > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > Thanks for reporting this. The example was apparently missing the > assigned-clock-parents property. I'll squash the following change to the > patch: Doubtful. That would be a more specific schema error. > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > index 3145e94d043e7..4217fbea0735a 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > @@ -76,6 +76,7 @@ examples: > clocks = <&imx334_clk> > > assigned-clocks = <&imx334_clk>; > + assigned-clock-parents = <&imx334_clk_parent>; > assigned-clock-rates = <24000000>; > > port { > > -- > Kind regards, > > Sakari Ailus
HI Rob, On Thu, Feb 04, 2021 at 05:06:04PM -0600, Rob Herring wrote: > On Thu, Feb 4, 2021 at 10:17 AM Sakari Ailus > <sakari.ailus@linux.intel.com> wrote: > > > > Hi Rob, > > > > On Thu, Feb 04, 2021 at 09:20:57AM -0600, Rob Herring wrote: > > > On Wed, 03 Feb 2021 13:54:40 +0000, Martina Krasteva wrote: > > > > From: Martina Krasteva <martinax.krasteva@intel.com> > > > > > > > > - Add dt-bindings documentation for Sony imx334 sensor driver. > > > > - Add MAINTAINERS entry for Sony imx334 binding documentation. > > > > > > > > Signed-off-by: Martina Krasteva <martinax.krasteva@intel.com> > > > > Reviewed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com> > > > > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > > > > Acked-by: Paul J. Murphy <paul.j.murphy@intel.com> > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > --- > > > > .../devicetree/bindings/media/i2c/sony,imx334.yaml | 90 ++++++++++++++++++++++ > > > > MAINTAINERS | 8 ++ > > > > 2 files changed, 98 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > Error: Documentation/devicetree/bindings/media/i2c/sony,imx334.example.dts:28.17-18 syntax error > > > FATAL ERROR: Unable to parse input tree > > That's usually a missing header for #defines. > > > > make[1]: *** [scripts/Makefile.lib:344: Documentation/devicetree/bindings/media/i2c/sony,imx334.example.dt.yaml] Error 1 > > > make[1]: *** Waiting for unfinished jobs.... > > > make: *** [Makefile:1370: dt_binding_check] Error 2 > > > > > > See https://patchwork.ozlabs.org/patch/1435383 > > > > > > This check can fail if there are any dependencies. The base for a patch > > > series is generally the most recent rc1. > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > > date: > > > > > > pip3 install dtschema --upgrade > > > > > > Please check and re-submit. > > > > Thanks for reporting this. The example was apparently missing the > > assigned-clock-parents property. I'll squash the following change to the > > patch: > > Doubtful. That would be a more specific schema error. Well, I guess the parsing didn't get quite there. There's a missing semicolon a few lines above it. > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > index 3145e94d043e7..4217fbea0735a 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > @@ -76,6 +76,7 @@ examples: > > clocks = <&imx334_clk> ^ > > > > assigned-clocks = <&imx334_clk>; > > + assigned-clock-parents = <&imx334_clk_parent>; > > assigned-clock-rates = <24000000>; > > > > port { > > -- Kind regards, Sakari Ailus
On Wed, Feb 03, 2021 at 01:54:40PM +0000, Martina Krasteva wrote: > From: Martina Krasteva <martinax.krasteva@intel.com> > > - Add dt-bindings documentation for Sony imx334 sensor driver. > - Add MAINTAINERS entry for Sony imx334 binding documentation. > > Signed-off-by: Martina Krasteva <martinax.krasteva@intel.com> > Reviewed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com> > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > Acked-by: Paul J. Murphy <paul.j.murphy@intel.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/media/i2c/sony,imx334.yaml | 90 ++++++++++++++++++++++ > MAINTAINERS | 8 ++ > 2 files changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > new file mode 100644 > index 000000000000..3145e94d043e > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > @@ -0,0 +1,90 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2021 Intel Corporation > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/sony,imx334.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony IMX334 Sensor > + > +maintainers: > + - Paul J. Murphy <paul.j.murphy@intel.com> > + - Daniele Alessandrelli <daniele.alessandrelli@intel.com> > + > +description: > + IMX334 sensor is a Sony CMOS active pixel digital image sensor with an active > + array size of 3864H x 2202V. It is programmable through I2C interface. The > + I2C client address is fixed to 0x1a as per sensor data sheet. Image data is > + sent through MIPI CSI-2. > + > +properties: > + compatible: > + const: sony,imx334 > + reg: > + description: I2C address > + maxItems: 1 > + > + assigned-clocks: true > + assigned-clock-parents: true > + assigned-clock-rates: true > + > + clocks: > + description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz > + maxItems: 1 > + > + reset-gpios: > + description: Reference to the GPIO connected to the XCLR pin, if any. > + > + port: > + type: object > + additionalProperties: false > + $ref: /schemas/graph.yaml#/properties/port > + > + properties: > + endpoint: > + type: object > + properties: > + data-lanes: > + $ref: ../video-interfaces.yaml#/properties/data-lanes > + link-frequencies: > + $ref: ../video-interfaces.yaml#/properties/link-frequencies > + > + required: > + - data-lanes > + - link-frequencies > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - clocks > + - port > + > +additionalProperties: false For the bindings: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > + reg = <0x1a>; > + clocks = <&imx334_clk> > + > + assigned-clocks = <&imx334_clk>; > + assigned-clock-rates = <24000000>; > + > + port { > + imx334: endpoint { > + remote-endpoint = <&cam>; > + data-lanes = <1 2 3 4>; > + link-frequencies = /bits/ 64 <891000000>; > + }; > + }; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 3353de0c4bc8..2ab75519938a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16589,6 +16589,14 @@ S: Maintained > T: git git://linuxtv.org/media_tree.git > F: drivers/media/i2c/imx319.c > > +SONY IMX334 SENSOR DRIVER > +M: Paul J. Murphy <paul.j.murphy@intel.com> This entry looks unusual. Paul's name appears in multiple places (added as maintainer for Keembay and this sensor) but there are no emails from him: https://lore.kernel.org/lkml/?q=f%3Apaul.j.murphy%40intel.com Nothing on LKML. Does this person really exists and plans to work with upstream? I am asking because several patches came with acks and reviews before first submission to LKML which could mean that you just send something from your internal kernel tree. Usually it is expected to see the Acks/Reviews/Tested on the lists. Providing them via private channels is rather discouraged - does not look like open way of doing things. Best regards, Krzysztof > +M: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > +L: linux-media@vger.kernel.org > +S: Maintained > +T: git git://linuxtv.org/media_tree.git > +F: Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml new file mode 100644 index 000000000000..3145e94d043e --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml @@ -0,0 +1,90 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2021 Intel Corporation +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx334.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony IMX334 Sensor + +maintainers: + - Paul J. Murphy <paul.j.murphy@intel.com> + - Daniele Alessandrelli <daniele.alessandrelli@intel.com> + +description: + IMX334 sensor is a Sony CMOS active pixel digital image sensor with an active + array size of 3864H x 2202V. It is programmable through I2C interface. The + I2C client address is fixed to 0x1a as per sensor data sheet. Image data is + sent through MIPI CSI-2. + +properties: + compatible: + const: sony,imx334 + reg: + description: I2C address + maxItems: 1 + + assigned-clocks: true + assigned-clock-parents: true + assigned-clock-rates: true + + clocks: + description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz + maxItems: 1 + + reset-gpios: + description: Reference to the GPIO connected to the XCLR pin, if any. + + port: + type: object + additionalProperties: false + $ref: /schemas/graph.yaml#/properties/port + + properties: + endpoint: + type: object + properties: + data-lanes: + $ref: ../video-interfaces.yaml#/properties/data-lanes + link-frequencies: + $ref: ../video-interfaces.yaml#/properties/link-frequencies + + required: + - data-lanes + - link-frequencies + + required: + - endpoint + +required: + - compatible + - reg + - clocks + - port + +additionalProperties: false + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + camera@1a { + compatible = "sony,imx334"; + reg = <0x1a>; + clocks = <&imx334_clk> + + assigned-clocks = <&imx334_clk>; + assigned-clock-rates = <24000000>; + + port { + imx334: endpoint { + remote-endpoint = <&cam>; + data-lanes = <1 2 3 4>; + link-frequencies = /bits/ 64 <891000000>; + }; + }; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 3353de0c4bc8..2ab75519938a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16589,6 +16589,14 @@ S: Maintained T: git git://linuxtv.org/media_tree.git F: drivers/media/i2c/imx319.c +SONY IMX334 SENSOR DRIVER +M: Paul J. Murphy <paul.j.murphy@intel.com> +M: Daniele Alessandrelli <daniele.alessandrelli@intel.com> +L: linux-media@vger.kernel.org +S: Maintained +T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml + SONY IMX355 SENSOR DRIVER M: Tianshu Qiu <tian.shu.qiu@intel.com> L: linux-media@vger.kernel.org