mbox series

[i2c-next,v5,0/6] mux: mlxcpld: Extend driver functionality

Message ID 20210208201606.10620-1-vadimp@nvidia.com
Headers show
Series mux: mlxcpld: Extend driver functionality | expand

Message

Vadim Pasternak Feb. 8, 2021, 8:16 p.m. UTC
The patchset adds new features for the existing Mellanox systems.

Patch #1 converts driver to platform driver.
Patch #2 prepare driver for word addressing support.
Patch #3 removes adapter numbers enforcement.
Patch #4 adds support for word address space devices.
Patch #5 extends mux number supported by driver.
Patch #6 adds callback notification about mux creation.

Vadim Pasternak (6):
  i2c: mux: mlxcpld: Convert driver to platform driver
  i2c: mux: mlxcpld: Prepare mux selection infrastructure for two-byte
    support
  i2c: mux: mlxcpld: Get rid of adapter numbers enforcement
  i2c: mux: mlxcpld: Extend driver to support word address space devices
  i2c: mux: mlxcpld: Extend supported mux number
  i2c: mux: mlxcpld: Add callback to notify mux creation completion

 drivers/i2c/muxes/i2c-mux-mlxcpld.c   | 128 ++++++++++++++++++++--------------
 include/linux/platform_data/mlxcpld.h |  11 ++-
 2 files changed, 83 insertions(+), 56 deletions(-)

Comments

Peter Rosin Feb. 8, 2021, 9:26 p.m. UTC | #1
Hi!

On 2021-02-08 21:16, Vadim Pasternak wrote:
> The patchset adds new features for the existing Mellanox systems.
> 
> Patch #1 converts driver to platform driver.
> Patch #2 prepare driver for word addressing support.
> Patch #3 removes adapter numbers enforcement.
> Patch #4 adds support for word address space devices.
> Patch #5 extends mux number supported by driver.
> Patch #6 adds callback notification about mux creation.
> 
> Vadim Pasternak (6):
>   i2c: mux: mlxcpld: Convert driver to platform driver
>   i2c: mux: mlxcpld: Prepare mux selection infrastructure for two-byte
>     support
>   i2c: mux: mlxcpld: Get rid of adapter numbers enforcement
>   i2c: mux: mlxcpld: Extend driver to support word address space devices
>   i2c: mux: mlxcpld: Extend supported mux number
>   i2c: mux: mlxcpld: Add callback to notify mux creation completion
> 
>  drivers/i2c/muxes/i2c-mux-mlxcpld.c   | 128 ++++++++++++++++++++--------------
>  include/linux/platform_data/mlxcpld.h |  11 ++-
>  2 files changed, 83 insertions(+), 56 deletions(-)
> 

I am now happy with this series. All looks good and every patch makes sense
on its own. Thank you for putting in the effort!

Cheers,
Peter
Peter Rosin Feb. 8, 2021, 9:27 p.m. UTC | #2
On 2021-02-08 21:16, Vadim Pasternak wrote:
> Add notification to inform caller that mux objects array has been
> created. It allows to user, invoked platform device registration for
> "i2c-mux-mlxcpld" driver, to be notified that mux infrastructure is
> available, and thus some devices could be connected to this
> infrastructure.
> 
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>

Acked-by: Peter Rosin <peda@axentia.se>
Wolfram Sang Feb. 9, 2021, 10:38 a.m. UTC | #3
On Mon, Feb 08, 2021 at 10:26:08PM +0100, Peter Rosin wrote:
> Hi!

> 

> On 2021-02-08 21:16, Vadim Pasternak wrote:

> > The patchset adds new features for the existing Mellanox systems.

> > 

> > Patch #1 converts driver to platform driver.

> > Patch #2 prepare driver for word addressing support.

> > Patch #3 removes adapter numbers enforcement.

> > Patch #4 adds support for word address space devices.

> > Patch #5 extends mux number supported by driver.

> > Patch #6 adds callback notification about mux creation.

> > 

> > Vadim Pasternak (6):

> >   i2c: mux: mlxcpld: Convert driver to platform driver

> >   i2c: mux: mlxcpld: Prepare mux selection infrastructure for two-byte

> >     support

> >   i2c: mux: mlxcpld: Get rid of adapter numbers enforcement

> >   i2c: mux: mlxcpld: Extend driver to support word address space devices

> >   i2c: mux: mlxcpld: Extend supported mux number

> >   i2c: mux: mlxcpld: Add callback to notify mux creation completion

> > 

> >  drivers/i2c/muxes/i2c-mux-mlxcpld.c   | 128 ++++++++++++++++++++--------------

> >  include/linux/platform_data/mlxcpld.h |  11 ++-

> >  2 files changed, 83 insertions(+), 56 deletions(-)

> > 

> 

> I am now happy with this series. All looks good and every patch makes sense

> on its own. Thank you for putting in the effort!


All applied to for-next, thanks everyone!