diff mbox series

[v2] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming

Message ID 20210205143444.1155367-1-lains@archlinux.org
State New
Headers show
Series [v2] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming | expand

Commit Message

Filipe Laíns Feb. 5, 2021, 2:34 p.m. UTC 
From: Filipe Laíns <lains@riseup.net>

In e400071a805d6229223a98899e9da8c6233704a1 I added support for the
receiver that comes with the G602 device, but unfortunately I screwed up
during testing and it seems the keyboard events were actually not being
sent to userspace.
This resulted in keyboard events being broken in userspace, please
backport the fix.

The receiver uses the normal 0x01 Logitech keyboard report descriptor,
as expected, so it is just a matter of flagging it as supported.

Reported in
https://github.com/libratbag/libratbag/issues/1124

Fixes: e400071a805d6 ("HID: logitech-dj: add the G602 receiver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Filipe Laíns <lains@riseup.net>
---

Changes in v2:
- added missing Fixes: anc Cc: tags

 drivers/hid/hid-logitech-dj.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jiri Kosina Feb. 5, 2021, 3:09 p.m. UTC | #1 
On Fri, 5 Feb 2021, Filipe Laíns wrote:

> From: Filipe Laíns <lains@riseup.net>
> 
> In e400071a805d6229223a98899e9da8c6233704a1 I added support for the
> receiver that comes with the G602 device, but unfortunately I screwed up
> during testing and it seems the keyboard events were actually not being
> sent to userspace.
> This resulted in keyboard events being broken in userspace, please
> backport the fix.
> 
> The receiver uses the normal 0x01 Logitech keyboard report descriptor,
> as expected, so it is just a matter of flagging it as supported.
> 
> Reported in
> https://github.com/libratbag/libratbag/issues/1124
> 
> Fixes: e400071a805d6 ("HID: logitech-dj: add the G602 receiver")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Filipe Laíns <lains@riseup.net>
> ---
> 
> Changes in v2:
> - added missing Fixes: anc Cc: tags

Applied, thanks Filipe.
diff mbox series

Patch

diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index 6596c81947a8..2703333edc34 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -981,6 +981,7 @@  static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,
 	case 0x07:
 		device_type = "eQUAD step 4 Gaming";
 		logi_hidpp_dev_conn_notif_equad(hdev, hidpp_report, &workitem);
+		workitem.reports_supported |= STD_KEYBOARD;
 		break;
 	case 0x08:
 		device_type = "eQUAD step 4 for gamepads";