| Message ID | 20210127172500.13356-5-andre.przywara@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | None | expand |
On Wed, Jan 27, 2021 at 05:24:44PM +0000, Andre Przywara wrote: > The AXP305 PMIC used in AXP805 seems to be fully compatible to the > AXP805 PMIC, so add the proper chain of compatible strings. > > Also at least on one board (Orangepi Zero2) there is no interrupt line > connected to the CPU, so make the "interrupts" property optional. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Maxime Ripard <mripard@kernel.org> Maxime
Hi, On Thu, Jan 28, 2021 at 1:26 AM Andre Przywara <andre.przywara@arm.com> wrote: > > The AXP305 PMIC used in AXP805 seems to be fully compatible to the ^ This statement doesn't quite make sense. I assume you wanted to mention a board or the H616 SoC here? > AXP805 PMIC, so add the proper chain of compatible strings. > > Also at least on one board (Orangepi Zero2) there is no interrupt line > connected to the CPU, so make the "interrupts" property optional. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt > index 4991a6415796..4fd748101e3c 100644 > --- a/Documentation/devicetree/bindings/mfd/axp20x.txt > +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt > @@ -26,10 +26,10 @@ Required properties: > * "x-powers,axp803" > * "x-powers,axp806" > * "x-powers,axp805", "x-powers,axp806" > + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806" axp305? axp803 is used with A64 IIRC. ChenYu > * "x-powers,axp809" > * "x-powers,axp813" > - reg: The I2C slave address or RSB hardware address for the AXP chip > -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > - interrupt-controller: The PMIC has its own internal IRQs > - #interrupt-cells: Should be set to 1 > > @@ -43,6 +43,7 @@ more information: > AXP20x/LDO3: software-based implementation > > Optional properties: > +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz > AXP152/20X: range: 750-1875, Default: 1.5 MHz > AXP22X/8XX: range: 1800-4050, Default: 3 MHz > -- > 2.17.5 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20210127172500.13356-5-andre.przywara%40arm.com.
On Tue, 2 Feb 2021 15:55:50 +0800 Chen-Yu Tsai <wens@csie.org> wrote: Hi, > On Thu, Jan 28, 2021 at 1:26 AM Andre Przywara <andre.przywara@arm.com> wrote: > > > > The AXP305 PMIC used in AXP805 seems to be fully compatible to the > ^ > This statement doesn't quite make sense. I assume you wanted to mention > a board or the H616 SoC here? Argh, indeed! > > AXP805 PMIC, so add the proper chain of compatible strings. > > > > Also at least on one board (Orangepi Zero2) there is no interrupt line > > connected to the CPU, so make the "interrupts" property optional. > > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > --- > > Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt > > index 4991a6415796..4fd748101e3c 100644 > > --- a/Documentation/devicetree/bindings/mfd/axp20x.txt > > +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt > > @@ -26,10 +26,10 @@ Required properties: > > * "x-powers,axp803" > > * "x-powers,axp806" > > * "x-powers,axp805", "x-powers,axp806" > > + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806" > > axp305? axp803 is used with A64 IIRC. Oh, well spotted. This AXP naming already confused me when they were all called 80x, now using 30x gave me the rest ;-) Sorry for the blunder! Cheers, Andre > > ChenYu > > > * "x-powers,axp809" > > * "x-powers,axp813" > > - reg: The I2C slave address or RSB hardware address for the AXP chip > > -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > > - interrupt-controller: The PMIC has its own internal IRQs > > - #interrupt-cells: Should be set to 1 > > > > @@ -43,6 +43,7 @@ more information: > > AXP20x/LDO3: software-based implementation > > > > Optional properties: > > +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > > - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz > > AXP152/20X: range: 750-1875, Default: 1.5 MHz > > AXP22X/8XX: range: 1800-4050, Default: 3 MHz > > -- > > 2.17.5 > > > > -- > > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20210127172500.13356-5-andre.przywara%40arm.com.
On Wed, Jan 27, 2021 at 05:24:44PM +0000, Andre Przywara wrote: > The AXP305 PMIC used in AXP805 seems to be fully compatible to the > AXP805 PMIC, so add the proper chain of compatible strings. > > Also at least on one board (Orangepi Zero2) there is no interrupt line > connected to the CPU, so make the "interrupts" property optional. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt > index 4991a6415796..4fd748101e3c 100644 > --- a/Documentation/devicetree/bindings/mfd/axp20x.txt > +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt > @@ -26,10 +26,10 @@ Required properties: > * "x-powers,axp803" > * "x-powers,axp806" > * "x-powers,axp805", "x-powers,axp806" > + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806" I don't normally (yet) ask for schema conversions on compatible additions, but this is one of the few remaining compatibles with no schema for allwinner. So a conversion here would be nice. BTW, dtschema now has a better check for this (-m option) without the false positives. I plan to turn on the option soon (doesn't matter for dtbs as they all have lots of warnings, but bindings also get warnings). Either way, Acked-by: Rob Herring <robh@kernel.org> > * "x-powers,axp809" > * "x-powers,axp813" > - reg: The I2C slave address or RSB hardware address for the AXP chip > -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > - interrupt-controller: The PMIC has its own internal IRQs > - #interrupt-cells: Should be set to 1 > > @@ -43,6 +43,7 @@ more information: > AXP20x/LDO3: software-based implementation > > Optional properties: > +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz > AXP152/20X: range: 750-1875, Default: 1.5 MHz > AXP22X/8XX: range: 1800-4050, Default: 3 MHz > -- > 2.17.5 >
diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt index 4991a6415796..4fd748101e3c 100644 --- a/Documentation/devicetree/bindings/mfd/axp20x.txt +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt @@ -26,10 +26,10 @@ Required properties: * "x-powers,axp803" * "x-powers,axp806" * "x-powers,axp805", "x-powers,axp806" + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806" * "x-powers,axp809" * "x-powers,axp813" - reg: The I2C slave address or RSB hardware address for the AXP chip -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin - interrupt-controller: The PMIC has its own internal IRQs - #interrupt-cells: Should be set to 1 @@ -43,6 +43,7 @@ more information: AXP20x/LDO3: software-based implementation Optional properties: +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz AXP152/20X: range: 750-1875, Default: 1.5 MHz AXP22X/8XX: range: 1800-4050, Default: 3 MHz
The AXP305 PMIC used in AXP805 seems to be fully compatible to the AXP805 PMIC, so add the proper chain of compatible strings. Also at least on one board (Orangepi Zero2) there is no interrupt line connected to the CPU, so make the "interrupts" property optional. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)