| Message ID | 20210130191027.1225465-1-lains@archlinux.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming | expand |
On Sat, 30 Jan 2021, Filipe Laíns wrote: > From: Filipe Laíns <lains@riseup.net> > > In e400071a805d6229223a98899e9da8c6233704a1 I added support for the > receiver that comes with the G602 device, but unfortunately I screwed up > during testing and it seems the keyboard events were actually not being > sent to userspace. > This resulted in keyboard events being broken in userspace, please > backport the fix. > > The receiver uses the normal 0x01 Logitech keyboard report descriptor, > as expected, so it is just a matter of flagging it as supported. > > Reported in > https://github.com/libratbag/libratbag/issues/1124 > > Signed-off-by: Filipe Laíns <lains@riseup.net> Given this is a regression, could you please add proper Fixes: and Cc: stable tags? Thank you, -- Jiri Kosina SUSE Labs
On Fri, 2021-02-05 at 10:18 +0100, Jiri Kosina wrote: > On Sat, 30 Jan 2021, Filipe Laíns wrote: > > > From: Filipe Laíns <lains@riseup.net> > > > > In e400071a805d6229223a98899e9da8c6233704a1 I added support for the > > receiver that comes with the G602 device, but unfortunately I screwed up > > during testing and it seems the keyboard events were actually not being > > sent to userspace. > > This resulted in keyboard events being broken in userspace, please > > backport the fix. > > > > The receiver uses the normal 0x01 Logitech keyboard report descriptor, > > as expected, so it is just a matter of flagging it as supported. > > > > Reported in > > https://github.com/libratbag/libratbag/issues/1124 > > > > Signed-off-by: Filipe Laíns <lains@riseup.net> > > Given this is a regression, could you please add proper Fixes: and Cc: > stable tags? > > Thank you, > Done :) Sorry about that, I am not yet familiarized with all steps of the workflow. Cheers, Filipe Laíns
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 6596c81947a8..2703333edc34 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -981,6 +981,7 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev, case 0x07: device_type = "eQUAD step 4 Gaming"; logi_hidpp_dev_conn_notif_equad(hdev, hidpp_report, &workitem); + workitem.reports_supported |= STD_KEYBOARD; break; case 0x08: device_type = "eQUAD step 4 for gamepads";