Message ID | 20210203131040.21656-1-colin.king@canonical.com |
---|---|
State | New |
Headers | show |
Series | [next] net: hns3: remove redundant null check of an array | expand |
Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The null check of filp->f_path.dentry->d_iname is redundant because > it is an array of DNAME_INLINE_LEN chars and cannot be a null. Fix > this by removing the null check. > > Addresses-Coverity: ("Array compared against 0") > Fixes: 04987ca1b9b6 ("net: hns3: add debugfs support for tm nodes, priority and qset info") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 3 Feb 2021 13:10:40 +0000 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > The null check of filp->f_path.dentry->d_iname is redundant because > it is an array of DNAME_INLINE_LEN chars and cannot be a null. Fix > this by removing the null check. > > Addresses-Coverity: ("Array compared against 0") > Fixes: 04987ca1b9b6 ("net: hns3: add debugfs support for tm nodes, priority and qset info") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > [...] Here is the summary with links: - [next] net: hns3: remove redundant null check of an array https://git.kernel.org/netdev/net-next/c/8f8a42ff003a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c b/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c index 6978304f1ac5..c5958754f939 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c @@ -494,9 +494,6 @@ static ssize_t hns3_dbg_read(struct file *filp, char __user *buffer, ssize_t size = 0; int ret = 0; - if (!filp->f_path.dentry->d_iname) - return -EINVAL; - read_buf = kzalloc(HNS3_DBG_READ_LEN, GFP_KERNEL); if (!read_buf) return -ENOMEM;