| Message ID | 20210203163407.9222-1-benl@squareup.com |
|---|---|
| Headers | show |
| Series | Clean up MSM8939 interconnect driver | expand |
'Benjamin Li' via square <square@linaro.org> 于2021年2月4日周四 上午12:34写道： > > Changes corresponding to commit c497f9322af9 ("interconnect: qcom: msm8916: > Remove rpm-ids from non-RPM nodes") to remove this log spam on 8939: > > [ 1.901376] qcom_icc_rpm_smd_send slv 24 error -6 > [ 2.005977] qcom_icc_rpm_smd_send mas 20 error -6 > [ 2.010250] qcom_icc_rpm_smd_send slv 20 error -6 > [ 2.014684] qcom_icc_rpm_smd_send slv 106 error -6 > [ 2.019338] qcom_icc_rpm_smd_send slv 107 error -6 > [ 2.024615] qcom_icc_rpm_smd_send slv 29 error -6 > [ 2.028782] qcom_icc_rpm_smd_send mas 3 error -6 > [ 2.034657] qcom_icc_rpm_smd_send mas 100 error -6 > (plus another slv 131 that's hidden by the mas 100 failure) > > Signed-off-by: Benjamin Li <benl@squareup.com> > --- Ben, Suggest to add comments to address the issue you fixed as commit c497f9322af does, at least a short version. So that people do not have to look into c497f9322af again. Regards, Jun
Following up on a review comment on commit 6c6fe5d3dc5e ("interconnect: qcom: Add MSM8939 interconnect provider driver") to clean up some log pollution. This is based on icc-next (which appears to contain a refactor commonizing functions into icc-rpm.c). Benjamin Li (2): interconnect: qcom: icc-rpm: record slave RPM id in error log interconnect: qcom: msm8939: remove rpm-ids from non-RPM nodes drivers/interconnect/qcom/icc-rpm.c | 4 ++-- drivers/interconnect/qcom/msm8939.c | 16 ++++++++-------- 2 files changed, 10 insertions(+), 10 deletions(-) -- 2.17.1