| Message ID | cover.1598331148.git.joe@perches.com |
|---|---|
| Headers | show |
| Series | treewide: Convert comma separated statements | expand |
Hello Joe, On Wed, 26 Aug 2020 at 20:38, Christian König <christian.koenig@amd.com> wrote: > > Am 25.08.20 um 06:56 schrieb Joe Perches: > > Use semicolons and braces. > > > > Signed-off-by: Joe Perches <joe@perches.com> > > Acked-by: Christian König <christian.koenig@amd.com> FWIW, Acked-by: Sumit Semwal <sumit.semwal@linaro.org> > > > --- > > drivers/dma-buf/st-dma-fence.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c > > index e593064341c8..c8a12d7ad71a 100644 > > --- a/drivers/dma-buf/st-dma-fence.c > > +++ b/drivers/dma-buf/st-dma-fence.c > > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg) > > dma_fence_signal(f1); > > > > smp_store_mb(cb.seen, false); > > - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback)) > > - miss++, cb.seen = true; > > + if (!f2 || > > + dma_fence_add_callback(f2, &cb.cb, simple_callback)) { > > + miss++; > > + cb.seen = true; > > + } > > > > if (!t->before) > > dma_fence_signal(f1); >
Hi Joe, Nice, I only see three of these on the linux-media list, so I'll only look at those, but I'm pleased to see this is treewide ;-) Definitely prefer this. On 25/08/2020 05:56, Joe Perches wrote: > Use semicolons and braces. > > Signed-off-by: Joe Perches <joe@perches.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/dma-buf/st-dma-fence.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c > index e593064341c8..c8a12d7ad71a 100644 > --- a/drivers/dma-buf/st-dma-fence.c > +++ b/drivers/dma-buf/st-dma-fence.c > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg) > dma_fence_signal(f1); > > smp_store_mb(cb.seen, false); > - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback)) > - miss++, cb.seen = true; > + if (!f2 || > + dma_fence_add_callback(f2, &cb.cb, simple_callback)) { > + miss++; > + cb.seen = true; > + } > > if (!t->before) > dma_fence_signal(f1); >
On 25/08/2020 05:56, Joe Perches wrote: > Use semicolons and braces. > > Signed-off-by: Joe Perches <joe@perches.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/staging/media/atomisp/pci/atomisp_subdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c b/drivers/staging/media/atomisp/pci/atomisp_subdev.c > index 6ba817f15655..52b9fb18c87f 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_subdev.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_subdev.c > @@ -410,8 +410,10 @@ int atomisp_subdev_set_selection(struct v4l2_subdev *sd, > > if (atomisp_subdev_format_conversion(isp_sd, > isp_sd->capture_pad) > - && crop[pad]->width && crop[pad]->height) > - crop[pad]->width -= padding_w, crop[pad]->height -= padding_h; > + && crop[pad]->width && crop[pad]->height) { > + crop[pad]->width -= padding_w; > + crop[pad]->height -= padding_h; > + } > > /* if subdev type is SOC camera,we do not need to set DVS */ > if (isp->inputs[isp_sd->input_curr].type == SOC_CAMERA) >
On Mon, 24 Aug 2020 21:55:57 -0700, Joe Perches wrote: > There are many comma separated statements in the kernel. > See:https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/ > > Convert the comma separated statements that are in if/do/while blocks > to use braces and semicolons. > > Many comma separated statements still exist but those are changes for > another day. > > [...] Applied to 5.10/scsi-queue, thanks! [01/29] coding-style.rst: Avoid comma statements (no commit info) [02/29] alpha: Avoid comma separated statements (no commit info) [03/29] ia64: Avoid comma separated statements (no commit info) [04/29] sparc: Avoid comma separated statements (no commit info) [05/29] ata: Avoid comma separated statements (no commit info) [06/29] drbd: Avoid comma separated statements (no commit info) [07/29] lp: Avoid comma separated statements (no commit info) [08/29] dma-buf: Avoid comma separated statements (no commit info) [09/29] drm/gma500: Avoid comma separated statements (no commit info) [10/29] drm/i915: Avoid comma separated statements (no commit info) [11/29] hwmon: (scmi-hwmon): Avoid comma separated statements (no commit info) [12/29] Input: MT - Avoid comma separated statements (no commit info) [13/29] bcache: Avoid comma separated statements (no commit info) [14/29] media: Avoid comma separated statements (no commit info) [15/29] mtd: Avoid comma separated statements (no commit info) [16/29] 8390: Avoid comma separated statements (no commit info) [17/29] fs_enet: Avoid comma separated statements (no commit info) [18/29] wan: sbni: Avoid comma separated statements (no commit info) [19/29] s390/tty3270: Avoid comma separated statements (no commit info) [20/29] scsi: arm: Avoid comma separated statements https://git.kernel.org/mkp/scsi/c/a08a07326510 [21/29] media: atomisp: Avoid comma separated statements (no commit info) [22/29] video: fbdev: Avoid comma separated statements (no commit info) [23/29] fuse: Avoid comma separated statements (no commit info) [24/29] reiserfs: Avoid comma separated statements (no commit info) [25/29] lib/zlib: Avoid comma separated statements (no commit info) [26/29] lib: zstd: Avoid comma separated statements (no commit info) [27/29] ipv6: fib6: Avoid comma separated statements (no commit info) [28/29] sunrpc: Avoid comma separated statements (no commit info) [29/29] tools: Avoid comma separated statements (no commit info)
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. Ping? > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/dma-buf/st-dma-fence.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c > index e593064341c8..c8a12d7ad71a 100644 > --- a/drivers/dma-buf/st-dma-fence.c > +++ b/drivers/dma-buf/st-dma-fence.c > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg) > dma_fence_signal(f1); > > > smp_store_mb(cb.seen, false); > - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback)) > - miss++, cb.seen = true; > + if (!f2 || > + dma_fence_add_callback(f2, &cb.cb, simple_callback)) { > + miss++; > + cb.seen = true; > + } > > > if (!t->before) > dma_fence_signal(f1);
On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote: > Am 30.01.21 um 19:47 schrieb Joe Perches: > > On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > > > Use semicolons and braces. > > Ping? > > > Signed-off-by: Joe Perches <joe@perches.com> > Reviewed-by: Christian König <christian.koenig@amd.com> > > Do you have commit rights to drm-misc-next? No. > > > --- > > > drivers/dma-buf/st-dma-fence.c | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c > > > index e593064341c8..c8a12d7ad71a 100644 > > > --- a/drivers/dma-buf/st-dma-fence.c > > > +++ b/drivers/dma-buf/st-dma-fence.c > > > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg) > > > dma_fence_signal(f1); > > > > > > smp_store_mb(cb.seen, false); > > > - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback)) > > > - miss++, cb.seen = true; > > > + if (!f2 || > > > + dma_fence_add_callback(f2, &cb.cb, simple_callback)) { > > > + miss++; > > > + cb.seen = true; > > > + } > > > > > > if (!t->before) > > > dma_fence_signal(f1); > > >
Am 31.01.21 um 18:39 schrieb Joe Perches: > On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote: >> Am 30.01.21 um 19:47 schrieb Joe Perches: >>> On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: >>>> Use semicolons and braces. >>> Ping? >>>> Signed-off-by: Joe Perches <joe@perches.com> >> Reviewed-by: Christian König <christian.koenig@amd.com> >> >> Do you have commit rights to drm-misc-next? > No. Pushed. Thanks for the help, Christian. > >>>> --- >>>> drivers/dma-buf/st-dma-fence.c | 7 +++++-- >>>> 1 file changed, 5 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c >>>> index e593064341c8..c8a12d7ad71a 100644 >>>> --- a/drivers/dma-buf/st-dma-fence.c >>>> +++ b/drivers/dma-buf/st-dma-fence.c >>>> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg) >>>> dma_fence_signal(f1); >>>> >>>> smp_store_mb(cb.seen, false); >>>> - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback)) >>>> - miss++, cb.seen = true; >>>> + if (!f2 || >>>> + dma_fence_add_callback(f2, &cb.cb, simple_callback)) { >>>> + miss++; >>>> + cb.seen = true; >>>> + } >>>> >>>> if (!t->before) >>>> dma_fence_signal(f1); >
On Tue, 2021-02-02 at 09:33 +0100, Christian König wrote: > Yeah, known issue. > > An NTP server which I don't have access to has gone bananas and > sometimes spits out invalid time stamps. > > Only thing I can do is wait for an admin to take care of this. haha it's ok! I just thought it was mildly entertaining to see, as my email client formatted the message timestamp "Next Wednesday" :) > > Christian. > > Am 01.02.21 um 22:54 schrieb Lyude Paul: > > This is entirely unrelated to this thread, but I noticed when going through > > dri- > > devel that this email is somehow dated two days in the future from now. > > > > On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote: > > > Am 30.01.21 um 19:47 schrieb Joe Perches: > > > > On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > > > > > Use semicolons and braces. > > > > Ping? > > > > > > > > > Signed-off-by: Joe Perches <joe@perches.com> > > > Reviewed-by: Christian König <christian.koenig@amd.com> > > > > > > Do you have commit rights to drm-misc-next? > > > > > > > > --- > > > > > drivers/dma-buf/st-dma-fence.c | 7 +++++-- > > > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma- > > > > > fence.c > > > > > index e593064341c8..c8a12d7ad71a 100644 > > > > > --- a/drivers/dma-buf/st-dma-fence.c > > > > > +++ b/drivers/dma-buf/st-dma-fence.c > > > > > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg) > > > > > dma_fence_signal(f1); > > > > > > > > > > > > > > > smp_store_mb(cb.seen, false); > > > > > - if (!f2 || dma_fence_add_callback(f2, &cb.cb, > > > > > simple_callback)) > > > > > - miss++, cb.seen = true; > > > > > + if (!f2 || > > > > > + dma_fence_add_callback(f2, &cb.cb, > > > > > simple_callback)) { > > > > > + miss++; > > > > > + cb.seen = true; > > > > > + } > > > > > > > > > > > > > > > if (!t->before) > > > > > dma_fence_signal(f1); > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel >
Am 30.01.21 um 19:47 schrieb Joe Perches: > On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: >> Use semicolons and braces. > Ping? > >> Signed-off-by: Joe Perches <joe@perches.com> Reviewed-by: Christian König <christian.koenig@amd.com> Do you have commit rights to drm-misc-next? >> --- >> drivers/dma-buf/st-dma-fence.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c >> index e593064341c8..c8a12d7ad71a 100644 >> --- a/drivers/dma-buf/st-dma-fence.c >> +++ b/drivers/dma-buf/st-dma-fence.c >> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg) >> dma_fence_signal(f1); >> >> >> smp_store_mb(cb.seen, false); >> - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback)) >> - miss++, cb.seen = true; >> + if (!f2 || >> + dma_fence_add_callback(f2, &cb.cb, simple_callback)) { >> + miss++; >> + cb.seen = true; >> + } >> >> >> if (!t->before) >> dma_fence_signal(f1); >