diff mbox series

[v1] scsi: lpfc: Add auto select on IRQ_POLL

Message ID 20210126000554.309858-1-ztong0001@gmail.com
State New
Headers show
Series [v1] scsi: lpfc: Add auto select on IRQ_POLL | expand

Commit Message

Tong Zhang Jan. 26, 2021, 12:05 a.m. UTC
lpfc depends on irq_poll library, but it is not selected automatically.
When irq_poll is not selected, compiling it can run into following error

ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!

Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
 drivers/scsi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

James Smart Jan. 26, 2021, 1:25 p.m. UTC | #1
On 1/25/2021 4:05 PM, Tong Zhang wrote:
> lpfc depends on irq_poll library, but it is not selected automatically.

> When irq_poll is not selected, compiling it can run into following error

>

> ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!

> ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!

> ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!

>

> Signed-off-by: Tong Zhang <ztong0001@gmail.com>

> ---

>   drivers/scsi/Kconfig | 1 +

>   1 file changed, 1 insertion(+)

>

> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig

> index 701b61ec76ee..c79ac0731b13 100644

> --- a/drivers/scsi/Kconfig

> +++ b/drivers/scsi/Kconfig

> @@ -1159,6 +1159,7 @@ config SCSI_LPFC

>   	depends on NVME_TARGET_FC || NVME_TARGET_FC=n

>   	depends on NVME_FC || NVME_FC=n

>   	select CRC_T10DIF

> +	select IRQ_POLL

>   	help

>             This lpfc driver supports the Emulex LightPulse

>             Family of Fibre Channel PCI host adapters.


Reviewed-by: James Smart <jsmart2021@gmail.com>


-- james
Martin K. Petersen Jan. 27, 2021, 3:12 a.m. UTC | #2
Tong,

> lpfc depends on irq_poll library, but it is not selected

> automatically.  When irq_poll is not selected, compiling it can run

> into following error


Applied to 5.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Martin K. Petersen Jan. 29, 2021, 7:01 p.m. UTC | #3
On Mon, 25 Jan 2021 19:05:54 -0500, Tong Zhang wrote:

> lpfc depends on irq_poll library, but it is not selected automatically.

> When irq_poll is not selected, compiling it can run into following error

> 

> ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!

> ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!

> ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!


Applied to 5.12/scsi-queue, thanks!

[1/1] scsi: lpfc: Add auto select on IRQ_POLL
      https://git.kernel.org/mkp/scsi/c/fad0a16130b6

-- 
Martin K. Petersen	Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 701b61ec76ee..c79ac0731b13 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1159,6 +1159,7 @@  config SCSI_LPFC
 	depends on NVME_TARGET_FC || NVME_TARGET_FC=n
 	depends on NVME_FC || NVME_FC=n
 	select CRC_T10DIF
+	select IRQ_POLL
 	help
           This lpfc driver supports the Emulex LightPulse
           Family of Fibre Channel PCI host adapters.