| Message ID | 20201001163429.1348-1-luoyonggang@gmail.com |
|---|---|
| Headers | show |
| Series | Enable plugin support on msys2/mingw | expand |
Yonggang Luo <luoyonggang@gmail.com> writes: > V2-V3 > Split following patches out > > V1-V2 > 1. Fixes review comments > 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0 > 3. Revise the loader to support for version 0 and 1 > 4. By export function qemu_plugin_initialize in plugin, and call it in loader= > , so > we have no need call it in every plugin. And also provide a standard implem= > entation, > anyway, use can also override it. > > Add this feature on msys2/mingw by using glib provided cross-platform dlsym f= > unctional. I've grabbed the first two fixes into plugins/next for now. Aside from fixing the review comments I'd like to have an indication that the proposed change to the API linking doesn't adversely affect the performance of the plugins. It might be worth enabling a --enable-plugins build for mingw gitlab as Cirrus seems a bit broken at the moment. Thanks, -- Alex Bennée
Hi alex, when does plugins/next getting PR On Tue, Oct 6, 2020 at 7:35 PM Alex Bennée <alex.bennee@linaro.org> wrote: > > Yonggang Luo <luoyonggang@gmail.com> writes: > > > V2-V3 > > Split following patches out > > > > V1-V2 > > 1. Fixes review comments > > 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0 > > 3. Revise the loader to support for version 0 and 1 > > 4. By export function qemu_plugin_initialize in plugin, and call it in > loader= > > , so > > we have no need call it in every plugin. And also provide a standard > implem= > > entation, > > anyway, use can also override it. > > > > Add this feature on msys2/mingw by using glib provided cross-platform > dlsym f= > > unctional. > > I've grabbed the first two fixes into plugins/next for now. Aside from > fixing the review comments I'd like to have an indication that the > proposed change to the API linking doesn't adversely affect the > performance of the plugins. > > It might be worth enabling a --enable-plugins build for mingw gitlab as > Cirrus > seems a bit broken at the moment. > > Thanks, > > > -- > Alex Bennée > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo <div dir="ltr">Hi alex, when does plugins/next getting PR</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 6, 2020 at 7:35 PM Alex Bennée <<a href="mailto:alex.bennee@linaro.org">alex.bennee@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> Yonggang Luo <<a href="mailto:luoyonggang@gmail.com" target="_blank">luoyonggang@gmail.com</a>> writes:<br> <br> > V2-V3<br> > Split following patches out<br> ><br> > V1-V2<br> > 1. Fixes review comments<br> > 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0<br> > 3. Revise the loader to support for version 0 and 1<br> > 4. By export function qemu_plugin_initialize in plugin, and call it in loader=<br> > , so<br> > we have no need call it in every plugin. And also provide a standard implem=<br> > entation,<br> > anyway, use can also override it.<br> ><br> > Add this feature on msys2/mingw by using glib provided cross-platform dlsym f=<br> > unctional.<br> <br> I've grabbed the first two fixes into plugins/next for now. Aside from<br> fixing the review comments I'd like to have an indication that the<br> proposed change to the API linking doesn't adversely affect the<br> performance of the plugins.<br> <br> It might be worth enabling a --enable-plugins build for mingw gitlab as Cirrus<br> seems a bit broken at the moment.<br> <br> Thanks,<br> <br> <br> -- <br> Alex Bennée<br> </blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"> 此致<br>礼<br>罗勇刚<br>Yours<br> sincerely,<br>Yonggang Luo<br></div>
罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> writes: > Hi alex, when does plugins/next getting PR Sorry for the delay. I should be cooking up a pre-PR series this week once the recent icount/io_recompile fix has been tested and reviewed. You can see the current state of the tree here: https://github.com/stsquad/qemu/tree/plugins/next I'm afraid I've dropped the ball on your plugin patches... I can't seem to find the v5 series referenced. > > On Tue, Oct 6, 2020 at 7:35 PM Alex Bennée <alex.bennee@linaro.org> wrote: > >> >> Yonggang Luo <luoyonggang@gmail.com> writes: >> >> > V2-V3 >> > Split following patches out >> > >> > V1-V2 >> > 1. Fixes review comments >> > 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0 >> > 3. Revise the loader to support for version 0 and 1 >> > 4. By export function qemu_plugin_initialize in plugin, and call it in >> loader= >> > , so >> > we have no need call it in every plugin. And also provide a standard >> implem= >> > entation, >> > anyway, use can also override it. >> > >> > Add this feature on msys2/mingw by using glib provided cross-platform >> dlsym f= >> > unctional. >> >> I've grabbed the first two fixes into plugins/next for now. Aside from >> fixing the review comments I'd like to have an indication that the >> proposed change to the API linking doesn't adversely affect the >> performance of the plugins. >> >> It might be worth enabling a --enable-plugins build for mingw gitlab as >> Cirrus >> seems a bit broken at the moment. >> >> Thanks, >> >> >> -- >> Alex Bennée >> -- Alex Bennée
V2-V3 Split following patches out V1-V2 1. Fixes review comments 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0 3. Revise the loader to support for version 0 and 1 4. By export function qemu_plugin_initialize in plugin, and call it in loader= , so we have no need call it in every plugin. And also provide a standard implem= entation, anyway, use can also override it. Add this feature on msys2/mingw by using glib provided cross-platform dlsym f= unctional. Yonggang Luo (6): plugins: Fixes a issue when dlsym failed, the handle not closed plugin: Fixes compiling errors on msys2/mingw cirrus: Enable plugin in cirrus for windows plugin: define QEMU_PLUGIN_API_IMPLEMENTATION first plugin: getting qemu_plugin_get_hwaddr only expose one function prototype plugin: Getting qemu-plugin works under win32. .cirrus.yml | 3 +- Makefile | 1 - configure | 71 ------------- contrib/plugins/hotblocks.c | 3 +- contrib/plugins/hotpages.c | 1 + contrib/plugins/howvec.c | 1 + contrib/plugins/lockstep.c | 1 + include/qemu/qemu-plugin.h | 197 +++++++++++++++++++++++++++-------- meson.build | 6 +- plugins/api.c | 71 +++++++------ plugins/core.c | 11 +- plugins/loader.c | 51 ++++++++- plugins/meson.build | 10 +- plugins/plugin.h | 1 + plugins/qemu-plugins.symbols | 40 ------- tests/plugin/bb.c | 5 +- tests/plugin/empty.c | 1 + tests/plugin/insn.c | 1 + tests/plugin/mem.c | 1 + 19 files changed, 262 insertions(+), 214 deletions(-) delete mode 100644 plugins/qemu-plugins.symbols --=20 2.28.0.windows.1