Message ID | 20210115190936.26148-1-dwagner@suse.de |
---|---|
Headers | show |
Series | Generate machine-readable output | expand |
On Fri, 15 Jan 2021, Daniel Wagner wrote: > This variables is updated by the result of > sched_get_priority_min(). Hence, it can't be const. > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > src/pi_tests/pip_stress.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/pi_tests/pip_stress.c b/src/pi_tests/pip_stress.c > index 4583aa40a6b8..8b91578f9ab8 100644 > --- a/src/pi_tests/pip_stress.c > +++ b/src/pi_tests/pip_stress.c > @@ -65,7 +65,7 @@ struct State { > struct State *statep; > > const int policy = SCHED_FIFO; > -const int prio_min; /* Initialized for the minimum priority of policy */ > +static int prio_min; /* Initialized for the minimum priority of policy */ > > static void usage(int error) > { > -- > 2.29.2 > > Signed-off-by: John Kacur <jkacur@redhat.com>
On Fri, 15 Jan 2021, Daniel Wagner wrote: > Instead always return success, use the provided exist code. > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > src/ptsematest/ptsematest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ptsematest/ptsematest.c b/src/ptsematest/ptsematest.c > index 2e392299fdc4..f8f075591f4b 100644 > --- a/src/ptsematest/ptsematest.c > +++ b/src/ptsematest/ptsematest.c > @@ -164,7 +164,7 @@ static void display_help(int error) > " without NUM, threads = max_cpus\n" > " without -t default = 1\n" > ); > - exit(0); > + exit(error); > } > > > -- > 2.29.2 > > Signed-off-by: John Kacur <jkacur@redhat.com>
On Fri, 15 Jan 2021, Daniel Wagner wrote: > When adding long command line options support the --step > argument was missed out. Add it back. > > Fixes: 9723329835b3 ("cyclicdeadline: Add long command line options") > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > src/sched_deadline/cyclicdeadline.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c > index 19a7fcb6c488..cd12c7f313c2 100644 > --- a/src/sched_deadline/cyclicdeadline.c > +++ b/src/sched_deadline/cyclicdeadline.c > @@ -1013,11 +1013,12 @@ int main(int argc, char **argv) > { "duration", required_argument, NULL, 'D' }, > { "help", no_argument, NULL, 'h' }, > { "interval", required_argument, NULL, 'i' }, > + { "step", required_argument, NULL, 's' }, > { "threads", required_argument, NULL, 't' }, > { "quiet", no_argument, NULL, 'q' }, > { NULL, 0, NULL, 0 }, > }; > - c = getopt_long(argc, argv, "a::c:D:hi:t:q", options, NULL); > + c = getopt_long(argc, argv, "a::c:D:hi:s:t:q", options, NULL); > if (c == -1) > break; > switch (c) { > -- > 2.29.2 > > Signed-off-by: John Kacur <jkacur@redhat.com>
On Fri, 15 Jan 2021, Daniel Wagner wrote: > There is no user for this data struct. Remove it. > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > src/sched_deadline/cyclicdeadline.c | 17 ----------------- > 1 file changed, 17 deletions(-) > > diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c > index cd12c7f313c2..71cde5781499 100644 > --- a/src/sched_deadline/cyclicdeadline.c > +++ b/src/sched_deadline/cyclicdeadline.c > @@ -47,23 +47,6 @@ typedef unsigned long long u64; > typedef unsigned int u32; > typedef int s32; > > -/* Struct to transfer parameters to the thread */ > -struct thread_param { > - u64 runtime_us; > - u64 deadline_us; > - > - int mode; > - int timermode; > - int signal; > - int clock; > - unsigned long max_cycles; > - struct thread_stat *stats; > - unsigned long interval; > - int cpu; > - int node; > - int tnum; > -}; > - > /* Struct for statistics */ > struct thread_stat { > unsigned long cycles; > -- > 2.29.2 > > Signed-off-by: John Kacur <jkacur@redhat.com>