diff mbox series

Bluetooth: drop HCI device reference before return

Message ID 20210121073419.14219-1-bianpan2016@163.com
State New
Headers show
Series Bluetooth: drop HCI device reference before return | expand

Commit Message

Pan Bian Jan. 21, 2021, 7:34 a.m. UTC 
Call hci_dev_put() to decrement reference count of HCI device hdev if
fails to duplicate memory.

Fixes: 0b26ab9dce74 ("Bluetooth: AMP: Handle Accept phylink command status evt")
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 net/bluetooth/a2mp.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Marcel Holtmann Jan. 25, 2021, 3:14 p.m. UTC | #1 
Hi Pan,

> Call hci_dev_put() to decrement reference count of HCI device hdev if

> fails to duplicate memory.

> 

> Fixes: 0b26ab9dce74 ("Bluetooth: AMP: Handle Accept phylink command status evt")

> Signed-off-by: Pan Bian <bianpan2016@163.com>

> ---

> net/bluetooth/a2mp.c | 1 +

> 1 file changed, 1 insertion(+)


patch has been applied to bluetooth-next tree.

Regards

Marcel
diff mbox series

Patch

diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c
index da7fd7c8c2dc..5974fd828c35 100644
--- a/net/bluetooth/a2mp.c
+++ b/net/bluetooth/a2mp.c
@@ -512,6 +512,7 @@  static int a2mp_createphyslink_req(struct amp_mgr *mgr, struct sk_buff *skb,
 		assoc = kmemdup(req->amp_assoc, assoc_len, GFP_KERNEL);
 		if (!assoc) {
 			amp_ctrl_put(ctrl);
+			hci_dev_put(hdev);
 			return -ENOMEM;
 		}