mbox series

[RFC,v5,0/2] audio jack software injection

Message ID 20210122082144.16186-1-hui.wang@canonical.com
Headers show
Series audio jack software injection | expand

Message

Hui Wang Jan. 22, 2021, 8:21 a.m. UTC 
the changes in the v5:
 - add a Kconfig to enable/disable the jack injection feature
 - replace all kzalloc with local char[] in the debugfs fops
 - replace the chars of !isalnum() to '_' for the jack folder's name
 - squash all .c files patches into one patch
 - add a document to explain jack injection, for easier review, put
   the document in a standalone patch. If needed, will squash this
   patch to the previous one.
 

the changes in the v4:
 - change the sound-core to sound and change the sound_core_debugfs_root
   to sound_debugfs_root in the 0001-xxx.patch
 - change kzalloc/kfree to kvzalloc/kvfree in the debugfs fops for
   0001-xxx.patch and 0003-xxx.patch
 - And if needed, I could squash 4 patches into 1 patch before merging.

the changes in the v3 (for easy to review, divide change into 4 patches):
 - address the comment about the snd_jack_report() and _snd_jack_report(),
   the v2 design is hard to understand and is hard to review, in the v3,
   separate the jack_report to snd_jack_report() and snd_jack_inject_report(),
   hw jack events call snd_jack_report() as before, if a jack contains multi
   jack_kctl and the jack_kctl's sw_inject is enabled, the status and the
   related input-dev's events will not be reproted. The injection events call
   snd_jack_inject_report(). This change is squashed to 0001-xxx.patch,  the
   rest part of 0001-xxx.patch is same as v2.

 - address the comment about folders'name in the 0002-xxx.patch, so far, drop
   the '/', ',', '=' and ' ' from the folders' name.

 - address the comment about adding more debugfs nodes in the 0003-xxx.patch,
   it adds kctl_id, mask_bits, status and type.

 - address the comment about save-n-restore jack's hw status in the
   0004-xxx.patch, adding a hw_status_cache and save the last reported jack
   hw event, once the sw_inject is disabled, will restore all jack_kctl's
   state under the same snd_jack with hw_status_cache.
[snip]


the changes in the V2:
 - using debugfs instead of sysfs
 - using jack_ctrl to create a folder instead of snd_jack, since ASoC drivers
   could create multi jack_ctrls within a snd_jack
 - create a folder for each jack_ctrl instead for all jack_ctrls
[ snip ]


Hui Wang (2):
  alsa: jack: implement software jack injection via debugfs
  alsa: jack: add document for sound jack injection.

 Documentation/sound/designs/index.rst         |   1 +
 .../sound/designs/jack-injection.rst          | 124 ++++++++
 include/sound/core.h                          |   2 +
 include/sound/jack.h                          |   1 +
 sound/core/Kconfig                            |   9 +
 sound/core/init.c                             |  10 +
 sound/core/jack.c                             | 298 +++++++++++++++++-
 sound/core/sound.c                            |   8 +
 8 files changed, 449 insertions(+), 4 deletions(-)
 create mode 100644 Documentation/sound/designs/jack-injection.rst

Comments

Jaroslav Kysela Jan. 22, 2021, 8:40 a.m. UTC | #1 
Dne 22. 01. 21 v 9:21 Hui Wang napsal(a):

> +	len = scnprintf(buf, 256, "0x%04x", mask_bits);

Use sizeof(buf) on all appropriate places. Also never use user space 'count'
variable for the stack buffer size.

				Jaroslav
Hui Wang Jan. 22, 2021, 1:41 p.m. UTC | #2 
On 1/22/21 4:40 PM, Jaroslav Kysela wrote:
> Dne 22. 01. 21 v 9:21 Hui Wang napsal(a):
>
>> +	len = scnprintf(buf, 256, "0x%04x", mask_bits);
> Use sizeof(buf) on all appropriate places. Also never use user space 'count'
> variable for the stack buffer size.
>
> 				Jaroslav

Oh, right, will use sizeof(buf).  Will not use 'count' for stack buffer 
size.

Thanks,

Hui.

>