| Message ID | 20210121045830.96928-1-bianpan2016@163.com |
|---|---|
| State | New |
| Headers | show |
| Series | net/mlx5e: free page before return | expand |
On Wed, Jan 20, 2021 at 08:58:30PM -0800, Pan Bian wrote: > Instead of directly return, goto the error handling label to free > allocated page. > > Fixes: 5f29458b77d5 ("net/mlx5e: Support dump callback in TX reporter") > Signed-off-by: Pan Bian <bianpan2016@163.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en/health.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On Thu, 2021-01-21 at 19:49 +0200, Leon Romanovsky wrote: > On Wed, Jan 20, 2021 at 08:58:30PM -0800, Pan Bian wrote: > > Instead of directly return, goto the error handling label to free > > allocated page. > > > > Fixes: 5f29458b77d5 ("net/mlx5e: Support dump callback in TX > > reporter") > > Signed-off-by: Pan Bian <bianpan2016@163.com> > > --- > > drivers/net/ethernet/mellanox/mlx5/core/en/health.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Applied to net-mlx5, Thanks!
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/health.c b/drivers/net/ethernet/mellanox/mlx5/core/en/health.c index 718f8c0a4f6b..84e501e057b4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/health.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/health.c @@ -273,7 +273,7 @@ int mlx5e_health_rsc_fmsg_dump(struct mlx5e_priv *priv, struct mlx5_rsc_key *key err = devlink_fmsg_binary_pair_nest_start(fmsg, "data"); if (err) - return err; + goto free_page; cmd = mlx5_rsc_dump_cmd_create(mdev, key); if (IS_ERR(cmd)) {
Instead of directly return, goto the error handling label to free allocated page. Fixes: 5f29458b77d5 ("net/mlx5e: Support dump callback in TX reporter") Signed-off-by: Pan Bian <bianpan2016@163.com> --- drivers/net/ethernet/mellanox/mlx5/core/en/health.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)