| Message ID | 20210120134357.1522254-1-robert.foss@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,01/22] media: camss: Fix vfe_isr_comp_done() documentation | expand |
On Wed, 20 Jan 2021 14:43:51 +0100, Robert Foss wrote: > Signed-off-by: Robert Foss <robert.foss@linaro.org> > --- > > Changes since v1: > - Laurent: Reworked driver to use dtschema > > .../bindings/media/qcom,sdm845-camss.yaml | 394 ++++++++++++++++++ > 1 file changed, 394 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml:394:1: [warning] too many blank lines (2 > 1) (empty-lines) dtschema/dtc warnings/errors: See https://patchwork.ozlabs.org/patch/1429446 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c index fae2b513b2f9..94c9ca7d5cbb 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe.c +++ b/drivers/media/platform/qcom/camss/camss-vfe.c @@ -1076,8 +1076,8 @@ static void vfe_isr_wm_done(struct vfe_device *vfe, u8 wm) spin_unlock_irqrestore(&vfe->output_lock, flags); } -/* - * vfe_isr_wm_done - Process composite image done interrupt +/** + * vfe_isr_comp_done() - Process composite image done interrupt * @vfe: VFE Device * @comp: Composite image id */
Function name is comment is wrong, and was changed to be the same as the actual function name. The comment was changed to kerneldoc format. Signed-off-by: Robert Foss <robert.foss@linaro.org> --- Changes since v1 - Bjorn: Fix function doc name & use kerneldoc format drivers/media/platform/qcom/camss/camss-vfe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0