Message ID | 20210120080522.471120-1-saravanak@google.com |
---|---|
Headers | show |
Series | of: property: Add fw_devlink support for more props | expand |
On Wed, Jan 20, 2021 at 12:05:20AM -0800, Saravana Kannan wrote: > To provide backward compatibility for boards that use deprecated DT > bindings, we need to add fw_devlink support for "gpio" and "gpios". > > Cc: linux-tegra <linux-tegra@vger.kernel.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > Tested-by: Jon Hunter <jonathanh@nvidia.com> > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > drivers/of/property.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) Reviewed-by: Thierry Reding <treding@nvidia.com>
On Wed, Jan 20, 2021 at 9:05 AM Saravana Kannan <saravanak@google.com> wrote: > To provide backward compatibility for boards that use deprecated DT > bindings, we need to add fw_devlink support for "gpio" and "gpios". You do some more stuff in the patch so describe that too. Especially the check for hogs and #gpio-cells. Describe why you do that. Maybe even with a comment in the code because I don't think everyone will understand. > + if (strcmp(prop_name, "gpio") && strcmp(prop_name, "gpios")) > + return NULL; This part is easy to understand. > + if (of_find_property(np, "gpio-hog", NULL)) > + return NULL; > + > + if (of_parse_phandle_with_args(np, prop_name, "#gpio-cells", index, > + &sup_args)) > + return NULL; This part is hard to understand. Insert comments and tell the reader of the code what is going on and why. Yours, Linus Walleij
On Thu, Jan 21, 2021 at 5:11 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Jan 20, 2021 at 9:05 AM Saravana Kannan <saravanak@google.com> wrote: > > > To provide backward compatibility for boards that use deprecated DT > > bindings, we need to add fw_devlink support for "gpio" and "gpios". > > You do some more stuff in the patch so describe that too. > Especially the check for hogs and #gpio-cells. > Describe why you do that. Maybe even with a comment in > the code because I don't think everyone will understand. Ack > > > + if (strcmp(prop_name, "gpio") && strcmp(prop_name, "gpios")) > > + return NULL; > > This part is easy to understand. > > > + if (of_find_property(np, "gpio-hog", NULL)) > > + return NULL; > > + > > + if (of_parse_phandle_with_args(np, prop_name, "#gpio-cells", index, > > + &sup_args)) > > + return NULL; > > This part is hard to understand. Insert comments and tell the reader > of the code what is going on and why. I assume the "hard to understand" part is the gpio-hog part? Because the last line is pretty straightforward -- it's returning the index-th phandle. Also, it's a copy-paste from the DEFINE_SIMPLE_PROP macro. -Saravana