diff mbox series

[v3,01/10] certs/blacklist: fix kernel doc interface issue

Message ID 20210114151909.2344974-2-mic@digikod.net
State Superseded
Headers show
Series Enable root to update the blacklist keyring | expand

Commit Message

Mickaël Salaün Jan. 14, 2021, 3:19 p.m. UTC 
From: Alex Shi <alex.shi@linux.alibaba.com>


certs/blacklist.c:84: warning: Function parameter or member 'hash' not
described in 'mark_hash_blacklisted'

Cc: David Woodhouse <dwmw2@infradead.org>
Cc: keyrings@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>

Signed-off-by: David Howells <dhowells@redhat.com>

Reviewed-by: Ben Boeckel <mathstuf@gmail.com>

Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>

---

Changes since v2:
* Cherry-pick patch from
  https://lore.kernel.org/lkml/2659836.1607940186@warthog.procyon.org.uk/
  to avoid future merge conflicts.
* Rearrange Signed-off-by and Reviewed-by order.
---
 certs/blacklist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.30.0

Comments

Jarkko Sakkinen Jan. 20, 2021, 3:39 a.m. UTC | #1 
On Thu, Jan 14, 2021 at 04:19:00PM +0100, Mickaël Salaün wrote:
> From: Alex Shi <alex.shi@linux.alibaba.com>

> 

> certs/blacklist.c:84: warning: Function parameter or member 'hash' not

> described in 'mark_hash_blacklisted'

> 

> Cc: David Woodhouse <dwmw2@infradead.org>

> Cc: keyrings@vger.kernel.org

> Cc: linux-kernel@vger.kernel.org

> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>

> Signed-off-by: David Howells <dhowells@redhat.com>

> Reviewed-by: Ben Boeckel <mathstuf@gmail.com>

> Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>


Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>


/Jarkko
diff mbox series

Patch

diff --git a/certs/blacklist.c b/certs/blacklist.c
index 6514f9ebc943..2719fb2fbc1c 100644
--- a/certs/blacklist.c
+++ b/certs/blacklist.c
@@ -78,7 +78,7 @@  static struct key_type key_type_blacklist = {
 
 /**
  * mark_hash_blacklisted - Add a hash to the system blacklist
- * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
+ * @hash: The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
  */
 int mark_hash_blacklisted(const char *hash)
 {