| Message ID | 20210118024318.9530-2-nava.manne@xilinx.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] drivers: firmware: Add Pdi load API support | expand |
On 1/18/21 3:43 AM, Nava kishore Manne wrote: > From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com> > > This patch adds binding doc for versal fpga manager driver. > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> > Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com> > --- > .../bindings/fpga/xlnx,versal-fpga.yaml | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml > > diff --git a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml > new file mode 100644 > index 000000000000..cf3aa7917488 > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml > @@ -0,0 +1,33 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/fpga/xilinx/xlnx,versal-fpga.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx versal-fpga driver. > + > +maintainers: > + - Nava kishore Manne <nava.manne@xilinx.com> > + > +description: | > +Device Tree versal-fpga bindings for the Versal SOC, Controlled > +using Versal SoC firmware interface. > + > +properties: > + compatible: > + items: > + - enum: > + - xlnx,versal-fpga > + > +required: > + - compatible > + > +Required properties: > +- compatible: should contain "xlnx,versal-fpga" > + > +examples: > + - | > + versal_fpga: fpga { > + compatible = "xlnx,versal-fpga"; > + }; > There are issues with the binding Run make DT_SCHEMA_FILES=Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml dt_binding_check and fix ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:15:1: [error] syntax error: could not find expected ':' (syntax) and maybe others. Thanks, Michal
Hi Michal, Thanks for the review. Please find my response inline. > -----Original Message----- > From: Michal Simek <michal.simek@xilinx.com> > Sent: Monday, January 18, 2021 2:22 PM > To: Nava kishore Manne <navam@xilinx.com>; mdf@kernel.org; > trix@redhat.com; robh+dt@kernel.org; Michal Simek <michals@xilinx.com>; > linux-fpga@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Cc: git <git@xilinx.com>; chinnikishore369@gmail.com; Appana Durga > Kedareswara Rao <appanad@xilinx.com> > Subject: Re: [PATCH 2/3] dt-bindings: fpga: Add binding doc for versal fpga > manager > > > > On 1/18/21 3:43 AM, Nava kishore Manne wrote: > > From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com> > > > > This patch adds binding doc for versal fpga manager driver. > > > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> > > Signed-off-by: Appana Durga Kedareswara rao > > <appana.durga.rao@xilinx.com> > > --- > > .../bindings/fpga/xlnx,versal-fpga.yaml | 33 +++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml > > b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml > > new file mode 100644 > > index 000000000000..cf3aa7917488 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml > > @@ -0,0 +1,33 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > + > > +$id: http://devicetree.org/schemas/fpga/xilinx/xlnx,versal-fpga.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Xilinx versal-fpga driver. > > + > > +maintainers: > > + - Nava kishore Manne <nava.manne@xilinx.com> > > + > > +description: | > > +Device Tree versal-fpga bindings for the Versal SOC, Controlled using > > +Versal SoC firmware interface. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - xlnx,versal-fpga > > + > > +required: > > + - compatible > > + > > +Required properties: > > +- compatible: should contain "xlnx,versal-fpga" > > + > > +examples: > > + - | > > + versal_fpga: fpga { > > + compatible = "xlnx,versal-fpga"; > > + }; > > > > There are issues with the binding > Run > make > DT_SCHEMA_FILES=Documentation/devicetree/bindings/fpga/xlnx,versal- > fpga.yaml > dt_binding_check > Thanks for pointing it. Will fix in v2. > and fix > ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:15:1: > [error] syntax error: could not find expected ':' (syntax) and maybe others. > Will fix in v2. Regards, Navakishore.
diff --git a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml new file mode 100644 index 000000000000..cf3aa7917488 --- /dev/null +++ b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml @@ -0,0 +1,33 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/fpga/xilinx/xlnx,versal-fpga.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xilinx versal-fpga driver. + +maintainers: + - Nava kishore Manne <nava.manne@xilinx.com> + +description: | +Device Tree versal-fpga bindings for the Versal SOC, Controlled +using Versal SoC firmware interface. + +properties: + compatible: + items: + - enum: + - xlnx,versal-fpga + +required: + - compatible + +Required properties: +- compatible: should contain "xlnx,versal-fpga" + +examples: + - | + versal_fpga: fpga { + compatible = "xlnx,versal-fpga"; + };