diff mbox series

[2/3] cmd: Makefile: build nvedit.c when needed

Message ID 20201228121313.16520-2-peng.fan@oss.nxp.com
State New
Headers show
Series [1/3] common: Makefile: drop duplicated line | expand

Commit Message

Peng Fan (OSS) Dec. 28, 2020, 12:13 p.m. UTC 
From: Peng Fan <peng.fan@nxp.com>


No need to build nvedit.c when CONFIG_$(SPL_)ENV_SUPPORT is n

Signed-off-by: Peng Fan <peng.fan@nxp.com>

---
 cmd/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.28.0

Comments

Simon Glass Dec. 29, 2020, 3:32 a.m. UTC | #1 
On Mon, 28 Dec 2020 at 04:44, Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>

> From: Peng Fan <peng.fan@nxp.com>

>

> No need to build nvedit.c when CONFIG_$(SPL_)ENV_SUPPORT is n

>

> Signed-off-by: Peng Fan <peng.fan@nxp.com>

> ---

>  cmd/Makefile | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>


Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Jan. 17, 2021, 12:17 a.m. UTC | #2 
On Mon, Dec 28, 2020 at 08:13:12PM +0800, Peng Fan (OSS) wrote:

> From: Peng Fan <peng.fan@nxp.com>

> 

> No need to build nvedit.c when CONFIG_$(SPL_)ENV_SUPPORT is n

> 

> Signed-off-by: Peng Fan <peng.fan@nxp.com>

> Reviewed-by: Simon Glass <sjg@chromium.org>


This breaks a handful of PowerPC platforms that are using the original
SPL/etc setup and do make use of environment.

-- 
Tom
Peng Fan Jan. 17, 2021, 1:16 a.m. UTC | #3 
> Subject: Re: [PATCH 2/3] cmd: Makefile: build nvedit.c when needed

> 

> On Mon, Dec 28, 2020 at 08:13:12PM +0800, Peng Fan (OSS) wrote:

> 

> > From: Peng Fan <peng.fan@nxp.com>

> >

> > No need to build nvedit.c when CONFIG_$(SPL_)ENV_SUPPORT is n

> >

> > Signed-off-by: Peng Fan <peng.fan@nxp.com>

> > Reviewed-by: Simon Glass <sjg@chromium.org>

> 

> This breaks a handful of PowerPC platforms that are using the original SPL/etc

> setup and do make use of environment.


Ah, please drop it.

Thanks,
Peng.

> 

> --

> Tom
diff mbox series

Patch

diff --git a/cmd/Makefile b/cmd/Makefile
index dd86675bf2..2b2a0c26a6 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -201,7 +201,7 @@  endif # !CONFIG_SPL_BUILD
 obj-$(CONFIG_$(SPL_)CMD_TLV_EEPROM) += tlv_eeprom.o
 
 # core command
-obj-y += nvedit.o
+obj-$(CONFIG_$(SPL_)ENV_SUPPORT)+= nvedit.o
 
 obj-$(CONFIG_CMD_BCM_EXT_UTILS) += broadcom/