| Message ID | 20210113152630.28810-4-andre.przywara@arm.com |
|---|---|
| State | Accepted |
| Commit | 66a3cf5a25e2d62c8ff3b9344a50419379b01bc6 |
| Headers | show |
| Series | arm64: dts: allwinner: Various DT fixes | expand |
On 13.01.21 16:26, Andre Przywara wrote: > The Pine64-LTS board features a blue status LED on pin PL7. > > Describe it in the DT. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Hi, On Wed, Jan 13, 2021 at 03:26:25PM +0000, Andre Przywara wrote: > The Pine64-LTS board features a blue status LED on pin PL7. > > Describe it in the DT. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > .../boot/dts/allwinner/sun50i-a64-pine64-lts.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts > index 302e24be0a31..93d271fdbb6c 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts > @@ -1,10 +1,21 @@ > // SPDX-License-Identifier: (GPL-2.0+ OR MIT) > // Copyright (c) 2018 ARM Ltd. > > +#include <dt-bindings/leds/common.h> > #include "sun50i-a64-sopine-baseboard.dts" > > / { > model = "Pine64 LTS"; > compatible = "pine64,pine64-lts", "allwinner,sun50i-r18", > "allwinner,sun50i-a64"; > + > + led { > + compatible = "gpio-leds"; > + > + status { > + function = LED_FUNCTION_STATUS; > + color = <LED_COLOR_ID_BLUE>; > + gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */ > + }; Thanks for fixing the node names, but I guess my comment was a bit too vague: it's status that needed to be changed, not the upper level one. I've updated it while applying Maxime
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts index 302e24be0a31..93d271fdbb6c 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts @@ -1,10 +1,21 @@ // SPDX-License-Identifier: (GPL-2.0+ OR MIT) // Copyright (c) 2018 ARM Ltd. +#include <dt-bindings/leds/common.h> #include "sun50i-a64-sopine-baseboard.dts" / { model = "Pine64 LTS"; compatible = "pine64,pine64-lts", "allwinner,sun50i-r18", "allwinner,sun50i-a64"; + + led { + compatible = "gpio-leds"; + + status { + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_BLUE>; + gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */ + }; + }; };
The Pine64-LTS board features a blue status LED on pin PL7. Describe it in the DT. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- .../boot/dts/allwinner/sun50i-a64-pine64-lts.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)