| Message ID | 20210105175245.963451-1-alexander.deucher@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | ALSA: hda/hdmi - enable runtime pm for CI AMD display audio | expand |
On Tue, 05 Jan 2021 18:52:45 +0100, Alex Deucher wrote: > > We are able to power down the GPU and audio via the GPU driver > so flag these asics as supporting runtime pm. > > Reviewed-by: Evan Quan <evan.quan@amd.com> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> I wanted to apply this one now, but noticed that the author address (gmail) is different from your S-o-b address (amd.com). Alex, is this intentional and keep it, or should I correct the author address? thanks, Takashi > --- > sound/pci/hda/hda_intel.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index d539f52009a1..2ea46b5a9a23 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2597,7 +2597,8 @@ static const struct pci_device_id azx_ids[] = { > .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB }, > /* ATI HDMI */ > { PCI_DEVICE(0x1002, 0x0002), > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | > + AZX_DCAPS_PM_RUNTIME }, > { PCI_DEVICE(0x1002, 0x1308), > .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, > { PCI_DEVICE(0x1002, 0x157a), > @@ -2659,9 +2660,11 @@ static const struct pci_device_id azx_ids[] = { > { PCI_DEVICE(0x1002, 0xaab0), > .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, > { PCI_DEVICE(0x1002, 0xaac0), > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | > + AZX_DCAPS_PM_RUNTIME }, > { PCI_DEVICE(0x1002, 0xaac8), > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | > + AZX_DCAPS_PM_RUNTIME }, > { PCI_DEVICE(0x1002, 0xaad8), > .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | > AZX_DCAPS_PM_RUNTIME }, > -- > 2.29.2 >
On Tue, Jan 12, 2021 at 10:00 AM Takashi Iwai <tiwai@suse.de> wrote: > > On Tue, 05 Jan 2021 18:52:45 +0100, > Alex Deucher wrote: > > > > We are able to power down the GPU and audio via the GPU driver > > so flag these asics as supporting runtime pm. > > > > Reviewed-by: Evan Quan <evan.quan@amd.com> > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> > > I wanted to apply this one now, but noticed that the author address > (gmail) is different from your S-o-b address (amd.com). > Alex, is this intentional and keep it, or should I correct the author > address? The s-o-b address is the correct one. Thanks! Alex > > > thanks, > > Takashi > > > --- > > sound/pci/hda/hda_intel.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > > index d539f52009a1..2ea46b5a9a23 100644 > > --- a/sound/pci/hda/hda_intel.c > > +++ b/sound/pci/hda/hda_intel.c > > @@ -2597,7 +2597,8 @@ static const struct pci_device_id azx_ids[] = { > > .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB }, > > /* ATI HDMI */ > > { PCI_DEVICE(0x1002, 0x0002), > > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, > > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | > > + AZX_DCAPS_PM_RUNTIME }, > > { PCI_DEVICE(0x1002, 0x1308), > > .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, > > { PCI_DEVICE(0x1002, 0x157a), > > @@ -2659,9 +2660,11 @@ static const struct pci_device_id azx_ids[] = { > > { PCI_DEVICE(0x1002, 0xaab0), > > .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, > > { PCI_DEVICE(0x1002, 0xaac0), > > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, > > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | > > + AZX_DCAPS_PM_RUNTIME }, > > { PCI_DEVICE(0x1002, 0xaac8), > > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, > > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | > > + AZX_DCAPS_PM_RUNTIME }, > > { PCI_DEVICE(0x1002, 0xaad8), > > .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | > > AZX_DCAPS_PM_RUNTIME }, > > -- > > 2.29.2 > >
On Tue, 12 Jan 2021 16:03:41 +0100, Alex Deucher wrote: > > On Tue, Jan 12, 2021 at 10:00 AM Takashi Iwai <tiwai@suse.de> wrote: > > > > On Tue, 05 Jan 2021 18:52:45 +0100, > > Alex Deucher wrote: > > > > > > We are able to power down the GPU and audio via the GPU driver > > > so flag these asics as supporting runtime pm. > > > > > > Reviewed-by: Evan Quan <evan.quan@amd.com> > > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> > > > > I wanted to apply this one now, but noticed that the author address > > (gmail) is different from your S-o-b address (amd.com). > > Alex, is this intentional and keep it, or should I correct the author > > address? > > The s-o-b address is the correct one. Thanks! Alright, now applied. Thanks! Takashi
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index d539f52009a1..2ea46b5a9a23 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2597,7 +2597,8 @@ static const struct pci_device_id azx_ids[] = { .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB }, /* ATI HDMI */ { PCI_DEVICE(0x1002, 0x0002), - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | + AZX_DCAPS_PM_RUNTIME }, { PCI_DEVICE(0x1002, 0x1308), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, { PCI_DEVICE(0x1002, 0x157a), @@ -2659,9 +2660,11 @@ static const struct pci_device_id azx_ids[] = { { PCI_DEVICE(0x1002, 0xaab0), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, { PCI_DEVICE(0x1002, 0xaac0), - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | + AZX_DCAPS_PM_RUNTIME }, { PCI_DEVICE(0x1002, 0xaac8), - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | + AZX_DCAPS_PM_RUNTIME }, { PCI_DEVICE(0x1002, 0xaad8), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | AZX_DCAPS_PM_RUNTIME },