| Message ID | 20210111195553.3745008-1-atish.patra@wdc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | net: macb: Add default usrio config to default gem config | expand |
On Mon, 11 Jan 2021 11:55:53 -0800 Atish Patra wrote: > There is no usrio config defined for default gem config leading to > a kernel panic devices that don't define a data. This issue can be > reprdouced with microchip polar fire soc where compatible string > is defined as "cdns,macb". > > Fixes: edac63861db7 ("add userio bits as platform configuration") > > Signed-off-by: Atish Patra <atish.patra@wdc.com> Fixes tag needs work: Fixes tag: Fixes: edac63861db7 ("add userio bits as platform configuration") Has these problem(s): - empty line after the tag - Subject does not match target commit subject Just use git log -1 --format='Fixes: %h ("%s")' Please put [PATCH net] as subject prefix, to indicate this is a networking fix. You can also CC Andrew Lunn like get_maintainer.pl suggests, but drop linux-kernel from the CC/To.
On Mon, 2021-01-11 at 15:13 -0800, Jakub Kicinski wrote: > On Mon, 11 Jan 2021 11:55:53 -0800 Atish Patra wrote: > > There is no usrio config defined for default gem config leading to > > a kernel panic devices that don't define a data. This issue can be > > reprdouced with microchip polar fire soc where compatible string > > is defined as "cdns,macb". > > > > Fixes: edac63861db7 ("add userio bits as platform configuration") > > > > Signed-off-by: Atish Patra <atish.patra@wdc.com> > > Fixes tag needs work: > > Fixes tag: Fixes: edac63861db7 ("add userio bits as platform > configuration") > Has these problem(s): > - empty line after the tag > - Subject does not match target commit subject > Just use > git log -1 --format='Fixes: %h ("%s")' > > Please put [PATCH net] as subject prefix, to indicate this > is a networking fix. > > You can also CC Andrew Lunn like get_maintainer.pl suggests, > but drop linux-kernel from the CC/To. Done. Thanks for the feedback. -- Regards, Atish
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 814a5b10141d..47ee72ab7002 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4590,6 +4590,7 @@ static const struct macb_config default_gem_config = { .dma_burst_length = 16, .clk_init = macb_clk_init, .init = macb_init, + .usrio = &macb_default_usrio, .jumbo_max_len = 10240, };
There is no usrio config defined for default gem config leading to a kernel panic devices that don't define a data. This issue can be reprdouced with microchip polar fire soc where compatible string is defined as "cdns,macb". Fixes: edac63861db7 ("add userio bits as platform configuration") Signed-off-by: Atish Patra <atish.patra@wdc.com> --- drivers/net/ethernet/cadence/macb_main.c | 1 + 1 file changed, 1 insertion(+)