| Message ID | 20201123153148.52647-1-heikki.krogerus@linux.intel.com |
|---|---|
| Headers | show |
| Series | Remove one more platform_device_add_properties() call | expand |
On Mon, Nov 23, 2020 at 06:06:31PM +0100, Rafael J. Wysocki wrote: > On Mon, Nov 23, 2020 at 4:32 PM Heikki Krogerus > <heikki.krogerus@linux.intel.com> wrote: > > > > Hi, > > > > I originally introduced these as part of my series where I was > > proposing PM ops for software nodes [1], but since that still needs > > work, I'm sending these two separately. > > > > So basically I'm only modifying dwc3-pci.c so it registers a software > > node directly at this point. That will remove one more user of > > platform_device_add_properties(). > > > > [1] https://lore.kernel.org/lkml/20201029105941.63410-1-heikki.krogerus@linux.intel.com/ > > > > thanks, > > > > Heikki Krogerus (2): > > software node: Introduce device_add_software_node() > > usb: dwc3: pci: Register a software node for the dwc3 platform device > > > > drivers/base/swnode.c | 69 ++++++++++++++++++++++++++++++++----- > > drivers/usb/dwc3/dwc3-pci.c | 61 +++++++++++++++++++------------- > > include/linux/property.h | 3 ++ > > 3 files changed, 100 insertions(+), 33 deletions(-) > > > > -- > > These look good to me. > > If you want me to take them, though, I need an ACK from the dwc3 side. Btw, I have tested this on one of the platform with DWC3 and found no regression, so feel free to add Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Hi Felipe, On Mon, Nov 23, 2020 at 06:06:31PM +0100, Rafael J. Wysocki wrote: > On Mon, Nov 23, 2020 at 4:32 PM Heikki Krogerus > <heikki.krogerus@linux.intel.com> wrote: > > > > Hi, > > > > I originally introduced these as part of my series where I was > > proposing PM ops for software nodes [1], but since that still needs > > work, I'm sending these two separately. > > > > So basically I'm only modifying dwc3-pci.c so it registers a software > > node directly at this point. That will remove one more user of > > platform_device_add_properties(). > > > > [1] https://lore.kernel.org/lkml/20201029105941.63410-1-heikki.krogerus@linux.intel.com/ > > > > thanks, > > > > Heikki Krogerus (2): > > software node: Introduce device_add_software_node() > > usb: dwc3: pci: Register a software node for the dwc3 platform device > > > > drivers/base/swnode.c | 69 ++++++++++++++++++++++++++++++++----- > > drivers/usb/dwc3/dwc3-pci.c | 61 +++++++++++++++++++------------- > > include/linux/property.h | 3 ++ > > 3 files changed, 100 insertions(+), 33 deletions(-) > > > > -- > > These look good to me. > > If you want me to take them, though, I need an ACK from the dwc3 side. Is this OK? thanks, -- heikki
On Fri, Dec 04, 2020 at 01:23:22PM +0200, Heikki Krogerus wrote: > Hi Felipe, > > On Mon, Nov 23, 2020 at 06:06:31PM +0100, Rafael J. Wysocki wrote: > > On Mon, Nov 23, 2020 at 4:32 PM Heikki Krogerus > > <heikki.krogerus@linux.intel.com> wrote: > > > > > > Hi, > > > > > > I originally introduced these as part of my series where I was > > > proposing PM ops for software nodes [1], but since that still needs > > > work, I'm sending these two separately. > > > > > > So basically I'm only modifying dwc3-pci.c so it registers a software > > > node directly at this point. That will remove one more user of > > > platform_device_add_properties(). > > > > > > [1] https://lore.kernel.org/lkml/20201029105941.63410-1-heikki.krogerus@linux.intel.com/ > > > > > > thanks, > > > > > > Heikki Krogerus (2): > > > software node: Introduce device_add_software_node() > > > usb: dwc3: pci: Register a software node for the dwc3 platform device > > > > > > drivers/base/swnode.c | 69 ++++++++++++++++++++++++++++++++----- > > > drivers/usb/dwc3/dwc3-pci.c | 61 +++++++++++++++++++------------- > > > include/linux/property.h | 3 ++ > > > 3 files changed, 100 insertions(+), 33 deletions(-) > > > > > > -- > > > > These look good to me. > > > > If you want me to take them, though, I need an ACK from the dwc3 side. > > Is this OK? I think this went under you radar, so I'll resend these. Br, -- heikki