[v1,02/17] media: camss: Fix vfe_isr comment typo

Message ID	20210108120429.895046-3-robert.foss@linaro.org
State	Superseded
Headers	show Return-Path: <linux-arm-msm-owner@kernel.org> From: Robert Foss <robert.foss@linaro.org> To: agross@kernel.org, bjorn.andersson@linaro.org, robert.foss@linaro.org, todor.too@gmail.com, mchehab@kernel.org, robh+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, leoyang.li@nxp.com, geert+renesas@glider.be, arnd@arndb.de, Anson.Huang@nxp.com, michael@walle.cc, agx@sigxcpu.org, max.oss.09@gmail.com, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno <kholk11@gmail.com>, Andrey Konovalov <andrey.konovalov@linaro.org> Cc: Tomasz Figa <tfiga@chromium.org>, Azam Sadiq Pasha Kapatrala Syed <akapatra@quicinc.com>, Sarvesh Sridutt <Sarvesh.Sridutt@smartwirelesscompute.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Subject: [PATCH v1 02/17] media: camss: Fix vfe_isr comment typo Date: Fri, 8 Jan 2021 13:04:14 +0100 Message-Id: <20210108120429.895046-3-robert.foss@linaro.org> In-Reply-To: <20210108120429.895046-1-robert.foss@linaro.org> References: <20210108120429.895046-1-robert.foss@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Add support for SDM845 Camera Subsystem \| expand [v1,00/17] Add support for SDM845 Camera Subsystem [v1,01/17] media: camss: Fix comment using wrong function name [v1,02/17] media: camss: Fix vfe_isr comment typo [v1,03/17] media: camss: Add CAMSS_845 camss version [v1,04/17] media: camss: Make ISPIF subdevice optional [v1,07/17] media: camss: Add missing format identifiers [v1,08/17] media: camss: Refactor CSID HW version support [v1,09/17] media: camss: Add support for CSID hardware version Titan 170 [v1,11/17] media: camss: Remove per VFE power domain toggling [v1,12/17] media: dt-bindings: media: qcom,camss: Add bindings for SDM845 camss [v1,13/17] media: camss: Enable SDM845 [v1,14/17] arm64: defconfig: Build Qcom CAMSS as module [v1,15/17] arm64: dts: sdm845: Add CAMSS ISP node [v1,16/17] arm64: dts: sdm845-db845c: Add CAMSS ISP node

Message ID

20210108120429.895046-3-robert.foss@linaro.org

State

Superseded

Headers

From: Robert Foss <robert.foss@linaro.org>
To: agross@kernel.org, bjorn.andersson@linaro.org,
	robert.foss@linaro.org, todor.too@gmail.com, mchehab@kernel.org,
	robh+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org,
	shawnguo@kernel.org, leoyang.li@nxp.com, geert+renesas@glider.be,
	arnd@arndb.de, Anson.Huang@nxp.com, michael@walle.cc,
	agx@sigxcpu.org, max.oss.09@gmail.com,
	linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	AngeloGioacchino Del Regno <kholk11@gmail.com>,
	Andrey Konovalov <andrey.konovalov@linaro.org>
Cc: Tomasz Figa <tfiga@chromium.org>,
	Azam Sadiq Pasha Kapatrala Syed <akapatra@quicinc.com>,
	Sarvesh Sridutt <Sarvesh.Sridutt@smartwirelesscompute.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH v1 02/17] media: camss: Fix vfe_isr comment typo
Date: Fri,  8 Jan 2021 13:04:14 +0100
Message-Id: <20210108120429.895046-3-robert.foss@linaro.org>
In-Reply-To: <20210108120429.895046-1-robert.foss@linaro.org>
References: <20210108120429.895046-1-robert.foss@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

Add support for SDM845 Camera Subsystem | expand

Commit Message

Robert Foss Jan. 8, 2021, 12:04 p.m. UTC

Comment refers to ISPIF, but this is incorrect. Only
the VFE interrupts are handled by this function.

Signed-off-by: Robert Foss <robert.foss@linaro.org>
---
 drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 2 +-
 drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Bjorn Andersson Jan. 8, 2021, 6:51 p.m. UTC | #1

On Fri 08 Jan 06:04 CST 2021, Robert Foss wrote:

> Comment refers to ISPIF, but this is incorrect. Only
> the VFE interrupts are handled by this function.
> 
> Signed-off-by: Robert Foss <robert.foss@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
>  drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 2 +-
>  drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
> index 174a36be6f5d..a1b56b89130d 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
> @@ -922,7 +922,7 @@ static void vfe_violation_read(struct vfe_device *vfe)
>  }
>  
>  /*
> - * vfe_isr - ISPIF module interrupt handler
> + * vfe_isr - VFE module interrupt handler
>   * @irq: Interrupt line
>   * @dev: VFE device
>   *
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
> index b5704a2f119b..84c33b8f9fe3 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
> @@ -1055,7 +1055,7 @@ static void vfe_violation_read(struct vfe_device *vfe)
>  }
>  
>  /*
> - * vfe_isr - ISPIF module interrupt handler
> + * vfe_isr - VFE module interrupt handler
>   * @irq: Interrupt line
>   * @dev: VFE device
>   *
> -- 
> 2.27.0
>

Robert Foss Jan. 13, 2021, 10:04 a.m. UTC | #2

Thanks!

On Fri, 8 Jan 2021 at 19:51, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> On Fri 08 Jan 06:04 CST 2021, Robert Foss wrote:
>
> > Comment refers to ISPIF, but this is incorrect. Only
> > the VFE interrupts are handled by this function.
> >
> > Signed-off-by: Robert Foss <robert.foss@linaro.org>
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Regards,
> Bjorn
>
> > ---
> >  drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 2 +-
> >  drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
> > index 174a36be6f5d..a1b56b89130d 100644
> > --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
> > +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
> > @@ -922,7 +922,7 @@ static void vfe_violation_read(struct vfe_device *vfe)
> >  }
> >
> >  /*
> > - * vfe_isr - ISPIF module interrupt handler
> > + * vfe_isr - VFE module interrupt handler
> >   * @irq: Interrupt line
> >   * @dev: VFE device
> >   *
> > diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
> > index b5704a2f119b..84c33b8f9fe3 100644
> > --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
> > +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
> > @@ -1055,7 +1055,7 @@ static void vfe_violation_read(struct vfe_device *vfe)
> >  }
> >
> >  /*
> > - * vfe_isr - ISPIF module interrupt handler
> > + * vfe_isr - VFE module interrupt handler
> >   * @irq: Interrupt line
> >   * @dev: VFE device
> >   *
> > --
> > 2.27.0
> >

diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
index 174a36be6f5d..a1b56b89130d 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
@@ -922,7 +922,7 @@  static void vfe_violation_read(struct vfe_device *vfe)
 }
 
 /*
- * vfe_isr - ISPIF module interrupt handler
+ * vfe_isr - VFE module interrupt handler
  * @irq: Interrupt line
  * @dev: VFE device
  *
diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
index b5704a2f119b..84c33b8f9fe3 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
@@ -1055,7 +1055,7 @@  static void vfe_violation_read(struct vfe_device *vfe)
 }
 
 /*
- * vfe_isr - ISPIF module interrupt handler
+ * vfe_isr - VFE module interrupt handler
  * @irq: Interrupt line
  * @dev: VFE device
  *

[v1,02/17] media: camss: Fix vfe_isr comment typo

Commit Message

Comments

Patch