| Message ID | 20201227174202.40834-7-wsa+renesas@sang-engineering.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Hi Wolfram, On Sun, Dec 27, 2020 at 6:42 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > From: Takeshi Saito <takeshi.saito.xv@renesas.com> > > Enable MMC on the Falcon board. > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > [wsa: double checked & rebased] > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts > +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts > @@ -20,6 +20,24 @@ aliases { > chosen { > stdout-path = "serial0:115200n8"; > }; > + > + reg_1p8v: regulator0 { Please use a better node name, to avoid accidental duplicates, cfr. commit 45f5d5a9e34d3fe4 ("arm64: dts: renesas: r8a77995: draak: Fix backlight regulator name") > + compatible = "regulator-fixed"; > + regulator-name = "fixed-1.8V"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_3p3v: regulator1 { Likewise > + compatible = "regulator-fixed"; > + regulator-name = "fixed-3.3V"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > }; > > &avb0 { > @@ -169,6 +187,23 @@ &i2c6 { > clock-frequency = <100000>; > }; > > +&mmc0 { > + pinctrl-0 = <&mmc_pins>; > + pinctrl-1 = <&mmc_pins>; > + pinctrl-names = "default", "state_uhs"; > + > + vmmc-supply = <®_3p3v>; > + vqmmc-supply = <®_1p8v>; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > + bus-width = <8>; > + no-sd; > + no-sdio; I'm no expert on the no-sd{,io} properties. Just wondering if we need them on other R-Car gen3 boards with eMMC, too/ > + non-removable; > + full-pwr-cycle-in-suspend; > + status = "okay"; > +}; With the node names fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Wolfram, On Sun, Dec 27, 2020 at 6:42 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > From: Takeshi Saito <takeshi.saito.xv@renesas.com> > > Enable MMC on the Falcon board. > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > [wsa: double checked & rebased] > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > .../boot/dts/renesas/r8a779a0-falcon.dts | 41 +++++++++++++++++++ As the EMMC is part of the CPU board, it should be added to r8a779a0-falcon-cpu.dtsi instead of r8a779a0-falcon.dts. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> > + reg_1p8v: regulator0 { > > Please use a better node name, to avoid accidental duplicates, cfr. commit > 45f5d5a9e34d3fe4 ("arm64: dts: renesas: r8a77995: draak: Fix backlight > regulator name") Done. > > + no-sd; > > + no-sdio; > > I'm no expert on the no-sd{,io} properties. > Just wondering if we need them on other R-Car gen3 boards with eMMC, too/ Won't hurt. I'll prepare something... Thanks!
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts index 48801f2bdbe5..0c44466d398f 100644 --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts @@ -20,6 +20,24 @@ aliases { chosen { stdout-path = "serial0:115200n8"; }; + + reg_1p8v: regulator0 { + compatible = "regulator-fixed"; + regulator-name = "fixed-1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_3p3v: regulator1 { + compatible = "regulator-fixed"; + regulator-name = "fixed-3.3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; }; &avb0 { @@ -169,6 +187,23 @@ &i2c6 { clock-frequency = <100000>; }; +&mmc0 { + pinctrl-0 = <&mmc_pins>; + pinctrl-1 = <&mmc_pins>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <®_3p3v>; + vqmmc-supply = <®_1p8v>; + mmc-hs200-1_8v; + mmc-hs400-1_8v; + bus-width = <8>; + no-sd; + no-sdio; + non-removable; + full-pwr-cycle-in-suspend; + status = "okay"; +}; + &pfc { avb0_pins: avb0 { mux { @@ -307,6 +342,12 @@ i2c6_pins: i2c6 { groups = "i2c6"; function = "i2c6"; }; + + mmc_pins: mmc { + groups = "mmc_data8", "mmc_ctrl", "mmc_ds"; + function = "mmc"; + power-source = <1800>; + }; }; &rwdt {