| Message ID | 20210105140305.141401-1-tsbogend@alpha.franken.de |
|---|---|
| Headers | show |
| Series | Remove support for TX49xx | expand |
Hi Thomas, CC Nemoto-san (de-facto TX49XX maintainer) On Tue, Jan 5, 2021 at 3:03 PM Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote: > I couldn't find any buyable product other than reference boards using > TX49xx CPUs. And since nobody showed interest in keeping support for > it, it's time to remove it. I have an RBTX4927 development board in my board farm, boot-test every bi-weekly renesas-drivers release on it, and fix kernel issues when they appear. Is that sufficient to keep it? TX49xx SoCs were used in Sony LocationFree base stations, running VxWorks. You can no longer buy them. I'm not aware of anyone ever porting Linux to them. https://en.wikipedia.org/wiki/LocationFree_Player > spi: txx9: Remove driver I only noticed the planned removal when I saw the SPI patch was applied. Doesn't matter for me, as SPI is only present on TX4938, not on TX4927 ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wed, Jan 06, 2021 at 09:37:11AM +0100, Geert Uytterhoeven wrote: > Hi Thomas, > > CC Nemoto-san (de-facto TX49XX maintainer) > > On Tue, Jan 5, 2021 at 3:03 PM Thomas Bogendoerfer > <tsbogend@alpha.franken.de> wrote: > > I couldn't find any buyable product other than reference boards using > > TX49xx CPUs. And since nobody showed interest in keeping support for > > it, it's time to remove it. > > I have an RBTX4927 development board in my board farm, boot-test every > bi-weekly renesas-drivers release on it, and fix kernel issues when they > appear. > > Is that sufficient to keep it? for me it is. But now we probaly need some reverts then... I wonder whether you have seen my mail about the removal https://lore.kernel.org/linux-mips/20201207105627.GA15866@alpha.franken.de and my call for people owning MIPS machines https://lore.kernel.org/linux-mips/20200227144910.GA25011@alpha.franken.de/ Still "unclaimed" machines are IMG Pistachio SoC based boards (MACH_PISTACHIO( Toshiba TX39 series based machines (MACH_TX39XX) NEC VR4100 series based machines (MACH_VR41XX) Netlogic XLR/XLS based systems (NLM_XLR_BOARD) Netlogic XLP based systems (NLM_XLP_BOARD) Sibyte BCM91120C-CRhine (SIBYTE_CRHINE) Sibyte BCM91120x-Carmel (SIBYTE_CARMEL) Sibyte BCM91125C-CRhone (SIBYTE_CRHONE) Sibyte BCM91125E-Rhone (SIBYTE_RHONE) Sibyte BCM91250C2-LittleSur (SIBYTE_LITTLESUR) Sibyte BCM91250E-Sentosa (SIBYTE_SENTOSA) Is there something on this list you also regulary use ? Thomas.
Hi Thomas, On Wed, Jan 6, 2021 at 7:49 PM Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote: > On Wed, Jan 06, 2021 at 09:37:11AM +0100, Geert Uytterhoeven wrote: > > On Tue, Jan 5, 2021 at 3:03 PM Thomas Bogendoerfer > > <tsbogend@alpha.franken.de> wrote: > > > I couldn't find any buyable product other than reference boards using > > > TX49xx CPUs. And since nobody showed interest in keeping support for > > > it, it's time to remove it. > > > > I have an RBTX4927 development board in my board farm, boot-test every > > bi-weekly renesas-drivers release on it, and fix kernel issues when they > > appear. > > > > Is that sufficient to keep it? > > for me it is. But now we probaly need some reverts then... Indeed. Fortunately not all of it, as some removals were TX4938-only. > I wonder whether you have seen my mail about the removal > > https://lore.kernel.org/linux-mips/20201207105627.GA15866@alpha.franken.de > > and my call for people owning MIPS machines > > https://lore.kernel.org/linux-mips/20200227144910.GA25011@alpha.franken.de/ Sorry, I'm not following the linux-mips list that closely, so I hadn't seen them. It's always a good idea to CC linux-kernel, and perhaps the few people who last touched the affected files. > Still "unclaimed" machines are > > IMG Pistachio SoC based boards (MACH_PISTACHIO( > Toshiba TX39 series based machines (MACH_TX39XX) > NEC VR4100 series based machines (MACH_VR41XX) > Netlogic XLR/XLS based systems (NLM_XLR_BOARD) > Netlogic XLP based systems (NLM_XLP_BOARD) > Sibyte BCM91120C-CRhine (SIBYTE_CRHINE) > Sibyte BCM91120x-Carmel (SIBYTE_CARMEL) > Sibyte BCM91125C-CRhone (SIBYTE_CRHONE) > Sibyte BCM91125E-Rhone (SIBYTE_RHONE) > Sibyte BCM91250C2-LittleSur (SIBYTE_LITTLESUR) > Sibyte BCM91250E-Sentosa (SIBYTE_SENTOSA) > > Is there something on this list you also regulary use ? No, I don't have anything from the list above. The RBTX4927 is basically my last MIPS-based system I do boot current kernels on. In active use, not for development: - Ubiquiti EdgeRouter-X (Ralink-based). Stored in my attic: - NetGear WNDR4300 (AtherOS-based), - MikroTik Routerboard 150 (ADMtek-based, no (longer?) supported upstream), - NEC DDB VRC-5476 (upstream support removed 15 years ago ;-) Gr{oetje,eeting}s, Geert
On Wed, 6 Jan 2021 21:41:24 +0100, Geert Uytterhoeven <geert@linux-m68k.org> wrote: >> > Is that sufficient to keep it? >> >> for me it is. But now we probaly need some reverts then... > > Indeed. Fortunately not all of it, as some removals were TX4938-only. These patches should not break RBTX4927: net: tc35815: Drop support for TX49XX boards spi: txx9: Remove driver mtd: Remove drivers used by TX49xx char: hw_random: Remove tx4939 driver rtc: tx4939: Remove driver ide: tx4938ide: Remove driver And these patches just break audio-support only. dma: tx49 removal ASoC: txx9: Remove driver I think dma and ASoC drivers are hard to maintain now, and can be dropped for basic support for RBTX4927. (TX39 boards does not have audio-support, so dma txx9 driver can be dropped too) --- Atsushi Nemoto
Hi Nemoto-san, On Thu, Jan 7, 2021 at 2:18 AM Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote: > On Wed, 6 Jan 2021 21:41:24 +0100, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> > Is that sufficient to keep it? > >> > >> for me it is. But now we probaly need some reverts then... > > > > Indeed. Fortunately not all of it, as some removals were TX4938-only. > > These patches should not break RBTX4927: > > net: tc35815: Drop support for TX49XX boards > spi: txx9: Remove driver > mtd: Remove drivers used by TX49xx > char: hw_random: Remove tx4939 driver > rtc: tx4939: Remove driver > ide: tx4938ide: Remove driver Indeed. > And these patches just break audio-support only. > > dma: tx49 removal > ASoC: txx9: Remove driver > > I think dma and ASoC drivers are hard to maintain now, and can be > dropped for basic support for RBTX4927. > (TX39 boards does not have audio-support, so dma txx9 driver can be > dropped too) Agreed, I don't test audio anyway, but I know it used to work (I had intended to use the board as an MPD media server, but never got beyond the prototyping phase). Gr{oetje,eeting}s, Geert
On Wed, Jan 06, 2021 at 11:10:38AM -0800, Joe Perches wrote: > On Tue, 2021-01-05 at 15:02 +0100, Thomas Bogendoerfer wrote: > > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > [] > > diff --git a/drivers/dma/txx9dmac.h b/drivers/dma/txx9dmac.h > [] > > @@ -26,11 +26,6 @@ > > * DMA channel. > > */ > > > > > > -#ifdef CONFIG_MACH_TX49XX > > -static inline bool txx9_dma_have_SMPCHN(void) > > -{ > > - return true; > > -} > > #define TXX9_DMA_USE_SIMPLE_CHAIN > > #else > > static inline bool txx9_dma_have_SMPCHN(void) > > This doesn't look like it compiles as there's now an #else > without an #if you are right, no idea what I had in mind while doing that. Vinod, as this patch series found a still active user of the platform, could you drop the patch from your tree, or do you want a revert from me ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
On 07-01-21, 17:40, Thomas Bogendoerfer wrote: > On Wed, Jan 06, 2021 at 11:10:38AM -0800, Joe Perches wrote: > > On Tue, 2021-01-05 at 15:02 +0100, Thomas Bogendoerfer wrote: > > > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > [] > > > diff --git a/drivers/dma/txx9dmac.h b/drivers/dma/txx9dmac.h > > [] > > > @@ -26,11 +26,6 @@ > > > * DMA channel. > > > */ > > > > > > > > > -#ifdef CONFIG_MACH_TX49XX > > > -static inline bool txx9_dma_have_SMPCHN(void) > > > -{ > > > - return true; > > > -} > > > #define TXX9_DMA_USE_SIMPLE_CHAIN > > > #else > > > static inline bool txx9_dma_have_SMPCHN(void) > > > > This doesn't look like it compiles as there's now an #else > > without an #if > > you are right, no idea what I had in mind while doing that. > > Vinod, > > as this patch series found a still active user of the platform, > could you drop the patch from your tree, or do you want a revert > from me ? Dropped now
On Tue, 5 Jan 2021 15:02:45 +0100, Thomas Bogendoerfer wrote: > I couldn't find any buyable product other than reference boards using > TX49xx CPUs. And since nobody showed interest in keeping support for > it, it's time to remove it. > > I've split up the removal into seperate parts for different maintainers. > So if the patch fits your needs, please take it via your tree or > give me an ack so I can apply them the mips-next tree. > > [...] Applied, thanks! [08/10] rtc: tx4939: Remove driver commit: 446667df283002fdda0530523347ffd1cf053373 Best regards,