diff mbox series

[v2,10/18] ARM: dts: qcom: sdx55: Add QPIC NAND support

Message ID 20210105122649.13581-11-manivannan.sadhasivam@linaro.org
State Superseded
Headers show
Series Devicetree update for SDX55 platform | expand

Commit Message

Manivannan Sadhasivam Jan. 5, 2021, 12:26 p.m. UTC
Add qpic_nand node to support QPIC NAND controller on SDX55 platform.
Since there is no "aon" clock in SDX55, a dummy clock is provided.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

-- 
2.25.1

Comments

Vinod Koul Jan. 5, 2021, 3:51 p.m. UTC | #1
On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> Add qpic_nand node to support QPIC NAND controller on SDX55 platform.

> Since there is no "aon" clock in SDX55, a dummy clock is provided.

> 

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> ---

>  arch/arm/boot/dts/qcom-sdx55.dtsi | 22 ++++++++++++++++++++++

>  1 file changed, 22 insertions(+)

> 

> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi

> index 1b9b990ad0a2..1a6947753972 100644

> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi

> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi

> @@ -41,6 +41,12 @@ pll_test_clk: pll-test-clk {

>  			#clock-cells = <0>;

>  			clock-frequency = <400000000>;

>  		};

> +

> +		nand_clk_dummy: nand-clk-dummy {


Why dummy..? 
> +			compatible = "fixed-clock";

> +			#clock-cells = <0>;

> +			clock-frequency = <32000>;


Is this sleep clock of platform..?

> +		};

>  	};

>  

>  	cpus {

> @@ -178,6 +184,22 @@ qpic_bam: dma@1b04000 {

>  			status = "disabled";

>  		};

>  

> +		qpic_nand: nand@1b30000 {

> +			compatible = "qcom,sdx55-nand";

> +			reg = <0x01b30000 0x10000>;

> +			#address-cells = <1>;

> +			#size-cells = <0>;

> +			clocks = <&rpmhcc RPMH_QPIC_CLK>,

> +				 <&nand_clk_dummy>;

> +			clock-names = "core", "aon";

> +

> +			dmas = <&qpic_bam 0>,

> +			       <&qpic_bam 1>,

> +			       <&qpic_bam 2>;

> +			dma-names = "tx", "rx", "cmd";

> +			status = "disabled";

> +		};

> +

>  		tcsr_mutex_block: syscon@1f40000 {

>  			compatible = "syscon";

>  			reg = <0x1f40000 0x20000>;

> -- 

> 2.25.1


-- 
~Vinod
Manivannan Sadhasivam Jan. 6, 2021, 7:29 a.m. UTC | #2
On Tue, Jan 05, 2021 at 09:21:02PM +0530, Vinod Koul wrote:
> On 05-01-21, 17:56, Manivannan Sadhasivam wrote:

> > Add qpic_nand node to support QPIC NAND controller on SDX55 platform.

> > Since there is no "aon" clock in SDX55, a dummy clock is provided.

> > 

> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> > ---

> >  arch/arm/boot/dts/qcom-sdx55.dtsi | 22 ++++++++++++++++++++++

> >  1 file changed, 22 insertions(+)

> > 

> > diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi

> > index 1b9b990ad0a2..1a6947753972 100644

> > --- a/arch/arm/boot/dts/qcom-sdx55.dtsi

> > +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi

> > @@ -41,6 +41,12 @@ pll_test_clk: pll-test-clk {

> >  			#clock-cells = <0>;

> >  			clock-frequency = <400000000>;

> >  		};

> > +

> > +		nand_clk_dummy: nand-clk-dummy {

> 

> Why dummy..? 


There is no such clock used on this platform but the driver requires it.

> > +			compatible = "fixed-clock";

> > +			#clock-cells = <0>;

> > +			clock-frequency = <32000>;

> 

> Is this sleep clock of platform..?

> 


Always ON (AON) clock.

Thanks,
Mani
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 1b9b990ad0a2..1a6947753972 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -41,6 +41,12 @@  pll_test_clk: pll-test-clk {
 			#clock-cells = <0>;
 			clock-frequency = <400000000>;
 		};
+
+		nand_clk_dummy: nand-clk-dummy {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <32000>;
+		};
 	};
 
 	cpus {
@@ -178,6 +184,22 @@  qpic_bam: dma@1b04000 {
 			status = "disabled";
 		};
 
+		qpic_nand: nand@1b30000 {
+			compatible = "qcom,sdx55-nand";
+			reg = <0x01b30000 0x10000>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			clocks = <&rpmhcc RPMH_QPIC_CLK>,
+				 <&nand_clk_dummy>;
+			clock-names = "core", "aon";
+
+			dmas = <&qpic_bam 0>,
+			       <&qpic_bam 1>,
+			       <&qpic_bam 2>;
+			dma-names = "tx", "rx", "cmd";
+			status = "disabled";
+		};
+
 		tcsr_mutex_block: syscon@1f40000 {
 			compatible = "syscon";
 			reg = <0x1f40000 0x20000>;